#39989: HPGS @1.1.8 ------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Keywords: | Port: ------------------------+-------------------------------- Easy HPGS installation for macports users[[BR]] My first Portfile creation & submission[[BR]] Developed on 10.5.8[[BR]] -- Ticket URL: <https://trac.macports.org/ticket/39989> MacPorts <http://www.macports.org/> Ports system for OS X
#39989: HPGS @1.1.8 -------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some observations: * The license should be indicated. * MacPorts does follow HTTP redirects when downloading. * To download from sourceforge, use the sourceforge fetch group rather than hardcoding one specific sourceforge server. * Why are you setting the worksrcdir in a pre-build block instead of globally? Doesn't that cause destroot to fail if you run it separately from build? (i.e. "`sudo port build && sudo port destroot`") * When you disable the configure phase you're responsible for adding a universal variant and ensuring that the port is UsingTheRightCompiler and `-arch` flags. * "distname ${name}-${version}" is the default so you don't need to list that. -- Ticket URL: <https://trac.macports.org/ticket/39989#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#39989: HPGS @1.1.8 -------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by egall@…): Also the proper way to obfuscate your email address is like this: {{{ actrix.co.nz:fmw }}} -- Ticket URL: <https://trac.macports.org/ticket/39989#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#39989: HPGS @1.1.8 -------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by fmw@…): Replying to [comment:1 ryandesign@…]: Dear Ryan[[BR]] Sorry, this submission was not meant to go out - I thought I stopped the submission when I found some problems while attaching the files (Patch file naming etc).[[BR]] I logged out without pushing the submit button, so not sure what happened!!![[BR]] I ran out of time, so will have another go in a day or so , and try & fix some of the things you have mentioned (I don't understand how to deal with them all - fetch group & configure).[[BR]] Many thanks[[BR]] Michael -- Ticket URL: <https://trac.macports.org/ticket/39989#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#39989: HPGS @1.1.8 -------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: hpgs | -------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) * port: => hpgs Comment: I've attached a revised portfile, with these changes: * indicated license LGPL-2.1+ * used sourceforge fetch group * set build.dir instead of conditionally setting worksrcdir in the build phase * set correct `-arch` flags and optimization flags and ensure UsingTheRightCompiler * removed unnecessary `distname` directive * fixed obfuscation of maintainer email address * reformatted description and fixed whitespace to conform to modeline Since I don't have the patchfiles referenced I can't see if it builds properly or work on adding a universal variant, though doing so could be as simple as adding the line "`variant universal {}`" before the first invocation of the `get_canonical_archflags` proc. I'm not sure what the Makefile patch does; maybe it's unnecessary with the correct build.args passed in from the Portfile. I can guess that the hpgsimage.c patch will make it compatible with libpng 1.4 and later. -- Ticket URL: <https://trac.macports.org/ticket/39989#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#39989: HPGS @1.1.8 -------------------------+-------------------------------- Reporter: fmw@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: hpgs | -------------------------+-------------------------------- Comment (by fmw@…): Many thanks for doing all that - it has pointed me in the right direction - I hope.[[BR]] I have used your Portfile.2 and adjusted it so it now builds on intel 10.5.8 with gcc 4.2, > file reports:[[BR]] /opt/local/bin/hpgs: Mach-O fat file with 2 architectures: [ : Mach-O ppc_7400 executable ] [ I386: Mach-O i386 executable ][[BR]] It might be possible to eliminate the Makefile patch with some changes in the Portfile build.args[[BR]] The patch adjusts a prefix variable at the start Yes the hpgsimage.c patch makes it do libpng15. I couldn't find a way of making it do something like libpng >= 1.5 and making it work with the Portfile depends_lib section. There is an additional include.mak patch to cope with a flags conflict, and again, there may be better ways to handel that, but I think it is at least working correctly. -- Ticket URL: <https://trac.macports.org/ticket/39989#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts