[MacPorts] #51222: nfft-3 @3.3.1 Update Portfile for new release.
#51222: nfft-3 @3.3.1 Update Portfile for new release. ------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: nfft-3 ------------------------+-------------------------------- This is to update the Portfile for the port nfft-3 to the latest release 3.3.1. -- Ticket URL: <https://trac.macports.org/ticket/51222> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: nfft-3 | -------------------------+-------------------------------- Comment (by macports@…): The Portfile now also specifies the (optional) test phase which will run the provided unit tests. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: nfft-3 | -------------------------+-------------------- Changes (by mf2k@…): * owner: macports-tickets@… => jens@… * version: 2.3.4 => Comment: Thanks. [https://guide.macports.org/#development.patches Per the guidelines], please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. In the future, please Cc the port maintainers ({{{port info --maintainers nfft-3}}}), if any. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by macports@…): Thanks for the information. I am the maintainer of this port, though I'm using a different email address in this ticketing system. Here's the diff output when comparing to the current version: {{{ 8c8 < version 3.3.0 ---
version 3.3.1 39,41c39,41 < master_sites https://www-user.tu- chemnitz.de/~potts/nfft/download/ < checksums rmd160 52cac61a90a72bb25a91b3aa0d1b1692d1895e26 \ < sha256 bb844b762896b17b7bf8245511a6372fcef82e55c2552f2f7ee7c65a8d746f30
master_sites https://github.com/NFFT/nfft/releases/download/${version}/ checksums rmd160 08b4ff6b8d35b2ebc90159a8e86ff400e565528c \ sha256 74cc7f4c8922d72131c59f88ecb542e06254eaded09018d6367f8a46c0fb3125 49a50,52 test.run yes test.target check
}}} In essence, the version number has been bumped, the download location has been updated (assets are now provided directly on GitHub), and the optional test target has been added. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by mf2k@…): Then you should either change your trac email to match the portfile or vice versa. Otherwise we have no idea that the maintainer is attaching a patch. Also, please instead use the github portgroup. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by jens@…): G'day, I have updated the Portfile to use the PortGroup github. I have also changed my user's email address to match the one in the Portfile. The dependency is a bit awkward since I would be forced to create a separate account if a different maintainer email would be used for another port maintained by myself. Best, Jens -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: nfft-3 | -------------------------+-------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => fixed Comment: Normally, you would upload a diff - I went ahead and cleaned up the Portfile a bit r148677 -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by dstrubbe@…): Why did you remove the use of the compilers portgroup? There is no mention of that change in this discussion or the resulting commit. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by khindenburg@…): Perhaps Jens accidently removed it - should I re-add it? -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by dstrubbe@…): Yes it looks like that might have been a mistake. I think it is helpful to use the compilers portgroup, since for scientific/mathematical ports like this, one might wish to try different compilers to find the best performance, so I think it should be re-added. -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#51222: nfft-3 @3.3.1 Update Portfile for new release. -------------------------+-------------------- Reporter: macports@… | Owner: jens@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: nfft-3 | -------------------------+-------------------- Comment (by khindenburg@…): done r148786 -- Ticket URL: <https://trac.macports.org/ticket/51222#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts