[MacPorts] #43121: abinit 7.4.3: update to revision 1
#43121: abinit 7.4.3: update to revision 1 ------------------------+-------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: abinit ------------------------+-------------------------------- Abinit 7.4.3: update to revision 1: use of compilers and mpi portgroups automatic detection of selected mpi addition of fftw3-single dependency addition of no_mpi variant Ticket for revision 0: #42017 -- Ticket URL: <https://trac.macports.org/ticket/43121> MacPorts <http://www.macports.org/> Ports system for OS X
#43121: abinit 7.4.3: update to revision 1 -------------------------+--------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch maintainer Port: abinit | -------------------------+--------------------------------- Changes (by ryandesign@…): * keywords: => haspatch maintainer Old description:
Abinit 7.4.3: update to revision 1:
use of compilers and mpi portgroups automatic detection of selected mpi addition of fftw3-single dependency addition of no_mpi variant
Ticket for revision 0: #42017
New description: Abinit 7.4.3: update to revision 1: * use of compilers and mpi portgroups * automatic detection of selected mpi * addition of fftw3-single dependency * addition of no_mpi variant Ticket for revision 0: #42017 -- Comment: Please attach a unified diff of the portfile so that we can see what changes are being proposed. -- Ticket URL: <https://trac.macports.org/ticket/43121#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43121: abinit 7.4.3: update to revision 1 -------------------------+--------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch maintainer Port: abinit | -------------------------+--------------------------------- Comment (by cram5431@…): Portfile-rev0 vs Portfile rev1 -- Ticket URL: <https://trac.macports.org/ticket/43121#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#43121: abinit 7.4.3: update to revision 1 -------------------------+--------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch maintainer Port: abinit | -------------------------+--------------------------------- Comment (by ryandesign@…): Thanks. A couple observations: * I see you added a "no_mpi" variant. For several years, we've been phasing out variants whose names begin with "no_", and we don't want to add any such new negatively-named variants; they should no longer be necessary. If a user doesn't want a functionality, they simply don't select the corresponding positively-named variant, or if that variant is on by default, they deselect it. MacPorts did not used to remember deselected variants during upgrades, but that bug was fixed years ago, removing the need for negatively-named variants. * I see you changed the presentation of ui_errors by putting a newline before and after your error text. This serves to make the display of errors in this port different from the display of errors in every other port, and that does not seem desirable. -- Ticket URL: <https://trac.macports.org/ticket/43121#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43121: abinit 7.4.3: update to revision 1 -------------------------+--------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch maintainer Port: abinit | -------------------------+--------------------------------- Comment (by cram5431@…): Thanks for the comments and coding rules. Point 2. is easy to solve... Point 1. (no_mpi variant) I understand the macports coding rules. But I don't find a way to obtain the following behavior for the port: * if a mpi variant is given, take it * if no mpi variant is given, look for a possible selected mpi (in etc/select/mpi). If there is a default mpi, take it. * if there is no defaut mpi, take mpich. But, I also would like to give the possibility to compile Abinit without any mpi library (i.e. in sequential mode). I didn't find a suitable way to do that, except with a variant for the sequential mode. Any idea ? Could a "sequential" variant fit the coding rules ? If not, I'll drop this option. -- Ticket URL: <https://trac.macports.org/ticket/43121#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts