[MacPorts] #37031: Toluapp Portfile
#37031: Toluapp Portfile ------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: ------------------------------+-------------------------------- I would like to add my Portfile to allow OSX users to easily install tolua++. The original code is @ http://www.codenix.com/~tolua/ (Which seems to not be maintained). I found this luadist project @ https://github.com/LuaDist/ and created the following Portfile. Thank You -- Ticket URL: <https://trac.macports.org/ticket/37031> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some initial comments: * Since this project is hosted at github, please try using the github portgroup. * A fetch dependency on git-core needn't be added; MacPorts base does so for you automatically when fetch.type is git. * But if possible, fetch a tarball, not from git. * I see there's a tag for 1.0.93; perhaps that's what the version should be, and the tarball that should be downloaded. * /opt/local should not be hardcoded; use ${prefix} instead. * But -DCMAKE_INSTALL_PREFIX needn't be set manually; the cmake portgroup sets it for you. * In MacPorts we usually replace "+"s in project names with "x"s not "p"s. * But since the project seems to be referred to as toluapp by upstream in a few places already I guess we can keep that name too. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------------+-------------------------------- Comment (by brad.clemetson@…): ok, I'll make those changes and attach a new one. (First time making a Portfile) -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------------+-------------------------------- Comment (by brad.clemetson@…): I think I have implemented the changes above but I am not sure where to get/generate the correct checksums for version 1.0.93? Thank You -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------------+-------------------------------- Comment (by macsforever2000@…): A few more observations: - When using portgroups, you should always {{{-append}}} dependencies so you don't override the ones that the portgroup already adds. - Since you are using the cmake portgroup, you do not need to add a dependency on cmake. - You should remove the URL from the long_description. - The {{{configure.post_args ..}}} line looks suspicious to me. What are you trying to accomplish there? - You can get the correct checksums by first running {{{port -v checksum}}} and using the value that it suggests in the output. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: toluapp | -------------------------------+-------------------------------- Changes (by macsforever2000@…): * cc: brad.clemetson@… (removed) * version: 2.1.2 => * port: => toluapp Comment: The reporter is automatically Cc'ed. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: toluapp | -------------------------------+-------------------------------- Comment (by brad.clemetson@…): Made those additional changes, the only thing I am not certain of is if I implemented the -append correctly For "configure.post_args .." is used to tell Cmake where CMakelists.txt is located. I think what it does is it creates a directory called build and changes into that directory. Which then cmake is called and the post_args tells it to look for the build configuration one directory above it. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------------- Reporter: brad.clemetson@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: toluapp | -------------------------------+-------------------------------- Comment (by brad.clemetson@…): Are there additional changes I should make? -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------- Reporter: brad.clemetson@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: toluapp | -------------------------------+-------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: Thanks. Only other thing is that the github.setup line is meant to replace the name, version and homepage lines. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37031: Toluapp Portfile -------------------------------+-------------------------- Reporter: brad.clemetson@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: toluapp | -------------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: r100161 with those changes and a little minor reformatting. And yes "configure.post_args .." is one way that cmake ports can do part of doing an out-of-source build. See #33259 for efforts to streamline this. -- Ticket URL: <https://trac.macports.org/ticket/37031#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts