[MacPorts] #46766: Update: mysql56 5.6.23
#46766: Update: mysql56 5.6.23 ----------------------------+-------------------------------- Reporter: mschamschula@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: mysql56 ----------------------------+-------------------------------- mysql56 has been updated to version 5.6.23. Unfortunately, my build dies as I get {{{ /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_mysql56/mysql56/work/mysql-5.6.23/sql/mysqld.cc:7779:10: error: use of undeclared identifier 'yaSSL_ASN1_TIME_to_string' return yaSSL_ASN1_TIME_to_string(time, buf, len); ^ 1 error generated. }}} -- Ticket URL: <https://trac.macports.org/ticket/46766> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Changes (by larryv@…): * cc: pixilla@… (removed) * owner: macports-tickets@… => pixilla@… * version: 2.3.3 => * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by pixilla@…): mschamschula: Will you be attaching the "patch-sql-mysqld.cc.diff" included in [attachment:Portfile-mysql56.diff]? -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by steven.pearce@…): I am also getting this error. I upgraded my ports from 2.3.2 to 2.3.3 and when bulding mysql I see the following. although I notice the directory is slightly different as mine refers to mysql-5.6.22. {{{:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_databases_mysql56/mysql56/work/mysql-5.6.22/sql/mysqld.cc:7779:10: error: use of undeclared identifier 'yaSSL_ASN1_TIME_to_string'}}} I notice you are asking for {{{patch-sql-mysqld.cc.diff}}}, if you tell me where that file would be located I will attach it for you. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by mschamschula@…): Replying to [comment:2 pixilla@…]:
mschamschula: Will you be attaching the "patch-sql-mysqld.cc.diff" included in [attachment:Portfile-mysql56.diff]?
Sure. The attached version of the patch file is on elf many variants I tried. However, the build still fails. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by mschamschula@…): Apparently pixilla committed https://trac.macports.org/changeset/132791, essentially Portfile-mysql56.diff. My build under Mavericks still fails at the same point. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): Upstream bug: http://bugs.mysql.com/bug.php?id=75622 The change that broke things was in OpenSSL 1.0.2. The fix is updating a regex in cmake/ssl.cmake to account for some extra whitespace. I've applied the suggested patch locally and got things working. I'll start putting a patch together now, and will attach it if this hasn't been fixed before I'm done. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by mschamschula@…): I've recast asedeno's patch to patch cmake/ssl.cmake directly, as I could not find files/patch-cmake-ssl.cmake.diff under mysql56. This does work for me. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): It wasn't there because files/patch-cmake-ssl.cmake.diff is created by my patch. That was an svn diff of my checkout of the macports source tree. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by pixilla@…): Replying to [comment:9 asedeno@…]:
Upstream bug: http://bugs.mysql.com/bug.php?id=75622
The change that broke things was in OpenSSL 1.0.2. The fix is updating a regex in cmake/ssl.cmake to account for some extra whitespace.
I've applied the suggested patch locally and got things working. I'll start putting a patch together now, and will attach it if this hasn't been fixed before I'm done.
Are you building mysql56 with the non-default +openssl variant? -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by pixilla@…): Replying to [comment:6 mschamschula@…]:
Apparently pixilla committed https://trac.macports.org/changeset/132791, essentially Portfile-mysql56.diff. My builds under Mavericks and Yosemite still fail at the same point.
I committed after a successful build of mysql56 5.6.23 on Mavericks. Your attached log appears to be truncated. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): Replying to [comment:12 pixilla@…]:
Are you building mysql56 with the non-default +openssl variant?
Nope. asedeno@Groose:~$ port installed | grep mysql56 mysql56 @5.6.23_0 (active) -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:14> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): Looking more closely at the Portfile, the openssl variant does nothing and what it should do is unconditionally enabled. It's been that way since last June. https://trac.macports.org/changeset/120632 -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by pixilla@…): Replying to [comment:15 asedeno@…]:
Looking more closely at the Portfile, the openssl variant does nothing and what it should do is unconditionally enabled. It's been that way since last June. https://trac.macports.org/changeset/120632 Thanks for the reminder.
-- Ticket URL: <https://trac.macports.org/ticket/46766#comment:16> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by charlie.clark@…): I've just tried building from a checkout but I'm still getting the same error (on 10.10.2). Anything special I need to do? -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:17> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Changes (by pixilla@…): * status: new => closed * resolution: => fixed Comment: asedeno: Thanks for the patch. Builds on all MacPorts buildbots. See r132850 -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:18> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): Replying to [comment:18 pixilla@…]:
asedeno: Thanks for the patch. Builds on all MacPorts buildbots. See r132850
Thanks for applying it. It just occurred to me that I took the wrong (less general) fix from the upstream bug, though. The added [\t ]+ should have been [\t ]* I can send another patch or open another bug if you like. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:19> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by pixilla@…): Like this? {{{#!diff -u Index: files/patch-cmake-ssl.cmake.diff =================================================================== --- files/patch-cmake-ssl.cmake.diff (revision 132876) +++ files/patch-cmake-ssl.cmake.diff (working copy) @@ -5,7 +5,7 @@ FILE(STRINGS "${OPENSSL_INCLUDE_DIR}/openssl/opensslv.h" OPENSSL_VERSION_NUMBER - REGEX "^#define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" -+ REGEX "^#[\t ]+define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" ++ REGEX "^#[\t ]*define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" ) STRING(REGEX REPLACE "^.*OPENSSL_VERSION_NUMBER[\t ]+0x([0-9]).*$" "\\1" }}} -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:20> MacPorts <https://www.macports.org/> Ports system for OS X
#46766: mysql56 @5.6.22_0: update to 5.6.23 -----------------------------+----------------------- Reporter: mschamschula@… | Owner: pixilla@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: mysql56 | -----------------------------+----------------------- Comment (by asedeno@…): Replying to [comment:20 pixilla@…]:
Like this? {{{#!diff Index: files/patch-cmake-ssl.cmake.diff =================================================================== --- files/patch-cmake-ssl.cmake.diff (revision 132876) +++ files/patch-cmake-ssl.cmake.diff (working copy) @@ -5,7 +5,7 @@ FILE(STRINGS "${OPENSSL_INCLUDE_DIR}/openssl/opensslv.h" OPENSSL_VERSION_NUMBER - REGEX "^#define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" -+ REGEX "^#[\t ]+define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" ++ REGEX "^#[\t ]*define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x[0-9].*" ) STRING(REGEX REPLACE "^.*OPENSSL_VERSION_NUMBER[\t ]+0x([0-9]).*$" "\\1"
}}}
Just like that. I'll have to remember the inline diff thing for later. -- Ticket URL: <https://trac.macports.org/ticket/46766#comment:21> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts