[MacPorts] #43516: dot2tex patch to accomodate pyparsing changes
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+-------------------------------- Reporter: p.bro@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: haspatch | Port: dot2tex ----------------------+-------------------------------- dot2tex stopped working for me with the following error: {{{ Traceback (most recent call last): File "/opt/local/bin/dot2tex", line 2, in <module> from dot2tex.dot2tex import main File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7 /site-packages/dot2tex/__init__.py", line 36, in <module> import dot2tex as d2t File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7 /site-packages/dot2tex/dot2tex.py", line 47, in <module> import dotparsing File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7 /site-packages/dot2tex/dotparsing.py", line 26, in <module> from pyparsing import (Literal, CaselessLiteral, Word, Upcase, OneOrMore, ZeroOrMore, ImportError: cannot import name _noncomma }}} This is due to changes in the pyparsing module. However, _noncomma is not actually used, and so the easy fix is to remove this in the import. The original author has corrected this bug in https://github.com/kjellmf/dot2tex/commit/d189780361b862cdabe4f3499269ad30aa... #diff-abe89aaefb3d77955a9c662a17c1d7d0 (other changes are mostly whitespace). Unfortunately that patch is not yet part of a released version of dot2tex. I have created a patch that removes the unused _noncomma, and attached the rev-bumped Portfile and the patch. The resulting dot2tex-2.8.7-2 works for me. -- Ticket URL: <https://trac.macports.org/ticket/43516> MacPorts <http://www.macports.org/> Ports system for OS X
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+-------------------------------- Reporter: p.bro@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: dot2tex | ----------------------+-------------------------------- Comment (by p.bro@…): As an aside: The last released dot2tex version is from 2009. The code has since moved to github https://github.com/kjellmf/dot2tex with a number of patches. Apparently a new release is in the making (see https://github.com/kjellmf/dot2tex/commits/master) so it might be worthwhile monitoring github... -- Ticket URL: <https://trac.macports.org/ticket/43516#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+---------------------- Reporter: p.bro@… | Owner: snc@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: dot2tex | ----------------------+---------------------- Changes (by mf2k@…): * owner: macports-tickets@… => snc@… Comment: In the future, please Cc the port maintainers ({{{port info --maintainers dot2tex}}}). -- Ticket URL: <https://trac.macports.org/ticket/43516#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+---------------------- Reporter: p.bro@… | Owner: snc@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: dot2tex | ----------------------+---------------------- Comment (by p.bro@…): Darn, I thought that was done automatically. Sorry about that. -- Ticket URL: <https://trac.macports.org/ticket/43516#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+---------------------- Reporter: p.bro@… | Owner: snc@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: dot2tex | ----------------------+---------------------- Changes (by snc@…): * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/43516#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#43516: dot2tex patch to accomodate pyparsing changes ----------------------+---------------------- Reporter: p.bro@… | Owner: snc@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: haspatch Port: dot2tex | ----------------------+---------------------- Changes (by snc@…): * status: assigned => closed * resolution: => fixed Comment: Patched in r119537. -- Ticket URL: <https://trac.macports.org/ticket/43516#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts