[MacPorts] #43677: py-pyne @0.4 add port
#43677: py-pyne @0.4 add port -------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: py-pyne -------------------------------+-------------------------------- -- Ticket URL: <https://trac.macports.org/ticket/43677> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by mf2k@…): Comments: - The {{{maintainers}}} line cannot be blank. For no maintainer you would put: {{{maintainers nomaintainer}}} - The {{{distfiles}}} line should not be set directly. Based on your {{{distname}}}, you can just delete the line because that is the {{{distfiles}}} line that would be generated. - It looks like the version is actually 0.4-rc1. Is that correct? Use that as the {{{version}}}. - You are hard coding the version number in the {{{distname}}} and that is not correct. You should be using: {{{distname ${realname}-${version}}}} -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): I updated the `maintainers` and `distname` as suggested but if I try and remove the `distfiles` line it looks for pyne-0.4-rc1.tar.gz instead of 0.4-rc1.tar.gz. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by mf2k@…): That's an odd archive name. In any event, then the distname is incorrect and simply needs to be "${version}". -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): Replying to [comment:3 mf2k@…]:
That's an odd archive name. In any event, then the distname is incorrect and simply needs to be "${version}".
So github is a bit funny the way it packages archives. The archive is hosted at ${version}${extract.suffix} but that points to an archive that is actually downloaded as ${realname}-${version}${extract.suffix} because of this changing `distname` to anything else will lead the build to fail as far as I can tell. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by mf2k@…): I should have noticed that. This port should use the github portgroup which handles all of these quirks. See the OpenBLAS port, among many others, for an example of how to implement that. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): Replying to [comment:5 mf2k@…]:
I should have noticed that. This port should use the github portgroup which handles all of these quirks. See the OpenBLAS port, among many others, for an example of how to implement that. Using the github portgroup made everything much simpler. Should be good for another look now.
-- Ticket URL: <https://trac.macports.org/ticket/43677#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): Anything else that is needed before this can be merged? -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by mf2k@…): This does not work for me. I had to manually set the name to py-pyne and then I hit an error. My Portfile attached along with my main.log. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): The build is failing because it can't find the cython binary. We're working on a fix for our cmake script right now. I'll update the Portfile as soon as it's been merged. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#43677: py-pyne @0.4 add port --------------------------------+-------------------------------- Reporter: cameron.r.bates@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-pyne | --------------------------------+-------------------------------- Comment (by cameron.r.bates@…): The build issue should be fixed now. -- Ticket URL: <https://trac.macports.org/ticket/43677#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts