[MacPorts] #23325: clhep config scripts include architectures
#23325: clhep config scripts include architectures -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: cristiano.fontana@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: clhep -------------------------------------+-------------------------------------- The config scripts clhep installs all have the build architectures in them: {{{ $ clhep-config --ldflags -L/opt/local/lib -arch x86_64 -arch i386 }}} These should be removed post-build or post-destroot. See the curl and gd2 ports for an example (though they both use the muniversal portgroup; since clhep doesn't, you won't be using [muniversal_get_arch_flag]). -- Ticket URL: <http://trac.macports.org/ticket/23325> MacPorts <http://www.macports.org/> Ports system for Mac OS
#23325: clhep config scripts include architectures -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: cristiano.fontana@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: clhep -------------------------------------+-------------------------------------- Comment(by cristiano.fontana@…): I hope that the regex is in the right dialect... -- Ticket URL: <http://trac.macports.org/ticket/23325#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#23325: clhep config scripts include architectures --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: cristiano.fontana@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Resolution: fixed | Keywords: Port: clhep | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Your patch does not work for many reasons: * square brackets inside double quotes are interpreted by tcl; you need to either escape square brackets with a backslash or use curly quotes instead of double quotes * you need to specify the full path to the files you're reinplacing; do not assume any particular working directory * more files than just clhep-config are affected; to see all the files that are affected you can use `port contents clhep | sed 1d | xargs grep -- ' -arch '` The above suggests to me you did not test your patch. Please test your patches before submitting them. You also need to increase the port's revision when making changes that alter the contents of files installed by the port. I have fixed the issue in r63750. -- Ticket URL: <http://trac.macports.org/ticket/23325#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts