[MacPorts] #38616: Update: yara to 1.7
#38616: Update: yara to 1.7 --------------------------+-------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Keywords: | Port: yara --------------------------+-------------------------------- Updated YARA to version 1.7. Added variants to build either with re2 or pcre support. -- Ticket URL: <https://trac.macports.org/ticket/38616> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: Update: yara to 1.7 ---------------------------+-------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: yara | ---------------------------+-------------------------------- Comment (by egall@…): Diff between this and the current Portfile? -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: Update: yara to 1.7 ---------------------------+-------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: yara | ---------------------------+-------------------------------- Comment (by a.schuster@…): Replying to [comment:1 egall@…]:
Diff between this and the current Portfile?
.. is now attached to the ticket. -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: yara: update to 1.7 ---------------------------+--------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch maintainer Port: yara | ---------------------------+--------------------------------- Changes (by ryandesign@…): * keywords: => haspatch maintainer Comment: Thanks. Some observations: * The `$Id$` line should not be removed. * When updating to a new version, the `revision` line should be removed or set to 0. * "universal_variant yes" is the default and does not need to be mentioned explicitly. * The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will ''not'' be used if the pcre variant is ''not'' selected. -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: yara: update to 1.7 ---------------------------+--------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch maintainer Port: yara | ---------------------------+--------------------------------- Comment (by a.schuster@…): Replying to [comment:3 ryandesign@…]:
Thanks. Some observations:
Thanks for your helpful comments! I've attached a revised Portfile.
* The `$Id$` line should not be removed. * When updating to a new version, the `revision` line should be removed or set to 0. * "universal_variant yes" is the default and does not need to be mentioned explicitly.
done.
* The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will ''not'' be used if the pcre variant is ''not'' selected.
Now there's only one variant that enables re2, and at the same time disables pcre. -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: yara: update to 1.7 ---------------------------+--------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch maintainer Port: yara | ---------------------------+--------------------------------- Comment (by ryandesign@…): Replying to [comment:4 a.schuster@…]:
Now there's only one variant that enables re2, and at the same time disables pcre.
Ok, that works. I didn't mind the two conflicting variants, in fact I usually prefer that when there is a choice of two different libraries for a feature (vs. when it's just a choice of whether to enable or disable a feature, in which case a single variant should be used). What I minded was that you left open the possibility that the user could deselect ''both'' of the variants, which would then still use pcre if it was installed but not declare a dependency on it. -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#38616: yara: update to 1.7 ---------------------------+--------------------------------- Reporter: a.schuster@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: fixed | Keywords: haspatch maintainer Port: yara | ---------------------------+--------------------------------- Changes (by ryandesign@…): * status: new => closed * cc: ryandesign@… (added) * resolution: => fixed Comment: Replying to [comment:4 a.schuster@…]:
Thanks for your helpful comments! I've attached a revised Portfile.
r105138 -- Ticket URL: <https://trac.macports.org/ticket/38616#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts