[MacPorts] #44119: kdelibs4: remove FindFlex.cmake
#44119: kdelibs4: remove FindFlex.cmake ---------------------+---------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: kdelibs4 ---------------------+---------------------- Please remove `FindFlex.cmake` from `kdelibs4`, test if it still works after removal and also ask the upstream for a fix. Apparently a better version is part of CMake already. See comment:10:ticket:44104. -- Ticket URL: <https://trac.macports.org/ticket/44119> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by rjvbertin@…): Also see https://trac.macports.org/ticket/44104#comment:14 : reinstalling cmake fixes the issue, so a simple kdelibs patch that removes FindFLEX.cmake (say from destroot) should resolve the issue locally. I'm not sure about requesting an upstream fix. I just checked on my (K)Ubuntu rig; `/usr/share/cmake-2.8/Modules/FindFLEX.cmake` is part of the cmake-data package, whereas kdelibs5-dev package installs a file `/usr/share/kde4/apps/cmake/modules/FindFlex.cmake` . Having noticed that, I see that the MacPorts kdelibs4 port installs a file `/opt/local/share/apps/cmake/modules/FindFlex.cmake`. I'm a bit at a loss why the solution I suggested in the other ticket worked, but at least I understand why I never had a problem: my /opt/local points to a tree on a case-sensitive partition. So I think that the only thing that can be done upstream is asking why they provide their own version of this file. If there's a good reason, MacPorts will have to find a workaround if they wish to continue to support case-insensitive filesystems. I'm not 100% sure, but I have a hunch that cmake might well impose certain rules on cmake filenames, and in that case there isn't much choice that will disambiguate FindFLEX and FindFlex after case-folding. -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by mojca@…): The main question is: why does `kdelibs4` even need its own `FindFlex.cmake` if it's already part of CMake? -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by rjvbertin@…): Yep. So who's going to ask it upstream - the port maintainer (and which port, kdelibs4 or digikam since that's the only one we know to be affected)? -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by mojca@…): We need to ask `kdelibs4` developers. Digikam has nothing to do with this problem (unless – I didn't check – it uses the wrong version of Flex vs. FLEX). Anyone can submit a bug report, but I'm not even using any of that software, so I would prefer if someone else would do it. The maintainer needs to make sure that the file is removed in MacPorts (whether or not the upstream changes anything). -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by nicos@…): I'll make the commit later today. For reference, when looking at the two folders, I found at least the files below which are installed both by cmake and kdelibs4, usually with a difference in capitals. FindAlsa.cmake[[BR]] FindFlex.cmake[[BR]] FindGettext.cmake[[BR]] FindLibLZMA.cmake[[BR]] FindLibXslt.cmake[[BR]] FindRUBY.cmake I did not look up if they are identical or not, but several of them should be working, as they should be used by low-level ports during the configure stage. -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: kdelibs4 | -----------------------+--------------------- Comment (by nicos@…): Committed in r121377. I will report the issue upstream later. -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#44119: kdelibs4: remove FindFlex.cmake -----------------------+--------------------- Reporter: mojca@… | Owner: nicos@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: kdelibs4 | -----------------------+--------------------- Changes (by nicos@…): * status: new => closed * resolution: => fixed Comment: Issue reported upstream at: https://bugs.kde.org/show_bug.cgi?id=337234 -- Ticket URL: <https://trac.macports.org/ticket/44119#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts