#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Changes (by jmr@…): * cc: jeremyhu@… (added) Comment: r130565 was certainly incorrect to add the destroot stuff in pre-build. However I could never reproduce the problem that it supposedly solved. -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X

#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Comment (by michaelld@…): +1 looks good to me. -Always- best programming technique to keep phases separate. -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X

#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: Jeremy evidently thought there was a problem that r130565 fixed, so I'd err on the side of caution and fix it as Marcus proposed in his patch. -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X

#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Comment (by jmr@…): I tested the examples he gave at the time and the change did nothing. https://lists.macosforge.org/pipermail/macports- dev/2015-January/029391.html Adding a chunk of code that does nothing is a bad idea. -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X

#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Comment (by michaelld@…): OK; yeah. What Jeremy writes sounds correct. Maybe we need duplicate build and destroot phase settings: both in both areas so that the builds are consistent no matter which phase one starts in? Redundant, yes; but, maybe better than the alternative. Hmmm ... Wishing whoever put that code in place also included a link to a ticket or something useful as to why it's there. Ah well; here we are now! -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X

#49948: python-1.0.tcl: destroot.env not always modified -------------------------+-------------------------------- Reporter: mcalhoun@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: | -------------------------+-------------------------------- Comment (by jeremyhu@…): I was reproducing it myself. I don't have logs from that. If you want to remove it, go ahead, and if/when it crops back up, we can re-explore it. -- Ticket URL: <https://trac.macports.org/ticket/49948#comment:14> MacPorts <https://www.macports.org/> Ports system for OS X