[MacPorts] #50687: netgen @5.3.1 Add nglib and occ variants
#50687: netgen @5.3.1 Add nglib and occ variants -------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: netgen -------------------------+-------------------------------- I've added two variants, which are meant to enable features available in the netgen configure script. The nglib variant installs a shared library for netgen, and the occ variant builds in support for the opencascade CAD kernel. The nglib variant is a little more complex than might be expected - this is because using nglib requires some headers, which aren't installed by netgen's makefile. Those headers are installed into ${prefix}/share/netgen/libsrc following the example used in Linux distributions. The occ variant requires a small patch, also included. Reason for this request is to enable the finite element workbench in FreeCAD, which uses nglib for meshing. Thanks! -Ian- -- Ticket URL: <https://trac.macports.org/ticket/50687> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: netgen | --------------------------+-------------------------------- Comment (by ian.rees@…): Updated the portfile to use ${prefix}/include/netgen for the headers instead of ${prefix}/share/netgen/libsrc following discussion with another FreeCAD developer. Sorry about the quick change! -Ian- -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+-------------------------------- Changes (by mf2k@…): * keywords: => haspatch * version: 2.3.4 => -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+-------------------------------- Comment (by sean@…): Is there any reason not to always enable shared libraries? I try to make sure those are always there in my ports. The rest of it looks ok to me. I should probably add mpi to it one day. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+-------------------------------- Comment (by ian.rees@…): Replying to [comment:3 sean@…]:
Is there any reason not to always enable shared libraries? Not sure - as far as I'm concerned it's fine to turn on that option by default.
-- Ticket URL: <https://trac.macports.org/ticket/50687#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+-------------------------------- Comment (by ian.rees@…): Replying to [comment:3 sean@…]:
Is there any reason not to always enable shared libraries? I try to make sure those are always there in my ports. The rest of it looks ok to me. Apologies for the double post - should I submit another patch to add "default_variants +nglib" ? -Ian-
-- Ticket URL: <https://trac.macports.org/ticket/50687#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+-------------------------------- Reporter: ian.rees@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+-------------------------------- Comment (by sean@…): No worries, I can fix it in flight when I get back next week. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Changes (by sean@…): * owner: macports-tickets@… => sean@… * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by mark.brethen@…): I have attached a diff file of the additions to ng_vol from the calculix distro. Note: this was NetGen 5.1. cgx uses “ng_vol“ to allow for tet meshing with a target element size. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by ian.rees@…): Do we need to get this merged before the Calculix ccx and cgx Port then? My personal goal is FEM working in FreeCAD for people who use MacPorts. For that use case, we need both ccx and nglib before we get FreeCAD FEM, but there's no dependency between ccx and nglib AFAICT. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by mark.brethen@…): I tested ng_vol with calculix and it is working so the ng_vol.cpp.diff can be discarded. Netgen is a run dependency but you can also use gmsh with calculix. You wouldn't need to merge the nglib and occ variants before the calculix release. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by mark.brethen@…): After further testing this afternoon I have determined that element target size wasn't working. Add patch-nglib-ng_vol.cpp.diff to files directory and revise portfile to include patch. This will need to be merged before the Calculix port, otherwise you will not be able to control element size when meshing with netgen. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by sean@…): I've lost some context here but do we really need this as a variant? Why not just build it all the time? -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by mark.brethen@…): The ng_vol.cpp patch should build all the time. -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:14> MacPorts <https://www.macports.org/> Ports system for OS X
#50687: netgen @5.3.1 Add nglib and occ variants --------------------------+---------------------- Reporter: ian.rees@… | Owner: sean@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: netgen | --------------------------+---------------------- Comment (by ian.rees@…): Have updated the Portfile diff, I think the current state of attachments to this ticket is: patch-libsrc-occ-Partition_Loop2d.cxx.diff - Added to netgen's files ng_vol.cpp.diff - Discard this patch-nglib-ng_vol.cpp.diff - Added to netgen's files netgen.Portfile.diff - Patch to be applied against the Portfile Thanks! -Ian- -- Ticket URL: <https://trac.macports.org/ticket/50687#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts