[MacPorts] #25557: lang/python24: incorrect include path in PortGroup
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: ------------------------------+--------------------------------------------- The port group for Python 2.4 specifies an incorrect value for ${python.include}, as 2.4 isn't built as a framework. The following trivial patch fixes it: {{{ --- python24-1.0.tcl +++ python24-1.0.tcl @@ -37,7 +37,7 @@ set python.lib ${prefix}/lib/libpython${python.branch}.dylib set python.libdir ${frameworks_dir}/Python.framework/Versions/${python.branch}/lib/python${python.branch} set python.pkgd ${prefix}/lib/python${python.branch}/site-packages -set python.include ${frameworks_dir}/Python.framework/Versions/${python.branch}/include/python${python.branch} +set python.include ${prefix}/include/python${python.branch} categories python }}} -- Ticket URL: <http://trac.macports.org/ticket/25557> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: ------------------------------+--------------------------------------------- Comment(by roel@…): I'll test it and have someone commit the patch. Thanks! -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Changes (by jmr@…): * cc: openmaintainer@… (removed) * port: => python24 Comment: It is built as a framework sometimes, so this needs to be conditional. -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by danchr@…): Ah, I see. I just looked at the ''python24'' Portfile and it seems it's this snippet that does it: {{{ … # 64-bit, can't build mac-specific stuff configure.args-delete --enable-framework=${frameworks_dir} configure.args-append --disable-toolbox-glue destroot.target install maninstall … }}} What was the reason to not install a framework for 64-bit non-universal builds? It strikes me as a somewhat odd thing to do… -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by danchr@…): Bump? -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by roel@…): Sorry, missed the reply somehow :/ It was committed in r69441, but without any reason. jmr@macports.org, would you mind to explain, 'cause I don't understand. -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by jmr@…): It was actually added in r56584, for the simple reason that it didn't build otherwise. If you can make the framework and toolbox glue build correctly for 64-bit archs, feel free to do so. -- Ticket URL: <http://trac.macports.org/ticket/25557#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by danchr@…): The attachment above solves this in another way: it disables Python 2.4 for 64-bit architectures. The simplest way to work around the fact that it doesn't build as 64-bit, seems to be not to try building it as such… -- Ticket URL: <https://trac.macports.org/ticket/25557#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup ------------------------------+--------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: python24 ------------------------------+--------------------------------------------- Comment(by jmr@…): Or we could just set the portgroup variables correctly and keep building for the arch that the user has configured. -- Ticket URL: <https://trac.macports.org/ticket/25557#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25557: lang/python24: incorrect include path in PortGroup -------------------------------+-------------------------------------------- Reporter: danchr@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: python24 | -------------------------------+-------------------------------------------- Changes (by jmr@…): * status: new => closed * resolution: => fixed Comment: r71942 -- Ticket URL: <https://trac.macports.org/ticket/25557#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts