[MacPorts] #47941: Submission: New port: py-triangle
#47941: Submission: New port: py-triangle ------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: py-triangle ------------------------+-------------------------------- Adds a port for the python bindings to the triangle library. -- Ticket URL: <https://trac.macports.org/ticket/47941> MacPorts <https://www.macports.org/> Ports system for OS X
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by mf2k@…): Thanks. Some comments: - The {{{depends_lib-append}}} line needs to go inside the {{{if {$subport != $name} }}} block. - Can we also add openmaintainer? -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by mojca@…): * If you use the GitHub PortGroup, you don't need the pypi master site. * No need for python versions 32 33, those are phased out, it's better to use 34 and 35 only (36 is not yet ready). * There is a minor whitespace inconsistency inside the block. -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:3> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by mojca@…): More important though: the `triangle` dependency could use some cleanup and needs a maintainer as well. It fetches {{{ /opt/local/var/macports/distfiles/triangle/triangle.zip }}} instead of using at least some version number somewhere (then again this probably doesn't need a change before some update comes up). It also needs some whitespace cleanup. -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:4> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Changes (by mojca@…): * version: 2.3.3 => -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:5> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by smithsp@…): I appreciate the review. You will need to be more specific about the whitespace problems of this Portfile. I do not intend to change the triangle Portfile. -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:6> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by mojca@…): Just curious: why did you completely drop python 3 now? One thing that confuses me is the mixture of pypi and github. The whole idea of the github portgroup is mostly to fetch the sources from GitHub, but in that case there's no need to fetch anything from pypi. If you fetch from pypi, there's no need for the github portgroup. My (personal!!!) preference is to use GitHub (unless the generated files are missing), but the versions available in GitHub are different in this case. I would also like to make one thing clear: this ticket is pretty old (it went unnoticed for a long time until you asked on the mailing list). Is the version 2015.03.28 still the one you want to use? I see version 2016-something being available, but pypi says the latest one is a beta, so it's not entirely clear what's desired. -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:7> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#47941: Submission: New port: py-triangle --------------------------+-------------------------------- Reporter: smithsp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-triangle | --------------------------+-------------------------------- Comment (by smithsp@…): I dropped python3 because I have not tested it with python3. I know that the ticket is old. I'm perfectly happy with the version I am requesting in the Portfile even though it is not the most up to date version, because I have used it in the past, and then I don't have to test the newer version. I have listed myself as a maintainer, and I would be happy to try out a newer version when another user requests it. I mixed the github and python groups because it is perfectly reasonable that a python project be hosted on GitHub (the github group is used for more than just downloading sources). -- Ticket URL: <https://trac.macports.org/ticket/47941#comment:9> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
participants (1)
-
MacPorts