[MacPorts] #18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds ----------------------------------+----------------------------------------- Reporter: eborisch@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: fftw-3 fftw-3-single | Port: fftw-3 ----------------------------------+----------------------------------------- Both the fftw-3 and fftw-3-single ports have --enable-fma in their configure.args. These should be removed, as they are incorrect for Intel builds, and replaced with the appropriate platform-specific args. Suggested args:[[BR]] PPC: --enable-fma --enable-altivec[[BR]] Intel: --enable-sse OR --enable-sse2 (for fftw-3-single, and fftw-3, respectively) It might also be nice to add '-O3 -fomit-frame-pointer -fstrict-aliasing' to the configure.cflags-append -- most folks using FFTW are going for speed; might as well build for it. (These flags were found on the FFTW benchmark site: [http://www.fftw.org/speed/Pentium4-3.06GHz/] and [http://www.fftw.org/speed/G5-2GHz-macosx/]) -- Ticket URL: <http://trac.macports.org/ticket/18550> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: takeshi@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: fftw-3-single | Port: fftw-3 -------------------------------+-------------------------------------------- Changes (by macsforever2000@…): * keywords: fftw-3 fftw-3-single => fftw-3-single * owner: macports-tickets@… => takeshi@… -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: takeshi@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: fftw-3-single | Port: fftw-3 -------------------------------+-------------------------------------------- Comment(by ram@…): On Intel Leopard `fftw-3` and `fftw-3-single` build without error using these suggested flags. I've attached patches, can anyone test on PPC? -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: takeshi@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: fftw-3-single | Port: fftw-3 -------------------------------+-------------------------------------------- Comment(by ram@…): One thing I've just noticed is that the Portfiles already used the `-fno- common` cflag and the page you linked to didn't mention this cflag. Should this be used? -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: takeshi@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: fftw-3-single | Port: fftw-3 -------------------------------+-------------------------------------------- Comment(by ram@…): `fftw-3` fails to build with the universal variant with the following error: {{{ libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../kernel -I../../simd -msse2 -O2 -fno-common -O3 -fomit-frame- pointer -fstrict-aliasing -isysroot /Developer/SDKs/MacOSX10.5.sdk -arch ppc -D_THREAD_SAFE -MT sse2.lo -MD -MP -MF .deps/sse2.Tpo -c sse2.c -fno- common -DPIC -o .libs/sse2.o sse2.c:27: error: variable 'fftw_sse2_pm' has initializer but incomplete type sse2.c:28: error: extra brace group at end of initializer sse2.c:28: error: (near initialization for 'fftw_sse2_pm') sse2.c:28: warning: excess elements in union initializer sse2.c:28: warning: (near initialization for 'fftw_sse2_pm') make[3]: *** [sse2.lo] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 }}} Also on Intel Leopard. Looks like the --enable-sse2 option is being passed to configure for the PPC build. -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: | Port: fftw-3, fftw-3-single -------------------------------+-------------------------------------------- Changes (by ram@…): * cc: ram@… (removed) * keywords: fftw-3-single => * status: new => assigned * port: fftw-3 => fftw-3, fftw-3-single * owner: takeshi@… => ram@… -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: | Port: fftw-3, fftw-3-single -------------------------------+-------------------------------------------- Comment(by eborisch@…): Replying to [comment:4 ram@…]:
One thing I've just noticed is that the Portfiles already used the `-fno-common` cflag and the page you linked to didn't mention this cflag. Should this be used?
The -fno-common originated while addressing Ticket #14240 -- I'd guess leave it in for now! -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: | Port: fftw-3, fftw-3-single -------------------------------+-------------------------------------------- Comment(by eborisch@…): How about this for fftw-3: {{{ array set merger_configure_args { ppc "--enable-fma --enable-altivec" ppc64 "--enable-fma --enable-altivec" i386 --enable-sse2 x86_64 --enable-sse2 } }}} and this for fftw-3-single: {{{ array set merger_configure_args { ppc "--enable-fma --enable-altivec" ppc64 "--enable-fma --enable-altivec" i386 --enable-sse x86_64 --enable-sse } }}} (Keeping your other changes to configure.args and configure.cflags-append) -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds -------------------------------+-------------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: | Port: fftw-3, fftw-3-single -------------------------------+-------------------------------------------- Comment(by eborisch@…): The configure argument "-enable-type-prefix" in fftw-3-single should go away as well (not a valid - or needed - argument anymore.) -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds ------------------------------------+--------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: closed Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: fixed | Keywords: Port: fftw-3, fftw-3-single | ------------------------------------+--------------------------------------- Changes (by ram@…): * status: assigned => closed * resolution: => fixed Comment: Replying to [comment:9 eborisch@…]:
How about this for fftw-3:
{{{ array set merger_configure_args { ppc "--enable-fma --enable-altivec" ppc64 "--enable-fma --enable-altivec" i386 --enable-sse2 x86_64 --enable-sse2 } }}}
That does the job, although `--enable-altivec` is only appropriate for the single precision build. Replying to [comment:10 eborisch@…]:
The configure argument "-enable-type-prefix" in fftw-3-single should go away as well (not a valid - or needed - argument anymore.)
Done Changes committed in r47232, thanks! -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds ------------------------------------+--------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: reopened Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: | Keywords: Port: fftw-3, fftw-3-single | ------------------------------------+--------------------------------------- Changes (by ram@…): * status: closed => reopened * resolution: fixed => Comment: Reopening as the platform specific flags, `--enable-sse2` for example, are not applied when the port is built for a single platform, i.e. not universally. -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18550: fftw-3[-single] 3.2.1 : should not have --enable-fma for Intel builds ------------------------------------+--------------------------------------- Reporter: eborisch@… | Owner: ram@… Type: defect | Status: closed Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: fixed | Keywords: Port: fftw-3, fftw-3-single | ------------------------------------+--------------------------------------- Changes (by ram@…): * status: reopened => closed * resolution: => fixed Comment: Platform specific flags applied to non-universal builds in r47243 -- Ticket URL: <http://trac.macports.org/ticket/18550#comment:13> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts