[MacPorts] #38001: tiff should not install its config.h
#38001: tiff should not install its config.h ------------------------+-------------------------------- Reporter: jeremyhu@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Keywords: | Port: tiff evince ------------------------+-------------------------------- I noticed the following when installing evince: {{{ CC tiff2ps.lo In file included from tiff2ps.c:46: In file included from ./tiff2ps.h:21: In file included from /opt/local/include/tiffio.h:33: In file included from /opt/local/include/tiff.h:30: /opt/local/include/tiffconf.h:27:9: warning: 'SIZEOF_LONG' macro redefined #define SIZEOF_LONG 4 ^ ../../config.h:161:9: note: previous definition is here #define SIZEOF_LONG 8 ^ 1 warning generated. CCLD libtiffdocument.la GEN tiffdocument.evince-backend Found cached translation database }}} 1) tiff should probably me muniversal, so it pickes up the correct SIZEOF_LONG on each slice rather than doing its ed hackery 2) It looks like evince has the wrong SIZEOF_LONG when +universal -- Ticket URL: <https://trac.macports.org/ticket/38001> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by jmr@…): Note that muniversal was previously removed in r69700 because some of the logic was wrong when it was used (#25585). It's generally preferable to do a little (correct) ed hackery than to use muniversal anyway, because of the greatly increased complexity it brings (with weird bugs and longer build times). -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by jeremyhu@…): What exactly was the problem that it caused? -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by ryandesign@…): Replying to [ticket:38001 jeremyhu@…]:
2) It looks like evince has the wrong SIZEOF_LONG when +universal
Jeremy switched evince to use the muniversal portgroup in r102863 to fix this. -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by raimue@…): See also r102860 and https://lists.macosforge.org/pipermail/macports- dev/2013-February/021950.html -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by jeremyhu@…): Yeah, the problem is ed scripts can fail silently on an upgrade. I'll update this to a patch and revert muniversal when I get some cycles. -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by jmr@…): The reason for using ed scripts in the first place is that a patch against a config.h generated on e.g. x86_64 won't to apply to one generated on e.g. i386. -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#38001: tiff should not install its config.h --------------------------+------------------------ Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: tiff evince | --------------------------+------------------------ Comment (by jeremyhu@…): No, I will patch config.h.in like how we do it on xorg-server. -- Ticket URL: <https://trac.macports.org/ticket/38001#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts