#36558: ssss @1.0.1 -------------------------+-------------------------------- Reporter: okoeroo@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: ssss | -------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) * keywords: security shamir secret sharing => * port: => ssss -- Ticket URL: <https://trac.macports.org/ticket/36558#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36558: ssss @1.0.1 -------------------------+-------------------------------- Reporter: okoeroo@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: ssss | -------------------------+-------------------------------- Comment (by okoeroo@…): Replying to [comment:1 ryandesign@…]:

Thanks. I've attached a revised portfile, which uses the github portgroup and downloads from a distfile instead of downloading from git.

I also switched the `system` invocation to use the `-W` flag.

The port does not build for me. I'm attaching the main.log.

I don't understand why the port requests that MacPorts run autoreconf ("`use_autoreconf yes`") but then afterward manually runs the bootstrap script which itself runs `aclocal`, `glibtoolize`, `autoheader`, `automake` and `autoconf`. Shouldn't one or the other be sufficient?

Hi, I've been able to replicate the problem on a clean MacPorts machine. The project/ directory was required for my current autotools setup and was created by automake or autoconf at the end, but glibtoolize couldn't work. Running the install for a second time fixed it, but that's totally not good. What I've changed in the Portfile.3 file is: - Updated checksums - Removed the autoreconf command - Added a mkdir project/ before I run the autotools bootstrap These changes solve my build problems on my reference machine. It should work for you too :-) -- Ticket URL: <https://trac.macports.org/ticket/36558#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36558: ssss @1.0.1 -------------------------+-------------------------- Reporter: okoeroo@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: ssss | -------------------------+-------------------------- Comment (by ryandesign@…): Thanks. Committed in r98694 with some changes. Since the bootstrap script is still running programs provided by the autoconf, automake and libtool ports, I added those dependencies to depends_build. ("use_autoreconf yes" had added them for you automatically, so when you removed that line it became your responsibility to add those dependencies yourself.) I also used the Tcl "file mkdir" command to make the project directory; no need to launch a separate program to do that. With regard to the updated checksums, I see this is because you incorporated a fix to an issue I filed and re-tagged 1.0.1. Please avoid re-tagging your releases in the future. We call this a [wiki:PortfileRecipes#stealth-updates stealth update] and we discourage it. Imagine what would have happened if we had accepted your 1.0.1 portfile as originally submitted (imagine we had figured out we needed to create the "project" directory and had included that directive in the portfile). Then two days later you re-tagged 1.0.1, thus changing the checksums. Now some users trying to install the port (those for whom the github server is closer than any MacPorts mirror server) will encounter a [wiki:FAQ#checksums checksum mismatch error], which will inconvenience the user and will occupy our time when we have to deal with the bug report the user will undoubtedly file. Therefore once you've created a tag or release please consider it to be immutable. If you need to make further changes and publish them to your users, do so under a new version number. -- Ticket URL: <https://trac.macports.org/ticket/36558#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36558: ssss @1.0.1 -------------------------+-------------------------- Reporter: okoeroo@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: Port: ssss | -------------------------+-------------------------- Comment (by okoeroo@…): Replying to [comment:7 ryandesign@…]:

Thanks. Committed in r98694 with some changes. Since the bootstrap script is still running programs provided by the autoconf, automake and libtool ports, I added those dependencies to depends_build. ("use_autoreconf yes" had added them for you automatically, so when you removed that line it became your responsibility to add those dependencies yourself.) I also used the Tcl "file mkdir" command to make the project directory; no need to launch a separate program to do that.

With regard to the updated checksums, I see this is because you incorporated a fix to an issue I filed and re-tagged 1.0.1. Please avoid re-tagging your releases in the future. We call this a [wiki:PortfileRecipes#stealth-updates stealth update] and we discourage it. Imagine what would have happened if we had accepted your 1.0.1 portfile as originally submitted (imagine we had figured out we needed to create the "project" directory and had included that directive in the portfile). Then two days later you re-tagged 1.0.1, thus changing the checksums. Now some users trying to install the port (those for whom the github server is closer than any MacPorts mirror server) will encounter a [wiki:FAQ#checksums checksum mismatch error], which will inconvenience the user and will occupy our time when we have to deal with the bug report the user will undoubtedly file. Therefore once you've created a tag or release please consider it to be immutable. If you need to make further changes and publish them to your users, do so under a new version number.

Thanks for the fixes. I'm aware of my retagging action to be dangerous. As MacPorts is going to be the first one to really be hit by this I've took the liberty just this once to retag it fully understanding the potential impact of messing up the Port for others if I would do this again. -- Ticket URL: <https://trac.macports.org/ticket/36558#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS