#38799: Add bash_completion variant to mosh (patch included) --------------------------+----------------------- Reporter: macports@… | Owner: quentin@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: | --------------------------+----------------------- Changes (by cal@…): * owner: macports-tickets@… => quentin@… * cc: quentin@… (removed) * cc: cal@… (added) Comment: Looks good to me. I'd probably even install it without a variant, i.e. always and by default. Let me know what you think. -- Ticket URL: <https://trac.macports.org/ticket/38799#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#38799: Add bash_completion variant to mosh (patch included) --------------------------+----------------------- Reporter: macports@… | Owner: quentin@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: | --------------------------+----------------------- Comment (by larryv@…): Replying to [comment:2 egall@…]:

How about somewhere halfway between the two: making the variant a default variant?

I don’t see the point of this. It’s one file. Just install it all the time, sans the dependency on `bash-completion`. -- Ticket URL: <https://trac.macports.org/ticket/38799#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#38799: Add bash_completion variant to mosh (patch included) --------------------------+----------------------- Reporter: macports@… | Owner: quentin@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: | --------------------------+----------------------- Comment (by macports@…): Replying to [comment:4 quentin@…]:

LGTM. I don't care if it's protected by a variant or not, but it does seem like the standard is to offer it as a variant? I guess so - see https://trac.macports.org/wiki/howto/bash-completion.

-- Ticket URL: <https://trac.macports.org/ticket/38799#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#38799: Add bash_completion variant to mosh (patch included) --------------------------+----------------------- Reporter: macports@… | Owner: quentin@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: mosh | --------------------------+----------------------- Changes (by cal@…): * status: new => closed * resolution: => fixed Comment: `port echo variant:bash_completion | wc -l` shows only 12 ports that actually have a `+bash_completion` variant. It seems uncommon and I'll post to the -dev list suggesting to remove the remaining variants. Meanwhile, I have commited this patch in r105276. -- Ticket URL: <https://trac.macports.org/ticket/38799#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X