[MacPorts] #48667: notmuch: Add support for installing man pages
#48667: notmuch: Add support for installing man pages -----------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: notmuch -----------------------+-------------------------------- Hello, The attached patch adds the correct support for building the Notmuch man pages. A simple patch file is addes to files/ in order to resolve problems where the python executable is not found by the Notmuch configure script. Best, Charles -- Ticket URL: <https://trac.macports.org/ticket/48667> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | ------------------------+-------------------------------- Comment (by ryandesign@…): There is a stray backslash at the end of your `depends_lib`. Are you saying that prior to this patch, manpages might not be installed, but after this patch, they will be? If so, the port's revision needs to be increased so that anyone who doesn't already have the manpages will get them. -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | ------------------------+-------------------------------- Comment (by cceleri@…): Yes, the man pages will not be installed if the following test fails in the configure script {{{ if command -v sphinx-build > /dev/null && ${python} -m sphinx.writers.manpage > /dev/null 2>&1 ; then ... }}} where ${python} is set earlier by {{{ for name in python python2 python3; do if command -v $name > /dev/null; then have_python=1 python=$name ... }}} We can get the test to pass if one of the py*-sphinx ports is installed and there is a symbolic link from python{,2,3} to an installed python* port. I would prefer to establish a python{,2,3} symbolic link during the build process using something like select, but I was unable to figure out how to make that work. Instead, I resorted to patching the configure script so that ${python} resolves to something that will work. I admit that the above workaround is quite messy. Is there a cleaner way to handle this? I was having a lot of trouble figuring how to tell the configure script which python I wanted it to use. -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | ------------------------+-------------------------------- Comment (by cceleri@…): I changed for loop in the configure script: {{{ -for name in python python2 python3; do +for name in ${PREFIX}/bin/python2.7; do }}} I feel like that should be rock solid as long as py27-sphinx is a dependency of the notmuch port. An update .diff is now attached. -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | ------------------------+-------------------------------- Comment (by cceleri@…): The part of this patch that removed obsolete patches should have been in the patch for #48666. This should be resolved by the patch I will upload shortly. -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+--------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch maintainer Port: notmuch | ------------------------+--------------------------------- Changes (by petr@…): * keywords: haspatch => haspatch maintainer -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+--------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch maintainer Port: notmuch | ------------------------+--------------------------------- Comment (by mojca@…): If you need `sphinx-build`, you should probably temporary add `/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin` (`${frameworks_dir}/Python.framework/Versions/2.7/bin`) to `PATH`. (At least that's what I did in one of my ports.) -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48667: notmuch: Add support for installing man pages ------------------------+--------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch maintainer Port: notmuch | ------------------------+--------------------------------- Comment (by mojca@…): Also: aren't `py27-sphinx` and `doxygen` just build dependencies? -- Ticket URL: <https://trac.macports.org/ticket/48667#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts