[MacPorts] #35882: cmake @ 2.8.9 - Updated Portfile
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: cmake --------------------------------------+------------------------------------- This updated Portfile installs cmake 2.8.9. -- Ticket URL: <https://trac.macports.org/ticket/35882> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: cmake --------------------------------------+------------------------------------- Comment(by samuel@…): The main concern I have is whether the previous patches for 2.8.8 are still necessary. I replaced my existing Portfile for 2.8.8 and everything is working fine. But perhaps some of the patches can be removed? -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: haspatch | Port: cmake --------------------------------------+------------------------------------- Changes (by ryandesign@…): * keywords: => haspatch * owner: macports-tickets@… => css@… Comment: Please attach a unified diff of your changes instead of a complete new Portfile; this will make it easier to review your changes. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: haspatch | Port: cmake --------------------------------------+------------------------------------- Comment(by samuel@…): How do I do that? -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: haspatch | Port: cmake --------------------------------------+------------------------------------- Comment(by ryandesign@…): http://guide.macports.org/#development.patches.portfile -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: haspatch | Port: cmake --------------------------------------+------------------------------------- Comment(by samuel@…): Hi, I'll do that in the future but right now I don't have the original Portfile since I just updated it in-place. Therefore, if someone else can do that diff that would be great. The only change was the version and the checksums. Kind regards, Samuel -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile --------------------------------------+------------------------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: haspatch | Port: cmake --------------------------------------+------------------------------------- Changes (by css@…): * status: new => assigned Comment: I'm traveling and don't have access to my Mac, but I can check on this and some Other port tickets this weekend. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile ---------------------------------------+------------------------------------ Reporter: samuel@… | Owner: css@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: haspatch Port: cmake | ---------------------------------------+------------------------------------ Changes (by css@…): * status: assigned => closed * resolution: => fixed Comment: Fixed in r97601! -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: cmake | -----------------------+---------------------- Changes (by and.damore@…): * cc: and.damore@…, help@… (added) * status: closed => reopened * resolution: fixed => Comment: Reopening update ticket, it seems that patchfile ''patch- Modules_FindPkgConfig_cmake.diff'' should have been removed, see following quote: Replying to [comment:3:ticket:34505 help@…]:
cmake version was bumped in Portfile, but this patch wasn't dropped. In result pkg-config support in cmake broke. Please revert this change. Tested using local overlay, removing patch- Modules_FindPkgConfig_cmake.diff from patchfiles works.
That said can you show an example of the issue that is affecting cmake at the moment so we can reproduce it? By ''this patch'' you mean ''patch-Modules_FindPkgConfig_cmake.diff'', right? -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: cmake | -----------------------+---------------------- Comment (by css@…): So the issue noted in #34505 was fixed in CMake 2.8.9, so the included patch to !FindPkgConfig is no longer needed and should be removed. I'll bump the revision for the fix. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: cmake | -----------------------+---------------------- Comment (by css@…): Fixed in r97867 -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: cmake | -----------------------+---------------------- Comment (by and.damore@…): Replying to [comment:9 css@…]:
So the issue noted in #34505 was fixed in CMake 2.8.9, so the included patch to !FindPkgConfig is no longer needed and should be removed.
I'd wait to see what the error actually is. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: cmake | -----------------------+---------------------- Comment (by help@…): exactly as in #34505 description - PKG_CONFIG_FOUND variable doesn't get set. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35882: cmake @ 2.8.9 - Updated Portfile -----------------------+---------------------- Reporter: samuel@… | Owner: css@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: haspatch Port: cmake | -----------------------+---------------------- Changes (by and.damore@…): * status: reopened => closed * resolution: => fixed Comment: I confirm that avidemux's configure phase works correctly using after r97867 cmake port and fails using cmake before that revision. Ticket closed. -- Ticket URL: <https://trac.macports.org/ticket/35882#comment:13> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts