[MacPorts] #31562: CGAL version bump 3.8 -> 3.9
#31562: CGAL version bump 3.8 -> 3.9 --------------------------------+------------------------------------------- Reporter: mmoll@… | Owner: vince Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: cgal --------------------------------+------------------------------------------- I didn't check the demos variant. You might want to include the additional patch file, which makes sure that the cmake-related code is installed in a location that should be in cmake's module path. -- Ticket URL: <https://trac.macports.org/ticket/31562> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 --------------------------------+------------------------------------------- Reporter: mmoll@… | Owner: vince Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: cgal --------------------------------+------------------------------------------- Comment(by mmoll@…): Actually, ignore that second patch. You can just do this in the Portfile: {{{ configure.args-append -DCGAL_INSTALL_CMAKE_DIR="${prefix}/lib/cmake" }}} -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 --------------------------------+------------------------------------------- Reporter: mmoll@… | Owner: vince@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: cgal --------------------------------+------------------------------------------- Changes (by blb@…): * owner: vince => vince@… Comment: Assignees need to be complete email addresses. -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 --------------------------------+------------------------------------------- Reporter: mmoll@… | Owner: vince@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: cgal --------------------------------+------------------------------------------- Comment(by raphael@…): I would propose the attached patch as the demos variant does not compile with llvm-gcc-4.2 and clang. The patch also fixes #29382. I also attached an updated patchfile for the {{{CMakeLists.txt}}} files for the demos. But I still have one problem with CGAL 3.9. When compiling CGAL 3.9 the old CGAL 3.8 headers are picked up if CGAL 3.8 is still active. Here is the corresponding part of the build log: {{{ :info:build [ 33%] Building CXX object src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o :info:build cd /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core && /usr/bin/g++-4.2 -DCGAL_Core_EXPORTS -pipe -O2 -arch ppc -frounding- math -fno-strict-aliasing -O3 -DNDEBUG -arch ppc -isysroot / -mmacosx- version-min=10.5 -fPIC -I/opt/local/include -I/opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/include -I/opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core -o CMakeFiles/CGAL_Core.dir/all_files.cpp.o -c /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp :info:build In file included from /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp:1: :info:build /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp: In member function ‘void CORE::Expr::doubleInterval(double&, double&) const’: :info:build /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp:78: error: ‘CGAL_CORE_finite’ was not declared in this scope }}} So, I had to deactivate the old CGAL version before installing the new one. -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 --------------------------------+------------------------------------------- Reporter: mmoll@… | Owner: vince@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: cgal --------------------------------+------------------------------------------- Changes (by raphael@…): * keywords: => haspatch * version: 2.0.3 => -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Changes (by ryandesign@…): * cc: ryandesign@… (added) * status: new => closed * resolution: => fixed Comment: r87107 -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Changes (by florian@…): * status: closed => reopened * resolution: fixed => Comment: Replying to [comment:6 ryandesign@…]:
r87107
Are you sure this is fixed yet? I still have this issue, when I don't deactivate cgal@3.8_0 prior to upgrading: {{{ [ 10%] Building CXX object src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core && /usr/bin/g++-4.2 -DCGAL_Core_EXPORTS -pipe -O2 -arch x86_64 -frounding-math -fno-strict-aliasing -O3 -DNDEBUG -arch x86_64 -isysroot / -mmacosx-version-min=10.6 -fPIC -I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core -o CMakeFiles/CGAL_Core.dir/all_files.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp:5: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp: In member function ‘void CORE::Expr::doubleInterval(double&, double&) const’: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp:78: error: ‘CGAL_CORE_finite’ was not declared in this scope make[2]: *** [src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o] Error 1 make[1]: *** [src/Core/CMakeFiles/CGAL_Core.dir/all] Error 2 make: *** [all] Error 2 }}} -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Comment(by ryandesign@…): You're right, I didn't address that part of the request. Deactivate cgal 3.8 before trying to build 3.9. I'll add a check to the portfile to make sure users do that. -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Changes (by ryandesign@…): * cc: florian@… (added) -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Comment(by cobxo3bot@…): I had a problem with installing the upgrade. It was solved by deactivating the older version however. -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#31562: CGAL version bump 3.8 -> 3.9 ---------------------------------+------------------------------------------ Reporter: mmoll@… | Owner: vince@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: cgal | ---------------------------------+------------------------------------------ Changes (by ryandesign@…): * status: reopened => closed * resolution: => fixed Comment: r87615. -- Ticket URL: <https://trac.macports.org/ticket/31562#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts