[MacPorts] #30781: Small change to qt4-mac and qt4-mac-devel Portfiles
#30781: Small change to qt4-mac and qt4-mac-devel Portfiles --------------------------------+------------------------------------------- Reporter: carsomyr@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.99 Keywords: haspatch | Port: qt4-mac, qt4-mac-devel --------------------------------+------------------------------------------- When browsing the Portfiles for qt4-mac and qt4-mac-devel, I found that the minor Mac OS X version detection could be improved so that it behaves as the author intended. Please find attached the Portfile patch. -- Ticket URL: <https://trac.macports.org/ticket/30781> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30781: Small change to qt4-mac and qt4-mac-devel Portfiles --------------------------------+------------------------------------------- Reporter: carsomyr@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.99 Keywords: haspatch | Port: qt4-mac, qt4-mac-devel --------------------------------+------------------------------------------- Changes (by ryandesign@…): * cc: michaelld@… (removed) * owner: macports-tickets@… => michaelld@… -- Ticket URL: <https://trac.macports.org/ticket/30781#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30781: Small change to qt4-mac and qt4-mac-devel Portfiles --------------------------------+------------------------------------------- Reporter: carsomyr@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.99 Keywords: haspatch | Port: qt4-mac, qt4-mac-devel --------------------------------+------------------------------------------- Comment(by jmr@…): That whole thing is actually unnecessary. If you're not on Darwin, it's going to produce a nonsense MDT from os.version, and if you are on Darwin, macosx_deployment_target is always set. -- Ticket URL: <https://trac.macports.org/ticket/30781#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30781: Small change to qt4-mac and qt4-mac-devel Portfiles --------------------------------+------------------------------------------- Reporter: carsomyr@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.99 Keywords: haspatch | Port: qt4-mac, qt4-mac-devel --------------------------------+------------------------------------------- Comment(by michaelld@…): Replying to [comment:2 jmr@…]:
That whole thing is actually unnecessary. If you're not on Darwin, it's going to produce a nonsense MDT from os.version, and if you are on Darwin, macosx_deployment_target is always set.
So, since qt4-mac is intended for building Darwin only: os.version should not be used, and instead I should just use macosx_deployment_target? I can easily make that change & the correction from this ticket as well. -- Ticket URL: <https://trac.macports.org/ticket/30781#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30781: Small change to qt4-mac and qt4-mac-devel Portfiles -------------------------------------+-------------------------------------- Reporter: carsomyr@… | Owner: michaelld@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.0.99 Resolution: fixed | Keywords: haspatch Port: qt4-mac, qt4-mac-devel | -------------------------------------+-------------------------------------- Changes (by michaelld@…): * status: new => closed * resolution: => fixed Comment: Fixed in r83437 and r83438. -- Ticket URL: <https://trac.macports.org/ticket/30781#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts