[MacPorts] #48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration ------------------------------+---------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: High | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: auto-multiple-choice ------------------------------+---------------------------------- A patch to ease migration of auto-multiple-choice to Perl 5.22. (For now the migration doesn't work see ticket #47015). -- Ticket URL: <https://trac.macports.org/ticket/48390> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+-------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+-------------------------------- Changes (by mf2k@…): * priority: High => Normal -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+-------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+-------------------------------- Comment (by Joel.Brogniart@…): Added a patch file to make the application library saved in the perl 5.2 hierarchy, and to adapt the portfile to perl 5.22. The application could only work when perl 5.22 is the default Macports version. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Changes (by mf2k@…): * keywords: => haspatch maintainer * version: 2.3.3 => Comment: Thanks! -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by Joel.Brogniart@…): Changed patches to ask Perl for vendorlib path instead of trying to construct it. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Changes (by ionic@…): * owner: macports-tickets@… => ionic@… * status: new => assigned Comment: Wouldn't it be a lot easier to just use the `perl5` PortGroup, set `perl5.branches` and reset `perl5.link_binaries_suffix` like the `ack` port does? You could then simply use `${perl5.lib}` for the VENDORLIB thingy. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by ionic@…): ... as discussed in #47015? -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by Joel.Brogniart@…): Here are the modification to switch to PERL 5.22. There are two patches. - auto-multiple-choice-1.2.1-r4.1.diff to adapt the Portfile for easier perl version change. - auto-multiple-choice-1.2.1-r4.2.diff to switch to perl 5.22. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by Joel.Brogniart@…): I forgot to mention that these modifications work even with P5.16 as default perl. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by ionic@…): The problem is... that I don't like that. Not because it's wrong as such, but because it's duplicating code already existing in the `perl5` PortGroup. Can't we just use that? I will look into the PortGroup more intensively to find out if pure applications would be affected. I know the `python` PortGroup handles things differently for modules vs. applications - `perl5` shouldn't be any exception. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by Joel.Brogniart@…): Here is a new version using PortGroup. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by ionic@…): Looks way better! One comment: when committing, I'll drop the `perl5.major` guard. If using the PortGroup, this variable will always be set. Just ACK or NAK this in a comment here, you don't need to update the patches. I'll do that on the fly. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Comment (by Joel.Brogniart@…): OK for dropping the guard. -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#48390: auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration -----------------------------------+--------------------------------- Reporter: Joel.Brogniart@… | Owner: ionic@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: auto-multiple-choice | -----------------------------------+--------------------------------- Changes (by ionic@…): * status: assigned => closed * resolution: => fixed Comment: Patch 1 applied as r140543 with the announced changes. Also, I've added a revbump just to be safe because the commit also changes the way the port is being built. r140544 contains a whitespace-only change I have only noticed in my editor. There was a line containing spaces only. Patch 2 with slight modification to the revision change (4 instead of 3 due to the previous revbump) applied as r140545. Thanks for your work and patience! -- Ticket URL: <https://trac.macports.org/ticket/48390#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts