[MacPorts] #46947: sox: please update to @14.4.2
#46947: sox: please update to @14.4.2 ------------------------+-------------------------------- Reporter: mopihopi@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: sox ------------------------+-------------------------------- Please update sox to @14.4.2. Note that sox 14.4.2 can now read Ogg Opus files, using the opusfile library, so the dependencies will probably need to be updated. -- Ticket URL: <https://trac.macports.org/ticket/46947> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------------------- Reporter: mopihopi@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------------------- Comment (by hans@…): I am working on this. The problem is opusfile does not compile on my 10.5.8, as it doesn't have AI_NUMERICSERV defined. One option is to create an updated port of SoX 14.4.2 decidedly --without- opus now, and improive it to actually use opus later. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Changes (by mf2k@…): * owner: macports-tickets@… => hans@… * cc: hans@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): Now that I can install opusfile, here is an upgrade to SoX 14.4.2 - update licence to GPL3, because opencore-amr is Apache - trim needless verbiage from the long description - ./configure --with-opus, add libopus and opusfile as dependencies - reorder dependencies alphabetically while there - drop --without-ffmpeg as it has been kicked out Tested on 10.5.8 on an old MacBook, can other users please test elsewhere? Jan -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): Portfile replaced with a slightly neater one: - split the confgure.args to audio formats and output drivers - reorder the ./cofigure args to follow ./configure --help - add --with-distro=macosx to make SoX's messages slightly happier - gomp has been renamed to openmp -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mopihopi@…): Thanks! I tried the Portfile on OS X 10.9.5 and it seems to be working. For some reason `sox --version` is just showing `sox: SoX v` with no version number, but apparently that is an existing issue as the previous version seems to do the same thing. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mopihopi@…): BTW installing the new `sox` required the `mlt` port to be rebuilt, so `mlt` may need a revbump: {{{ ---> Activating sox @14.4.2_0 ---> Cleaning sox ---> Updating database of binaries ---> Scanning binaries for linking errors ---> Found 1 broken file(s), matching files to ports ---> Found 1 broken port(s), determining rebuild order ---> Rebuilding in order mlt @0.9.2 }}} -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): On my system the version is reported fine: {{{ $ sox --version sox: SoX v14.4.2 }}} If you run just 'sox' and save the whole output, does it say 'sox: SoX v14.4.2' at the top? -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): Replying to [comment:6 mopihopi@…]:
BTW installing the new `sox` required the `mlt` port to be rebuilt, so `mlt` may need a revbump:
Right, I forgot about the dependents; sorry. These are gimp-gap-devel, mlt, sounddecompress, tovid. I don't personally use any of those. I can give them all a spin, but could serious users please check that this upgrade of SoX does not break them? Thanks -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mopihopi@…): Just `sox` by itself has the same issue with the missing version number: {{{ $ sox sox: SoX v sox FAIL sox: Not enough input filenames specified Usage summary: [gopts] [[fopts] infile]... [fopts] outfile [effect [effopt]]... SPECIAL FILENAMES (infile, outfile): ... }}} I'm using OS X 10.9.5 with Xcode 6.1.1 and the default compiler: Apple LLVM version 6.0 (clang-600.0.56) -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mopihopi@…): The missing version number also occurs with the upstream version. Filed upstream: http://sourceforge.net/p/sox/patches/104/ -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mf2k@…): [https://guide.macports.org/#development.patches Per the guidelines], please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): Sorry; attaching a diff to the curent Portfile. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by mf2k@…): You have whitespace changes in this patch which makes it hard to evaluate the changes you are proposing. We prefer a separate patch for that. Doing this will greatly increase your odds of getting the patch committed. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: sox | -------------------------+-------------------- Comment (by hans@…): Replying to [comment:13 mf2k@…]:
You have whitespace changes in this patch which makes it hard to evaluate the changes you are proposing. We prefer a separate patch for that. Doing this will greatly increase your odds of getting the patch committed.
A cleaner diff attached. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:14> MacPorts <https://www.macports.org/> Ports system for OS X
#46947: sox: please update to @14.4.2 -------------------------+-------------------- Reporter: mopihopi@… | Owner: hans@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: sox | -------------------------+-------------------- Changes (by g5pw@…): * status: new => closed * resolution: => fixed Comment: Commited in r142250 (only whitespace changes) and r142255. In future, please submit whitespace only (like indentation, alignment, etc.) separately from functional changes. -- Ticket URL: <https://trac.macports.org/ticket/46947#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts