Re: [MacPorts] #33259: cmake portgroup: out of source build option, possibly by default
#33259: cmake portgroup: out of source build option, possibly by default ---------------------------+-------------------------------- Reporter: ryandesign@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: | ---------------------------+-------------------------------- Comment (by mojca@…): Replying to [comment:21 cal@…]:
I'd rather shorten the option name to `cmake.out_of_source`
OK.
and use `yes` and `no` over `true` and `false` like we usually do. Your code only allows `true`, which is bad, because maintainers will try to set it to `yes` or `1`.
That was just bad coding that should be fixed of course.
Also, I'd rather modify the defaults than change the actual values when `cmake.out_of_source yes` is encountered in a Portfile. That would make {{{ configure.dir ${worksrcpath}/foo cmake.out_of_source yes }}} work correctly.
Ah, thank you. That answers my previous question about the role of `default`. I'm a bit sceptic about the following: {{{ default configure.post_args {../${worksrcdir}} }}} Setting something like {{{ configure.dir ${workpath}/build/i386 }}} would probably no longer resolve "`../${worksrcdir}`" properly. I believe that using `${worksrcpath}` is safer from that respect. -- Ticket URL: <https://trac.macports.org/ticket/33259#comment:23> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts