[MacPorts] #34933: base: loop through sources before returning the default path in macports::getportresourcepath
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.1 Keywords: portgroup | Port: -------------------------------------------+-------------------------------- Without this patch, creating custom PortGroups (and putting them in your own local repo) will cause warnings and errors sometimes because base doesn't know where the groups are located. This patch fixes returning the default path too soon. I am no tcl expert, so if someone knows of a better way to do this, please speak up. -- Ticket URL: <https://trac.macports.org/ticket/34933> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Changes (by ryandesign@…): * keywords: portgroup => portgroup haspatch * milestone: => MacPorts Future -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Comment(by sean.michael.farley@…): FYI, I updated the patch to fix a missing global declaration -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Comment(by jmr@…): What problem does this actually solve? AFAICT, portfiles in a local repo will already use the portgroups in the same repo. -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Comment(by sean.michael.farley@…): Replying to [comment:3 jmr@…]:
What problem does this actually solve? AFAICT, portfiles in a local repo will already use the portgroups in the same repo.
Ah, sorry about not being clear. The problem arises upon deactivation and uninstall, if I recall correctly. I believe it's because of the different logic used for deactivation / uninstall due to caching the Portfile and not having the correct path for the local repo. -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Comment(by jmr@…): I don't know that potentially running the wrong deactivate/uninstall code (if the wrong portgroup file happens to be found first) is any better than just not being able to run any. This really needs a more general solution for keeping the portgroups used by installed ports, in case of either incompatibility or removal. -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath -------------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 2.1.1 Keywords: portgroup haspatch | Port: -------------------------------------------+-------------------------------- Comment(by sean.michael.farley@…): Replying to [comment:5 jmr@…]:
I don't know that potentially running the wrong deactivate/uninstall code (if the wrong portgroup file happens to be found first) is any better than just not being able to run any.
Well, I would argue that not throwing errors to the user is better, especially if this is a design flaw / "feature."
This really needs a more general solution for keeping the portgroups used by installed ports, in case of either incompatibility or removal.
I agree but lack of tcl-fu and also lack of macports internals scared me away. -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34933: base: loop through sources before returning the default path in macports::getportresourcepath ------------------------------------+-------------------------------- Reporter: sean.michael.farley@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: base | Version: 2.1.1 Resolution: wontfix | Keywords: portgroup haspatch Port: | ------------------------------------+-------------------------------- Changes (by jmr@…): * status: new => closed * resolution: => wontfix * milestone: MacPorts Future => Comment: A better fix for this problem will be landing on trunk shortly. -- Ticket URL: <https://trac.macports.org/ticket/34933#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts