[MacPorts] #52049: lnav opportunistically links with MacPorts curl
#52049: lnav opportunistically links with MacPorts curl --------------------------+-------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: lnav --------------------------+-------------------- I think some dependency(ies) are missing. If MacPorts curl is installed with the +http2 variant, then lnav ends up linked with libnghttp2.dylib, though it doesn't declare a dependency on curl or nghttp2: {{{ $ otool -L /opt/local/bin/lnav /opt/local/bin/lnav: /opt/local/lib/libnghttp2.14.dylib (compatibility version 24.0.0, current version 24.0.0) /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.1.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1) }}} If MacPorts curl is installed without the +http2 variant, lnav doesn't link with libnghttp2.dylib or libcurl.dylib: {{{ /opt/local/bin/lnav: /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.1.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1) }}} (I don't understand why it doesn't link with MacPorts curl here.) If MacPorts curl is not installed, lnav uses the macOS version of curl: {{{ /opt/local/bin/lnav: /usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 8.0.0) /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.1.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1) }}} But it fails to build on older versions of macOS where the version of curl is too old. -- Ticket URL: <https://trac.macports.org/ticket/52049> MacPorts <https://www.macports.org/> Ports system for OS X
#52049: lnav opportunistically links with MacPorts curl ---------------------------+-------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: lnav | ---------------------------+-------------------- Comment (by g5pw@…): Wow, good catch. I think we should enforce MacPorts' curl and add a http2 variant to lnav dependant on nghttp2. -- Ticket URL: <https://trac.macports.org/ticket/52049#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#52049: lnav opportunistically links with MacPorts curl ---------------------------+-------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: lnav | ---------------------------+-------------------- Comment (by ryandesign@…): Just having nghttp2 installed didn't seem to cause lnav to link with it, only when curl was configured with it. But I don't understand why lnav would then directly link with libnghttp2.dylib but not libcurl.dylib. I didn't look into it too closely though. -- Ticket URL: <https://trac.macports.org/ticket/52049#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#52049: lnav opportunistically links with MacPorts curl ---------------------------+---------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: lnav | ---------------------------+---------------------- Changes (by ryandesign@…): * keywords: => haspatch Comment: For some reason this build system thinks it should link to the static libraries by default. There's a configure switch to make it link to the dynamic libraries, which is what we want. -- Ticket URL: <https://trac.macports.org/ticket/52049#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#52049: lnav opportunistically links with MacPorts curl ---------------------------+---------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: lnav | ---------------------------+---------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: r151708 -- Ticket URL: <https://trac.macports.org/ticket/52049#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#52049: lnav opportunistically links with MacPorts curl ---------------------------+---------------------- Reporter: ryandesign@… | Owner: g5pw@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: lnav | ---------------------------+---------------------- Comment (by g5pw@…): Thanks for the fix, Ryan! -- Ticket URL: <https://trac.macports.org/ticket/52049#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts