#17982: libiconv: universal LP64 fixes ------------------------------+--------------------------------------------- Reporter: jmr@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: | Port: libiconv ------------------------------+--------------------------------------------- Comment(by mcalhoun@…): Using #17972, there are a few more changes in the 32/64 build processes.[[BR]] I do not know if they matter. -- Ticket URL: <http://trac.macports.org/ticket/17982#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#17982: libiconv: universal LP64 fixes -------------------------------+-------------------------------------------- Reporter: jmr@… | Owner: ryandesign@… Type: defect | Status: closed Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: fixed | Keywords: Port: libiconv | -------------------------------+-------------------------------------------- Comment(by jmr@…): Unfortunately configuring libiconv now fails when the universal variant is not set, and also when building universal but not 64-bit. That long if statement in my patch was there for a reason. -- Ticket URL: <http://trac.macports.org/ticket/17982#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS

#17982: libiconv: universal LP64 fixes -------------------------------+-------------------------------------------- Reporter: jmr@… | Owner: ryandesign@… Type: defect | Status: reopened Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: | Keywords: Port: libiconv | -------------------------------+-------------------------------------------- Comment(by ryandesign@…): Ok, I see the problem is that the patch does not apply unless you build with 64 bits. I wanted to do the fix all the time, not just in the universal variant, based on [comment:ticket:16007:6 Joshua's comment in #16007] that some systems may want to build 64-bit all the time. I guess I should convert the patch into an ed script, as per [comment:ticket:17042:2 Joshua's comment in #17042]. -- Ticket URL: <http://trac.macports.org/ticket/17982#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS

#17982: libiconv: universal LP64 fixes -------------------------------+-------------------------------------------- Reporter: jmr@… | Owner: ryandesign@… Type: defect | Status: reopened Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: | Keywords: Port: libiconv | -------------------------------+-------------------------------------------- Comment(by jmr@…): Daniel didn't like the idea of adding a dependency on ed in #17090. Maybe it's not a big deal. -- Ticket URL: <http://trac.macports.org/ticket/17982#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS

#17982: libiconv: universal LP64 fixes -------------------------------+-------------------------------------------- Reporter: jmr@… | Owner: ryandesign@… Type: defect | Status: reopened Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Resolution: | Keywords: Port: libiconv | -------------------------------+-------------------------------------------- Comment(by ryandesign@…): Replying to [comment:8 jmr@…]:

Daniel didn't like the idea of adding a dependency on ed in #17090. Maybe it's not a big deal.

I think using ed is fine because ed is in /bin/ed while patch is in /usr/bin/patch, suggesting that ed is a lower-level utility than patch, which we already require, so ed should be on at least as many systems as have patch. -- Ticket URL: <http://trac.macports.org/ticket/17982#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS