[MacPorts] #21806: Wireshark no_x11 installs without GUI
#21806: Wireshark no_x11 installs without GUI --------------------------------------+------------------------------------- Reporter: lkraider+ports@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Keywords: | Port: --------------------------------------+------------------------------------- I have gtk2 installed as +no_x11 +quartz -x11 After trying to install wireshark, it builds without gui, because no_x11 disables gtk2 in its Portfile. Trying to set -no_x11 doesn't work since gtk2 is already built with it enabled, and port returns an error for that. Since the build works fine with gtk2 +no_x11, I propose the '''no_x11''' be renamed to '''no_gui''' on the wireshark Portfile. -- Ticket URL: <http://trac.macports.org/ticket/21806> MacPorts <http://www.macports.org/> Ports system for Mac OS
#21806: Wireshark no_x11 installs without GUI --------------------------------------+------------------------------------- Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Keywords: | Port: wireshark --------------------------------------+------------------------------------- Changes (by macsforever2000@…): * owner: macports-tickets@… => opendarwin.org@… * port: => wireshark -- Ticket URL: <http://trac.macports.org/ticket/21806#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#21806: Wireshark no_x11 installs without GUI --------------------------------------+------------------------------------- Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Keywords: | Port: wireshark --------------------------------------+------------------------------------- Comment(by boris.dusek@…): I agree too. I have gtk2 with +no_x11 and wireshark installed without no_x11, and it works fine. -- Ticket URL: <https://trac.macports.org/ticket/21806#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#21806: Wireshark no_x11 installs without GUI --------------------------------------+------------------------------------- Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Keywords: | Port: wireshark --------------------------------------+------------------------------------- Comment(by pavel@…): Cc Me! -- Ticket URL: <https://trac.macports.org/ticket/21806#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#21806: Wireshark no_x11 installs without GUI -------------------------------+------------------------------ Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Resolution: | Keywords: Port: wireshark | -------------------------------+------------------------------ Comment (by pokui@…): Replying to [comment:9 pokui@…]:
I agree with the previous comments. +no_x11 does not necessarily imply +no_quartz. no_gui or no_gtk would better portray the meaning implied here.
After thinking about this a bit +no_gtk2 etc may violate POLA. Another solution is to add a +quartz that requires +no_x11. If someone has both +no_x11 and +quartz enabled then gtk2 should not be disabled, If someone has only +no_x11 then the current interpretation could be kept. Either way I just had to edit the portfile to get it to build against my quartz'ed gtk2 for the latest update to the port. -- Ticket URL: <https://trac.macports.org/ticket/21806#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#21806: Wireshark no_x11 installs without GUI -------------------------------+------------------------------ Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Resolution: | Keywords: Port: wireshark | -------------------------------+------------------------------ Comment (by pokui@…): Replying to [comment:10 pokui@…]:
Replying to [comment:9 pokui@…]:
I agree with the previous comments. +no_x11 does not necessarily imply +no_quartz. no_gui or no_gtk would better portray the meaning implied here.
After thinking about this a bit +no_gtk2 etc may violate POLA. Another solution is to add a +quartz that requires +no_x11. If someone has both +no_x11 and +quartz enabled then gtk2 should not be disabled, If someone has only +no_x11 then the current interpretation could be kept.
The attached patch works exactly like the gtk2 port and adds support for the +quartz variant and ensures it's listed as a conflict with +x11. -- Ticket URL: <https://trac.macports.org/ticket/21806#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#21806: Wireshark no_x11 installs without GUI -------------------------------+------------------------------ Reporter: lkraider+ports@… | Owner: opendarwin.org@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.1 Resolution: | Keywords: haspatch Port: wireshark | -------------------------------+------------------------------ Changes (by ricci@…): * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/21806#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts