#23420: qhull-2010.1 Fix list and location of installed header files ---------------------------------------+------------------------------------ Reporter: davidm@… | Owner: mmoll@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: haspatch | Port: qhull ---------------------------------------+------------------------------------ Changes (by jmr@…): * keywords: => haspatch * owner: macports-tickets@… => mmoll@… Comment: Please remember to cc the maintainer. -- Ticket URL: <http://trac.macports.org/ticket/23420#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#23420: qhull-2010.1 Fix list and location of installed header files ---------------------------------------+------------------------------------ Reporter: davidm@… | Owner: mmoll@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: haspatch | Port: qhull ---------------------------------------+------------------------------------ Comment(by davidm@…): My comments about qhull 2010.1 only creating a static library were, I think, only valid for the unpatched qhull distribution. The qhull port already includes patches to generate a shared library. Sorry about that part of my report, but... The libqhull.h header file alone is not sufficient. One of the first things it does is... #include "user.h" ...where user.h is another qhull include file that does not get installed by the 2010.1 install process. The new src/CMakeLists.txt file I attached installs all (or at least more of) the qhull headers (including libqhull.h) in /opt/local/include/qhull. The include file needed for PLplot is "qhull/qhull_a.h"; that's how I discovered the problem. The PLplot developers are working with the qhull developers to get this change incorporated upstream, but until then this new src/CMakeLists.txt file (and the small patch to the Portfile) is necessary, AFAICT. -- Ticket URL: <http://trac.macports.org/ticket/23420#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#23420: qhull-2010.1 Fix list and location of installed header files ---------------------------------------+------------------------------------ Reporter: davidm@… | Owner: mmoll@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: haspatch | Port: qhull ---------------------------------------+------------------------------------ Comment(by davidm@…): Seems good except that I think the headers should go in ${prefix}/include/qhull rather than just ${prefix}/include. Many of them are very generically named (e.g. io.h, mem.h, etc.) so leaving them in ".../include" seems like asking for trouble (plus existing client code expects to include them via {{{#include <qhull/qhull_a.h>}}}). {{{ $ port contents qhull | grep include /opt/local/include/geom.h /opt/local/include/io.h /opt/local/include/libqhull.h /opt/local/include/mem.h /opt/local/include/merge.h /opt/local/include/poly.h /opt/local/include/qhull.h /opt/local/include/qhull_a.h /opt/local/include/qset.h /opt/local/include/random.h /opt/local/include/stat.h /opt/local/include/user.h }}} A simple change to the last line of files/patch-src-CMakeLists.txt.diff (r63289) takes care of that... +install(FILES ${qhull_hdr} DESTINATION include/qhull) {{{ $ port contents qhull | grep include /opt/local/include/qhull/geom.h /opt/local/include/qhull/io.h /opt/local/include/qhull/libqhull.h /opt/local/include/qhull/mem.h /opt/local/include/qhull/merge.h /opt/local/include/qhull/poly.h /opt/local/include/qhull/qhull.h /opt/local/include/qhull/qhull_a.h /opt/local/include/qhull/qset.h /opt/local/include/qhull/random.h /opt/local/include/qhull/stat.h /opt/local/include/qhull/user.h }}} -- Ticket URL: <http://trac.macports.org/ticket/23420#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS