[MacPorts] #45168: chromaprint: fails to install libchromaprint.pc
#45168: chromaprint: fails to install libchromaprint.pc ----------------------+--------------------------- Reporter: devans@… | Owner: khindenburg@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: chromaprint ----------------------+--------------------------- When building on Apple platforms, port chromaprint intentionally fails to install libchromaprint.pc. See CMakeLists.txt: {{{ if(NOT APPLE AND NOT BUILD_FRAMEWORK) configure_file(${CMAKE_CURRENT_SOURCE_DIR}/libchromaprint.pc.cmake ${CMAKE_CURRENT_BINARY_DIR}/libchromaprint.pc) install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libchromaprint.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig) endif() }}} This is inappropriate for MacPorts and causes some other ports (e.g. gstreamer1-gst-plugins-bad) to fail to detect libchromaprint during the configure phase even if it is installed. -- Ticket URL: <https://trac.macports.org/ticket/45168> MacPorts <http://www.macports.org/> Ports system for OS X
#45168: chromaprint: fails to install libchromaprint.pc --------------------------+--------------------------- Reporter: devans@… | Owner: khindenburg@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: chromaprint | --------------------------+--------------------------- Comment (by egall@…): Sounds like an upstream issue, although I suppose it does make sense to just patch it in the meantime while waiting on upstream... -- Ticket URL: <https://trac.macports.org/ticket/45168#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#45168: chromaprint: fails to install libchromaprint.pc --------------------------+--------------------------- Reporter: devans@… | Owner: khindenburg@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: chromaprint | --------------------------+--------------------------- Comment (by devans@…): The upstream assumption is that if it an Apple (native) platform or a framework is being built then the pkg-config file is not needed because it is a Linux-ism and not required for an Apple native environment or a framework. An equivalent logical expression is NOT (APPLE OR BUILD_FRAMEWORK). However, in MacPorts we are often using Linux-style builds hence the need for the pkg-config file when the non-framework library is being installed. So I think just using NOT (APPLE AND BUILD_FRAMEWORK) or just NOT BUILD_FRAMEWORK would be more appropriate for MacPorts. A reasonable resolution IMO would be to apply a patch now, since this breaks pkg-config based configurations and open an issue upstream but I'm content to leave it to the maintainer's judgement. -- Ticket URL: <https://trac.macports.org/ticket/45168#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#45168: chromaprint: fails to install libchromaprint.pc --------------------------+--------------------------- Reporter: devans@… | Owner: khindenburg@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: chromaprint | --------------------------+--------------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => fixed Comment: I agree - thanks - fixed in r125843 and r125844 Issue opened https://bitbucket.org/acoustid/chromaprint/issue/13/mac-osx- install-libchromaprintpc -- Ticket URL: <https://trac.macports.org/ticket/45168#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts