[MacPorts] #26167: qt4-mac: reinplace didn't change anything in phonon.pro
#26167: qt4-mac: reinplace didn't change anything in phonon.pro -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qt4-mac -------------------------------------+-------------------------------------- Using the MacPorts base patch from #15514 I see this message: {{{ ---> Computing dependencies for qt4-mac ---> Fetching qt4-mac ---> Verifying checksum(s) for qt4-mac ---> Extracting qt4-mac ---> Applying patches to qt4-mac Warning: reinplace /PHONON_MINOR_VERSION =/s@\([^0-9]*\)[0-9]*\([^0-9]*\)@\13\2@ didn't change anything in /mp/var/macports/build/_Volumes_data_macports_ports_aqua_qt4-mac/work/qt- everywhere-opensource-src-4.6.3/src/phonon/phonon.pro ---> Configuring qt4-mac ^C }}} Seems that reinplace might not be correct. -- Ticket URL: <http://trac.macports.org/ticket/26167> MacPorts <http://www.macports.org/> Ports system for Mac OS
#26167: qt4-mac: reinplace didn't change anything in phonon.pro -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qt4-mac -------------------------------------+-------------------------------------- Comment(by michaelld@…): In this case, that's true -- but, the script is working as desired. The original file started with "PHONON_MINOR_VERSION = 3", and the reinplace replaced the '3' with another '3' (the one picked up from the CMakeLists.txt). So, yes, technically I don't need to reinplace the minor number in this case. That said, the script is generic & works with both qt4-mac & qt4-mac-devel, and should for any foreseeable qt4-mac versions. So, unless you're really against keeping this as is, that's what I'm going to do. -- Ticket URL: <http://trac.macports.org/ticket/26167#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#26167: qt4-mac: reinplace didn't change anything in phonon.pro --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: michaelld@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: wontfix | Keywords: Port: qt4-mac | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => wontfix Comment: Understood, thanks. -- Ticket URL: <http://trac.macports.org/ticket/26167#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts