March 2009 - macruby-changes - lists.macosforge.org

[1193] MacRuby/branches/experimental/rakelib/spec.rake
by source_changes＠macosforge.org 27 Mar '09

27 Mar '09

Revision: 1193 http://trac.macosforge.org/projects/ruby/changeset/1193 Author: lsansonetti(a)apple.com Date: 2009-03-26 18:06:32 -0700 (Thu, 26 Mar 2009) Log Message: ----------- redo_spec.rb is green Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-27 01:06:22 UTC (rev 1192) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-27 01:06:32 UTC (rev 1193) @@ -16,6 +16,7 @@ not or order + redo retry string symbol

1 0

[1192] MacRuby/branches/experimental/roxor.cpp
by source_changes＠macosforge.org 27 Mar '09

27 Mar '09

Revision: 1192 http://trac.macosforge.org/projects/ruby/changeset/1192 Author: lsansonetti(a)apple.com Date: 2009-03-26 18:06:22 -0700 (Thu, 26 Mar 2009) Log Message: ----------- fixed bugs in redo Modified Paths: -------------- MacRuby/branches/experimental/roxor.cpp Modified: MacRuby/branches/experimental/roxor.cpp =================================================================== --- MacRuby/branches/experimental/roxor.cpp 2009-03-27 00:24:58 UTC (rev 1191) +++ MacRuby/branches/experimental/roxor.cpp 2009-03-27 01:06:22 UTC (rev 1192) @@ -183,6 +183,7 @@ #endif BasicBlock *bb; + BasicBlock *entry_bb; ID current_mid; bool current_instance_method; ID self_id; @@ -518,6 +519,7 @@ fname = _fname; bb = NULL; + entry_bb = NULL; begin_bb = NULL; rescue_bb = NULL; current_mid = 0; @@ -2280,9 +2282,10 @@ Function *f = cast<Function>(module->getOrInsertFunction("", ft)); BasicBlock *old_rescue_bb = rescue_bb; + BasicBlock *old_entry_bb = entry_bb; + BasicBlock *old_bb = bb; rescue_bb = NULL; - BasicBlock *old_bb = bb; - bb = BasicBlock::Create("EntryBlock", f); + bb = BasicBlock::Create("MainBlock", f); std::map<ID, Value *> old_lvars = lvars; lvars.clear(); @@ -2400,6 +2403,10 @@ Value *val = NULL; if (node->nd_body != NULL) { + entry_bb = BasicBlock::Create("entry_point", f); + BranchInst::Create(entry_bb, bb); + bb = entry_bb; + DEBUG_LEVEL_INC(); val = compile_node(node->nd_body); DEBUG_LEVEL_DEC(); @@ -2410,6 +2417,7 @@ ReturnInst::Create(val, bb); bb = old_bb; + entry_bb = old_entry_bb; lvars = old_lvars; current_self = old_self; rescue_bb = old_rescue_bb; @@ -3275,19 +3283,23 @@ if (nd_type(node) == NODE_BREAK) { if (breakFunc == NULL) { // void rb_vm_break(VALUE val); - breakFunc = cast<Function>(module->getOrInsertFunction("rb_vm_break", + breakFunc = cast<Function>( + module->getOrInsertFunction("rb_vm_break", Type::VoidTy, RubyObjTy, NULL)); } std::vector<Value *> params; params.push_back(val); - CallInst::Create(breakFunc, params.begin(), params.end(), "", bb); + CallInst::Create(breakFunc, params.begin(), + params.end(), "", bb); + ReturnInst::Create(val, bb); } else if (nd_type(node) == NODE_REDO) { - // TODO - abort(); + assert(entry_bb != NULL); + BranchInst::Create(entry_bb, bb); } - - ReturnInst::Create(val, bb); + else { + ReturnInst::Create(val, bb); + } } compile_dead_branch(); return val;

1 0

[1191] MacRuby/branches/experimental
by source_changes＠macosforge.org 27 Mar '09

27 Mar '09

Revision: 1191 http://trac.macosforge.org/projects/ruby/changeset/1191 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 17:24:58 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Cleaned and refactored spec rake tasks and added a few such as spec:list:fails, spec:list:critical, spec:1.9:fails, spec:1.9:critical. The last few will run the macruby specs that are tagged as fails and critical against Ruby 1.9, this is to check for any 1.8 only specs and or other incompatibilities. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake MacRuby/branches/experimental/spec/frozen/ruby.1.9.mspec Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-27 00:03:49 UTC (rev 1190) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-27 00:24:58 UTC (rev 1191) @@ -45,37 +45,40 @@ yield } - MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" + KNOWN_GOOD_AND_PARTIALLY_GOOD_FILES = + FileList["spec/frozen/language/{#{(KNOWN_GOOD + KNOWN_PARTIALLY_GOOD).join(',')}}_spec.rb"] - desc "Run all spec files that should be fully green (known good)" + desc "Run all language known good spec files which should be fully green" task :green do - sh "#{MSPEC_RUN} #{FileList["spec/frozen/language/{#{KNOWN_GOOD.join(',')}}_spec.rb"].join(' ')}" + files = FileList["spec/frozen/language/{#{KNOWN_GOOD.join(',')}}_spec.rb"] + sh "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run #{files.join(' ')}" end desc "Run continuous integration language examples (all known good examples)" task :ci do - files = FileList["spec/frozen/language/{#{(KNOWN_GOOD + KNOWN_PARTIALLY_GOOD).join(',')}}_spec.rb"] - sh "./mspec/bin/mspec ci -B ./spec/frozen/macruby.mspec #{files.join(' ')}" + sh "./mspec/bin/mspec ci -B ./spec/frozen/macruby.mspec #{KNOWN_GOOD_AND_PARTIALLY_GOOD_FILES.join(' ')}" end desc "Run language examples that are known to fail" task :fails do - files = FileList["spec/frozen/language/*_spec.rb"] - files -= files.grep(/\/(#{KNOWN_GOOD.join('|')})_spec\.rb$/) - files.each do |spec| - sh "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run --format spec #{spec}" rescue nil - end + sh "./mspec/bin/mspec run -g fails -B ./spec/frozen/macruby.mspec #{KNOWN_GOOD_AND_PARTIALLY_GOOD_FILES.join(' ')}" end - desc "Run language examples" - task :language do - sh "./mspec/bin/mspec ci --format spec -B ./spec/frozen/macruby.mspec spec/frozen/language" - end - - namespace :"1.9" do - desc "Run Ruby 1.9 language examples" - task :language do - sh "./mspec/bin/mspec ci -B spec/frozen/ruby.1.9.mspec spec/frozen/language" + %w{ fails critical }.each do |tag| + namespace :list do + # We cheat by using the fact that currently the ruby.1.9.mspec script uses the macruby tags, + # otherwise macruby fails halfway because apperantly the spec files are loaded when listing tagged specs... + desc "List all specs that are tagged as `#{tag}'" + task tag do + sh "./mspec/bin/mspec tag --list #{tag} -B ./spec/frozen/ruby.1.9.mspec spec/frozen/language" + end end + + namespace :"1.9" do + desc "Run roxor language specs tagged `#{tag}' against Ruby 1.9 (use this to look for possible 1.8/1.9 incompatibility bugs)" + task tag do + sh "./mspec/bin/mspec run -g #{tag} -B ./spec/frozen/ruby.1.9.mspec #{KNOWN_GOOD_AND_PARTIALLY_GOOD_FILES.join(' ')}" + end + end end end Modified: MacRuby/branches/experimental/spec/frozen/ruby.1.9.mspec =================================================================== --- MacRuby/branches/experimental/spec/frozen/ruby.1.9.mspec 2009-03-27 00:03:49 UTC (rev 1190) +++ MacRuby/branches/experimental/spec/frozen/ruby.1.9.mspec 2009-03-27 00:24:58 UTC (rev 1191) @@ -49,10 +49,19 @@ # executable is not consistently named. set :target, 'ruby1.9' + # MacRuby TODO: For now we run the macruby tags. + # + # set :tags_patterns, [ + # [%r(language/), 'tags/1.9/language/'], + # [%r(core/), 'tags/1.9/core/'], + # [%r(library/), 'tags/1.9/library/'], + # [/_spec.rb$/, '_tags.txt'] + # ] + set :tags_patterns, [ - [%r(language/), 'tags/1.9/language/'], - [%r(core/), 'tags/1.9/core/'], - [%r(library/), 'tags/1.9/library/'], + [%r(language/), 'tags/macruby/language/'], + [%r(core/), 'tags/macruby/core/'], + [%r(library/), 'tags/macruby/library/'], [/_spec.rb$/, '_tags.txt'] ] end

1 0

[1190] MacRuby/branches/experimental/spec/frozen/tags/macruby/language/ ensure_tags.txt
by source_changes＠macosforge.org 27 Mar '09

27 Mar '09

Revision: 1190 http://trac.macosforge.org/projects/ruby/changeset/1190 Author: lsansonetti(a)apple.com Date: 2009-03-26 17:03:49 -0700 (Thu, 26 Mar 2009) Log Message: ----------- untagged specs that we are now passing Modified Paths: -------------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/ensure_tags.txt Modified: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/ensure_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/ensure_tags.txt 2009-03-26 23:59:58 UTC (rev 1189) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/ensure_tags.txt 2009-03-27 00:03:49 UTC (rev 1190) @@ -1,4 +1,2 @@ -fails:An ensure block inside a begin block is executed when an exception is raised in it's corresponding begin block fails:An ensure block inside a begin block is executed even when a symbol is thrown in it's corresponding begin block -fails:An ensure block inside a method is executed when an exception is raised in the method -fails:An ensure block inside a method is executed even when a symbol is thrown in the method \ No newline at end of file +fails:An ensure block inside a method is executed even when a symbol is thrown in the method

1 0

[1189] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1189 http://trac.macosforge.org/projects/ruby/changeset/1189 Author: lsansonetti(a)apple.com Date: 2009-03-26 16:59:58 -0700 (Thu, 26 Mar 2009) Log Message: ----------- implemented ensure without rescue + fixed a bug when compiling the fast eqq within an exception handler Modified Paths: -------------- MacRuby/branches/experimental/roxor.cpp MacRuby/branches/experimental/test_roxor.rb Modified: MacRuby/branches/experimental/roxor.cpp =================================================================== --- MacRuby/branches/experimental/roxor.cpp 2009-03-26 23:37:53 UTC (rev 1188) +++ MacRuby/branches/experimental/roxor.cpp 2009-03-26 23:59:58 UTC (rev 1189) @@ -285,6 +285,7 @@ void compile_dead_branch(void); void compile_landing_pad_header(void); void compile_landing_pad_footer(void); + void compile_rethrow_exception(void); Value *get_var(ID name, std::map<ID, Value *> &container, bool do_assert) { @@ -1340,6 +1341,20 @@ CallInst::Create(endCatchFunc, "", bb); } +void +RoxorCompiler::compile_rethrow_exception(void) +{ + Function *rethrowFunc = NULL; + if (rethrowFunc == NULL) { + // void __cxa_rethrow(void); + rethrowFunc = cast<Function>( + module->getOrInsertFunction("__cxa_rethrow", + Type::VoidTy, NULL)); + } + CallInst::Create(rethrowFunc, "", bb); + new UnreachableInst(bb); +} + Value * RoxorCompiler::compile_optimized_dispatch_call(SEL sel, int argc, std::vector<Value *> &params) { @@ -1514,6 +1529,7 @@ BranchInst::Create(then2BB, fastEqqBB, areFixnums, bb); bb = fastEqqBB; fastEqqVal = compile_fast_eqq_call(leftVal, rightVal); + fastEqqBB = bb; BranchInst::Create(mergeBB, bb); } else { @@ -3756,13 +3772,16 @@ if (n->nd_args == NULL) { // catch StandardError exceptions by default - exceptions_to_catch.push_back(ConstantInt::get(RubyObjTy, (long)rb_eStandardError)); + exceptions_to_catch.push_back( + ConstantInt::get(RubyObjTy, + (long)rb_eStandardError)); } else { NODE *n2 = n->nd_args; assert(nd_type(n2) == NODE_ARRAY); while (n2 != NULL) { - exceptions_to_catch.push_back(compile_node(n2->nd_head)); + exceptions_to_catch.push_back(compile_node( + n2->nd_head)); n2 = n2->nd_next; } } @@ -3772,9 +3791,11 @@ // bool rb_vm_is_eh_active(int argc, ...); std::vector<const Type *> types; types.push_back(Type::Int32Ty); - FunctionType *ft = FunctionType::get(Type::Int8Ty, types, true); + FunctionType *ft = FunctionType::get(Type::Int8Ty, + types, true); isEHActiveFunc = cast<Function>( - module->getOrInsertFunction("rb_vm_is_eh_active", ft)); + module->getOrInsertFunction( + "rb_vm_is_eh_active", ft)); } const int size = exceptions_to_catch.size(); @@ -3785,13 +3806,16 @@ exceptions_to_catch.begin(), exceptions_to_catch.end(), "", bb); - Value *is_handler_active = new ICmpInst(ICmpInst::ICMP_EQ, handler_active, + Value *is_handler_active = new ICmpInst(ICmpInst::ICMP_EQ, + handler_active, ConstantInt::get(Type::Int8Ty, 1), "", bb); handler_bb = BasicBlock::Create("handler", f); - BasicBlock *next_handler_bb = BasicBlock::Create("handler", f); + BasicBlock *next_handler_bb = + BasicBlock::Create("handler", f); - BranchInst::Create(handler_bb, next_handler_bb, is_handler_active, bb); + BranchInst::Create(handler_bb, next_handler_bb, + is_handler_active, bb); bb = handler_bb; assert(n->nd_body != NULL); @@ -3799,7 +3823,8 @@ handler_bb = bb; BranchInst::Create(merge_bb, bb); - handlers.push_back(std::pair<Value *, BasicBlock *>(header_val, handler_bb)); + handlers.push_back(std::pair<Value *, BasicBlock *> + (header_val, handler_bb)); bb = handler_bb = next_handler_bb; @@ -3807,15 +3832,7 @@ } bb = handler_bb; - Function *rethrowFunc = NULL; - if (rethrowFunc == NULL) { - // void __cxa_rethrow(void); - rethrowFunc = cast<Function>( - module->getOrInsertFunction("__cxa_rethrow", - Type::VoidTy, NULL)); - } - CallInst::Create(rethrowFunc, "", bb); - new UnreachableInst(bb); + compile_rethrow_exception(); bb = merge_bb; assert(handlers.size() > 0); @@ -3824,7 +3841,8 @@ } else { PHINode *pn = PHINode::Create(RubyObjTy, "op_tmp", bb); - std::vector<std::pair<Value *, BasicBlock *> >::iterator iter = handlers.begin(); + std::vector<std::pair<Value *, BasicBlock *> >::iterator + iter = handlers.begin(); while (iter != handlers.end()) { pn->addIncoming(iter->first, iter->second); ++iter; @@ -3853,14 +3871,41 @@ Function *f = bb->getParent(); BasicBlock *ensure_bb = BasicBlock::Create("ensure", f); + Value *val; - Value *val = compile_node(node->nd_head); - BranchInst::Create(ensure_bb, bb); + if (nd_type(node->nd_head) != NODE_RESCUE) { + // An ensure without a rescue (Ex. begin; ...; ensure; end) + // we must call the head within an exception handler, then + // branch on the ensure block, then re-raise the potential + // exception. + BasicBlock *new_rescue_bb = BasicBlock::Create("rescue", f); + BasicBlock *old_rescue_bb = rescue_bb; - bb = ensure_bb; - compile_node(node->nd_ensr); + rescue_bb = new_rescue_bb; + DEBUG_LEVEL_INC(); + val = compile_node(node->nd_head); + DEBUG_LEVEL_DEC(); + rescue_bb = old_rescue_bb; + BranchInst::Create(ensure_bb, bb); - return val; + bb = new_rescue_bb; + compile_landing_pad_header(); + compile_node(node->nd_ensr); + compile_rethrow_exception(); + //compile_landing_pad_footer(); + + bb = ensure_bb; + compile_node(node->nd_ensr); + } + else { + val = compile_node(node->nd_head); + BranchInst::Create(ensure_bb, bb); + + bb = ensure_bb; + compile_node(node->nd_ensr); + } + + return val;//nilVal; } break; @@ -4027,14 +4072,16 @@ case NODE_COLON3: assert(node->nd_mid > 0); - return compile_const(node->nd_mid, ConstantInt::get(RubyObjTy, (long)rb_cObject)); + return compile_const(node->nd_mid, + ConstantInt::get(RubyObjTy, (long)rb_cObject)); case NODE_CASE: { Function *f = bb->getParent(); BasicBlock *caseMergeBB = BasicBlock::Create("case_merge", f); - PHINode *pn = PHINode::Create(RubyObjTy, "case_tmp", caseMergeBB); + PHINode *pn = PHINode::Create(RubyObjTy, "case_tmp", + caseMergeBB); Value *comparedToVal = NULL; @@ -4048,14 +4095,16 @@ assert(nd_type(subnode) == NODE_WHEN); while ((subnode != NULL) && (nd_type(subnode) == NODE_WHEN)) { NODE *valueNode = subnode->nd_head; + assert(valueNode != NULL); + BasicBlock *thenBB = BasicBlock::Create("then", f); - assert(valueNode); compile_when_arguments(valueNode, comparedToVal, thenBB); BasicBlock *nextWhenBB = bb; bb = thenBB; - Value *thenVal = subnode->nd_body != NULL ? compile_node(subnode->nd_body) : nilVal; + Value *thenVal = subnode->nd_body != NULL + ? compile_node(subnode->nd_body) : nilVal; thenBB = bb; BranchInst::Create(caseMergeBB, thenBB); Modified: MacRuby/branches/experimental/test_roxor.rb =================================================================== --- MacRuby/branches/experimental/test_roxor.rb 2009-03-26 23:37:53 UTC (rev 1188) +++ MacRuby/branches/experimental/test_roxor.rb 2009-03-26 23:59:58 UTC (rev 1189) @@ -1044,7 +1044,10 @@ assert ":ok", "begin; p :ok; rescue; end" assert ":ok", "begin; raise; p :nok; rescue; p :ok; end" - assert ":ok", "begin; raise; p :nok; ensure; p :ok; end" + assert ":ok", %q{ + def m; begin; raise; ensure; p :ok; end; end + begin; m; rescue; end + } assert "42", "x = 40; begin; x += 1; rescue; ensure; x += 1; end; p x" assert "42", "x = 40; begin; raise; x = nil; rescue; x += 1; ensure; x += 1; end; p x"

1 0

[1188] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1188 http://trac.macosforge.org/projects/ruby/changeset/1188 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 16:37:53 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Tagged failing examples of the yield spec and added it to the partially green list. TODO: Had to comment 1 spec which does not compile yet. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake MacRuby/branches/experimental/spec/frozen/language/yield_spec.rb Added Paths: ----------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/yield_tags.txt Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:38 UTC (rev 1187) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:53 UTC (rev 1188) @@ -42,6 +42,7 @@ private return throw + yield } MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" Modified: MacRuby/branches/experimental/spec/frozen/language/yield_spec.rb =================================================================== --- MacRuby/branches/experimental/spec/frozen/language/yield_spec.rb 2009-03-26 23:37:38 UTC (rev 1187) +++ MacRuby/branches/experimental/spec/frozen/language/yield_spec.rb 2009-03-26 23:37:53 UTC (rev 1188) @@ -27,15 +27,16 @@ def f; yield *[*[1]]; end; f {|a| a.should == 1 } end - # MR: critical - it "assigns objects followed by splatted objects to block variables" do - def f; yield 1, *nil; end; f {|a, b| b.should == nil } - def f; yield 1, *1; end; f {|a, b| b.should == 1 } - def f; yield 1, *[1]; end; f {|a, b| b.should == 1 } - def f; yield 1, *[nil]; end; f {|a, b| b.should == nil } - def f; yield 1, *[[]]; end; f {|a, b| b.should == [] } - def f; yield 1, *[*[1]]; end; f {|a, b| b.should == 1 } - end + # MacRuby TODO: These do not compile yet. + # + # it "assigns objects followed by splatted objects to block variables" do + # def f; yield 1, *nil; end; f {|a, b| b.should == nil } + # def f; yield 1, *1; end; f {|a, b| b.should == 1 } + # def f; yield 1, *[1]; end; f {|a, b| b.should == 1 } + # def f; yield 1, *[nil]; end; f {|a, b| b.should == nil } + # def f; yield 1, *[[]]; end; f {|a, b| b.should == [] } + # def f; yield 1, *[*[1]]; end; f {|a, b| b.should == 1 } + # end it "assigns objects to block variables that include the splat operator inside the block" do def f; yield; end; f {|*a| a.should == [] } Added: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/yield_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/yield_tags.txt (rev 0) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/yield_tags.txt 2009-03-26 23:37:53 UTC (rev 1188) @@ -0,0 +1,4 @@ +fails:Assignment via yield assigns splatted objects to block variables +fails:Assignment via yield assigns splatted objects to block variables +fails:Assignment via yield assigns objects to splatted block variables that include the splat operator inside the block +fails:Assignment via yield assigns splatted objects to multiple block variables \ No newline at end of file

1 0

[1187] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1187 http://trac.macosforge.org/projects/ruby/changeset/1187 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 16:37:38 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Tagged failing examples of the throw spec and added it to the partially green list. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake Added Paths: ----------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/throw_tags.txt Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:25 UTC (rev 1186) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:38 UTC (rev 1187) @@ -41,6 +41,7 @@ predefined private return + throw } MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" Added: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/throw_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/throw_tags.txt (rev 0) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/throw_tags.txt 2009-03-26 23:37:38 UTC (rev 1187) @@ -0,0 +1,7 @@ +fails:The throw keyword abandons processing +fails:The throw keyword supports a second parameter +fails:The throw keyword only allows symbols and strings as it's argument +fails:The throw keyword unwinds stack from within a method +fails:The throw keyword unwinds stack from within a lambda +fails:The throw keyword raises a name error if outside of scope of a matching catch +fails:The throw keyword raises a ThreadError if used to exit a thread \ No newline at end of file

1 0

[1186] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1186 http://trac.macosforge.org/projects/ruby/changeset/1186 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 16:37:25 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Tagged failing examples of the return spec and added it to the partially green list. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake Added Paths: ----------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/return_tags.txt Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:12 UTC (rev 1185) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:25 UTC (rev 1186) @@ -40,6 +40,7 @@ precedence predefined private + return } MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" Added: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/return_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/return_tags.txt (rev 0) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/return_tags.txt 2009-03-26 23:37:25 UTC (rev 1186) @@ -0,0 +1,10 @@ +fails:The return keyword in a Thread raises a ThreadError if used to exit a thread +fails:The return keyword when passed a splat returns nil when the ary is empty +fails:The return keyword when passed a splat returns the first element when the array is size of 1 +fails:The return keyword when passed a splat returns a non-array when used as a splat +fails:The return keyword when passed a splat calls 'to_a' on the splatted value first +fails:The return keyword when passed a splat calls 'to_ary' on the splatted value first +fails:The return keyword within a begin executes return at base of ensure stack +fails:The return keyword within a block raises a LocalJumpError if there is no lexicaly enclosing method +fails:The return keyword within a block causes the method that lexically encloses the block to return +fails:The return keyword within a block returns from the lexically enclosing method even in case of chained calls \ No newline at end of file

1 0

[1185] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1185 http://trac.macosforge.org/projects/ruby/changeset/1185 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 16:37:12 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Tagged failing examples of the private spec and added it to the partially green list. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake Added Paths: ----------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/private_tags.txt Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:00 UTC (rev 1184) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:12 UTC (rev 1185) @@ -39,6 +39,7 @@ next precedence predefined + private } MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" Added: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/private_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/private_tags.txt (rev 0) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/private_tags.txt 2009-03-26 23:37:12 UTC (rev 1185) @@ -0,0 +1,5 @@ +fails:The private keyword marks following methods as being private +fails:The private keyword is overridden when a new class is opened +fails:The private keyword changes visibility of previously called method +fails:The private keyword changes the visibility of the existing method in the subclass +fails:The private keyword changes visiblity of previously called methods with same send/call site \ No newline at end of file

1 0

[1184] MacRuby/branches/experimental
by source_changes＠macosforge.org 26 Mar '09

26 Mar '09

Revision: 1184 http://trac.macosforge.org/projects/ruby/changeset/1184 Author: eloy.de.enige(a)gmail.com Date: 2009-03-26 16:37:00 -0700 (Thu, 26 Mar 2009) Log Message: ----------- Tagged failing examples of the predefined spec and added it to the partially green list. TODO: Had to comment require 'stringio' which makes a test fail. Modified Paths: -------------- MacRuby/branches/experimental/rakelib/spec.rake MacRuby/branches/experimental/spec/frozen/language/predefined_spec.rb Added Paths: ----------- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/predefined_tags.txt Modified: MacRuby/branches/experimental/rakelib/spec.rake =================================================================== --- MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:36:45 UTC (rev 1183) +++ MacRuby/branches/experimental/rakelib/spec.rake 2009-03-26 23:37:00 UTC (rev 1184) @@ -38,6 +38,7 @@ metaclass next precedence + predefined } MSPEC_RUN = "./miniruby -v -I./mspec/lib -I./lib ./mspec/bin/mspec-run" Modified: MacRuby/branches/experimental/spec/frozen/language/predefined_spec.rb =================================================================== --- MacRuby/branches/experimental/spec/frozen/language/predefined_spec.rb 2009-03-26 23:36:45 UTC (rev 1183) +++ MacRuby/branches/experimental/spec/frozen/language/predefined_spec.rb 2009-03-26 23:37:00 UTC (rev 1184) @@ -1,6 +1,8 @@ require File.dirname(__FILE__) + '/../spec_helper' -require 'stringio' +# MacRuby TODO: We need StringIO for one spec: Predefined global $_ is set to the last line read by e.g. StringIO#gets +# require 'stringio' + # The following tables are excerpted from Programming Ruby: The Pragmatic Programmer's Guide' # Second Edition by Dave Thomas, Chad Fowler, and Andy Hunt, page 319-22. # Added: MacRuby/branches/experimental/spec/frozen/tags/macruby/language/predefined_tags.txt =================================================================== --- MacRuby/branches/experimental/spec/frozen/tags/macruby/language/predefined_tags.txt (rev 0) +++ MacRuby/branches/experimental/spec/frozen/tags/macruby/language/predefined_tags.txt 2009-03-26 23:37:00 UTC (rev 1184) @@ -0,0 +1,9 @@ +fails:Predefined global $~ is set at the method-scoped level rather than block-scoped +fails:Predefined global $stdout is the same as $DEFAULT_OUTPUT from 'English' library +fails:Predefined global $_ is set to the last line read by e.g. StringIO#gets +fails:Predefined global $_ is set at the method-scoped level rather than block-scoped +fails:Execution variable $: does not include on the taint check level > 1 +fails:The predefined standard object nil is an instance of NilClass +fails:The predefined standard object true is an instance of TrueClass +fails:The predefined standard object false is an instance of FalseClass +fails:The predefined global constants includes TOPLEVEL_BINDING \ No newline at end of file

1 0