Revision: 4467 http://trac.macosforge.org/projects/ruby/changeset/4467 Author: martinlagardette@apple.com Date: 2010-08-25 16:45:27 -0700 (Wed, 25 Aug 2010) Log Message: ----------- Fix small GC issues with Skreenics Modified Paths: -------------- MacRuby/trunk/sample-macruby/Skreenics/src/Operations/SKGenerateThumbnailOperation.rb MacRuby/trunk/sample-macruby/Skreenics/src/SkreenicsAppDelegate.rb Modified: MacRuby/trunk/sample-macruby/Skreenics/src/Operations/SKGenerateThumbnailOperation.rb =================================================================== --- MacRuby/trunk/sample-macruby/Skreenics/src/Operations/SKGenerateThumbnailOperation.rb 2010-08-25 22:21:53 UTC (rev 4466) +++ MacRuby/trunk/sample-macruby/Skreenics/src/Operations/SKGenerateThumbnailOperation.rb 2010-08-25 23:45:27 UTC (rev 4467) @@ -232,10 +232,11 @@ repr.representationUsingType(imageFileType, properties: nil).writeToFile(savePath, atomically: true) end - # Release all our manually allocated data - thumbnailShadow.release - resultImage.release - movie.release + # Since the code is garbage collected, there is no need to release + # the allocated variables (unlike the Obj-C version) + # thumbnailShadow.release + # resultImage.release + # movie.release QTMovie.exitQTKitOnThread Modified: MacRuby/trunk/sample-macruby/Skreenics/src/SkreenicsAppDelegate.rb =================================================================== --- MacRuby/trunk/sample-macruby/Skreenics/src/SkreenicsAppDelegate.rb 2010-08-25 22:21:53 UTC (rev 4466) +++ MacRuby/trunk/sample-macruby/Skreenics/src/SkreenicsAppDelegate.rb 2010-08-25 23:45:27 UTC (rev 4467) @@ -12,10 +12,10 @@ # We want to be able to provide alpha colors NSColor.setIgnoresAlpha(false) # Set transformers for the prefs -NSValueTransformer.setValueTransformer(ExpandedPathToIconTransformer.alloc.init.autorelease, forName: "ExpandedPathToIconTransformer") -NSValueTransformer.setValueTransformer(ExpandedPathToPathTransformer.alloc.init.autorelease, forName: "ExpandedPathToPathTransformer") +NSValueTransformer.setValueTransformer(ExpandedPathToIconTransformer.alloc.init, forName: "ExpandedPathToIconTransformer") +NSValueTransformer.setValueTransformer(ExpandedPathToPathTransformer.alloc.init, forName: "ExpandedPathToPathTransformer") # Set the default RGB to NSColor transformer -NSValueTransformer.setValueTransformer(SKRgbToNSColorTransformer.alloc.init.autorelease, forName: "SKRgbToNSColorTransformer") +NSValueTransformer.setValueTransformer(SKRgbToNSColorTransformer.alloc.init, forName: "SKRgbToNSColorTransformer") # And now we can register our user defaults NSUserDefaults.standardUserDefaults.registerDefaults(NSDictionary.dictionaryWithContentsOfFile(NSBundle.mainBundle.pathForResource("UserDefaults", ofType: "plist")))