Thanks for the tip, I&#39;ll go back and fix strscan and will make the modifications before pushing stringio.<br><br>- Matt<br><br><div class="gmail_quote">On Sun, Aug 2, 2009 at 11:22 AM, Eloy Duran <span dir="ltr">&lt;<a href="mailto:eloy.de.enige@gmail.com">eloy.de.enige@gmail.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Thanks Matt :)<br>
<br>
Indeed, in order to specify the API changes between 1.8 and 1.9 you should use version guards:<br>
<br>
  ruby_version_is &quot;&quot; ... &quot;1.9&quot; do<br>
    it &quot;works as such on all versions prior to 1.9&quot; do<br>
    end<br>
  end<br>
<br>
  ruby_version_is &quot;1.9&quot; do<br>
    it &quot;works as such on 1.9&quot; do<br>
    end<br>
  end<br>
<br>
To guard against compile errors you should use the language_version guard. See the rubyspec wiki for more info.<br>
<br>
The 1.9.x specs should target HEAD. There&#39;s no specific 1.9 target yet set for either RubySpec or MacRuby.<br>
<br>
HTH,<br><font color="#888888">
Eloy</font><div><div></div><div class="h5"><br>
<br>
On 2 aug 2009, at 19:49, Matt Aimonetti wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Eloy,<br>
<br>
Welcome back. Unfortunatelly, due to API changes, the specs can&#39;t all pass on 1.8 and 1.9 unless we use a version check mechanism.<br>
<br>
My understanding was that we should focus on 1.9.2 preview 1.<br>
<br>
What do you want me to do?<br>
<br>
- Matt<br>
<br>
Sent from my iPhone<br>
<br>
On Aug 2, 2009, at 6:42, Eloy Duran &lt;<a href="mailto:eloy.de.enige@gmail.com" target="_blank">eloy.de.enige@gmail.com</a>&gt; wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
I&#39;m un-jet lagging a bit, so I thought I&#39;d update the ruby specs again. We are now passing: 18160 examples.<br>
<br>
@Matt: Great work on the StringScanner! Could you please make sure the specs run on 1.8 as well? Currently 4 fail:<br>
<br>
$ mspec -B ruby.1.8.mspec library/stringscanner<br>
<br>
StringScanner#getch is multi-byte character sensitive FAILED<br>
StringScanner#getch should keep the encoding ERROR<br>
StringScanner#initialize_copy is a private method FAILED<br>
StringScanner#initialize is a private method FAILED<br>
<br>
@Laurent: There were quite some changes to complex that you might want to look into since you recently worked on those :)<br>
<br>
Cheers,<br>
Eloy<br>
_______________________________________________<br>
MacRuby-devel mailing list<br>
<a href="mailto:MacRuby-devel@lists.macosforge.org" target="_blank">MacRuby-devel@lists.macosforge.org</a><br>
<a href="http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel" target="_blank">http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel</a><br>
</blockquote>
_______________________________________________<br>
MacRuby-devel mailing list<br>
<a href="mailto:MacRuby-devel@lists.macosforge.org" target="_blank">MacRuby-devel@lists.macosforge.org</a><br>
<a href="http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel" target="_blank">http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel</a><br>
</blockquote>
<br>
_______________________________________________<br>
MacRuby-devel mailing list<br>
<a href="mailto:MacRuby-devel@lists.macosforge.org" target="_blank">MacRuby-devel@lists.macosforge.org</a><br>
<a href="http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel" target="_blank">http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel</a><br>
</div></div></blockquote></div><br>