Hello, The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope. dan
Hey Dan, By just reading the patch it seems there are no new versions of these examples on how the method works on 1.9.x. Could you please add those as well? Cheers, Eloy On Aug 5, 2009, at 5:44 AM, dan sinclair wrote:
Hello,
The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope.
dan
<base64.diff> _______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
As far as I can tell, those methods don't exist in the Base64 class on Ruby 1.9.2. Not sure if I'm missing something but I didn't find them. dan On Aug 6, 2009, at 3:53 AM, Eloy Duran wrote:
Hey Dan,
By just reading the patch it seems there are no new versions of these examples on how the method works on 1.9.x. Could you please add those as well?
Cheers, Eloy
On Aug 5, 2009, at 5:44 AM, dan sinclair wrote:
Hello,
The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope.
dan
<base64.diff> _______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
Ok I see, Base64 was removed from 1.9 in favour of using Array#pack and String#unpack. Which means we only need to omit it from the ruby specific mspec script. In our case macruby.mspec. If it's not yet in the obsolete list of libraries in the ruby.1.9.mspec script, then it should be added there. Eloy On 7 aug 2009, at 02:13, dan sinclair wrote:
As far as I can tell, those methods don't exist in the Base64 class on Ruby 1.9.2. Not sure if I'm missing something but I didn't find them.
dan
On Aug 6, 2009, at 3:53 AM, Eloy Duran wrote:
Hey Dan,
By just reading the patch it seems there are no new versions of these examples on how the method works on 1.9.x. Could you please add those as well?
Cheers, Eloy
On Aug 5, 2009, at 5:44 AM, dan sinclair wrote:
Hello,
The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope.
dan
<base64.diff> _______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
Well, not all of the Base64 stuff was removed. Of the four base64 test files, two of them are obsolete and two of them appear to still be valid. b64encode_spec.rb and decode_b_spec.rb are both invalid while decode64_spec.rb and encode64_spec.rb are both valid. dan On Aug 7, 2009, at 2:48 AM, Eloy Duran wrote:
Ok I see, Base64 was removed from 1.9 in favour of using Array#pack and String#unpack. Which means we only need to omit it from the ruby specific mspec script. In our case macruby.mspec. If it's not yet in the obsolete list of libraries in the ruby.1.9.mspec script, then it should be added there.
Eloy
On 7 aug 2009, at 02:13, dan sinclair wrote:
As far as I can tell, those methods don't exist in the Base64 class on Ruby 1.9.2. Not sure if I'm missing something but I didn't find them.
dan
On Aug 6, 2009, at 3:53 AM, Eloy Duran wrote:
Hey Dan,
By just reading the patch it seems there are no new versions of these examples on how the method works on 1.9.x. Could you please add those as well?
Cheers, Eloy
On Aug 5, 2009, at 5:44 AM, dan sinclair wrote:
Hello,
The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope.
dan
<base64.diff> _______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
Got it. Applied in r2269, thanks! Eloy On 9 aug 2009, at 18:52, dan sinclair wrote:
Well, not all of the Base64 stuff was removed. Of the four base64 test files, two of them are obsolete and two of them appear to still be valid.
b64encode_spec.rb and decode_b_spec.rb are both invalid while decode64_spec.rb and encode64_spec.rb are both valid.
dan
On Aug 7, 2009, at 2:48 AM, Eloy Duran wrote:
Ok I see, Base64 was removed from 1.9 in favour of using Array#pack and String#unpack. Which means we only need to omit it from the ruby specific mspec script. In our case macruby.mspec. If it's not yet in the obsolete list of libraries in the ruby.1.9.mspec script, then it should be added there.
Eloy
On 7 aug 2009, at 02:13, dan sinclair wrote:
As far as I can tell, those methods don't exist in the Base64 class on Ruby 1.9.2. Not sure if I'm missing something but I didn't find them.
dan
On Aug 6, 2009, at 3:53 AM, Eloy Duran wrote:
Hey Dan,
By just reading the patch it seems there are no new versions of these examples on how the method works on 1.9.x. Could you please add those as well?
Cheers, Eloy
On Aug 5, 2009, at 5:44 AM, dan sinclair wrote:
Hello,
The attached patch marks some specs that don't execute on Ruby 1.9.2 for me. The other Base64 specs that are broken are due to the TODO in vm_method.c, rb_mod_modfunc to do with changing scope.
dan
<base64.diff> _______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
_______________________________________________ MacRuby-devel mailing list MacRuby-devel@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel
participants (2)
-
dan sinclair
-
Eloy Duran