[MacRuby] #410: Readline merge to the recent CRuby's.
#410: Readline merge to the recent CRuby's. ------------------------------+--------------------------------------------- Reporter: kouji@… | Owner: lsansonetti@… Type: enhancement | Status: new Priority: blocker | Milestone: MacRuby 0.5 Component: MacRuby | Keywords: Readline ------------------------------+--------------------------------------------- Hi, I am the CRuby's Readline module maintainer. I created the patch for MacRuby's Readline module to merge it to the recent CRuby's. I checked it by spec. {{{ $ ./mspec/bin/mspec run -B ./spec/macruby.mspec spec/frozen/library/readline MacRuby version 0.5 (ruby 1.9.0) [universal-darwin9.0, x86_64] ................................................... Finished in 1.079747 seconds 25 files, 31 examples, 95 expectations, 0 failures, 0 errors }}} Thank you. -- Ticket URL: <http://www.macruby.org/trac/ticket/410> MacRuby <http://macruby.org/>
#410: Readline merge to the recent CRuby's. ------------------------------+--------------------------------------------- Reporter: kouji@… | Owner: lsansonetti@… Type: enhancement | Status: closed Priority: blocker | Milestone: MacRuby 0.5 Component: MacRuby | Resolution: fixed Keywords: Readline | ------------------------------+--------------------------------------------- Changes (by lsansonetti@…): * status: new => closed * resolution: => fixed Comment: Thanks a lot kouji-san! I slightly modified the patch: rb_f_notimplement was implemented in MacRuby trunk a few days ago (no need to define it anymore). line 1492 of readline.c, I had to change the assignment from {{{ rl_getc_function = (Function *) readline_getc }}} to {{{ rl_getc_function = (int (*)(FILE *))readline_getc; }}} Otherwise a warning is generated by the compiler. Mac OS X uses libedit as the default readline implementation, and in /usr/include/editline/readline.h the rl_getc_function variable is defined as {{{ extern int (*rl_getc_function)(FILE *); }}} But Function is {{{ typedef int Function(const char *, int); }}} I didn't check with GNU readline. -- Ticket URL: <http://www.macruby.org/trac/ticket/410#comment:1> MacRuby <http://macruby.org/>
#410: Readline merge to the recent CRuby's. ------------------------------+--------------------------------------------- Reporter: kouji@… | Owner: lsansonetti@… Type: enhancement | Status: closed Priority: blocker | Milestone: MacRuby 0.5 Component: MacRuby | Resolution: fixed Keywords: Readline | ------------------------------+--------------------------------------------- Comment(by eloy.de.enige@…): Nice work! -- Ticket URL: <http://www.macruby.org/trac/ticket/410#comment:2> MacRuby <http://macruby.org/>
participants (1)
-
MacRuby