こんにちはさとしさん！ Thanks for porting and committing the GrowlNotifier example. I have a few comments: 1) Could it be moved to sample-macruby/Scripts instead? I think it's a better destination, the root directory only has Xcode-based samples for the moment. 2) It is not necessary to explicitly inherit of NSObject. For example class Notifier < NSObject can be written as class Notifier because $ macirb
class X; end => nil X.ancestors => [X, NSObject, Kernel]
3) It might perhaps be a good idea to ship growl.rb with MacRuby and also provide a HotCocoa mapping for it. Like we do for layout_view.rb. Thoughts anyone? Laurent
Hi Laurent,
1) Could it be moved to sample-macruby/Scripts instead? I think it's a better destination, the root directory only has Xcode-based samples for the moment.
2) It is not necessary to explicitly inherit of NSObject.
I agree about these 2 points. Committed now :)
3) It might perhaps be a good idea to ship growl.rb with MacRuby and also provide a HotCocoa mapping for it. Like we do for layout_view.rb. Thoughts anyone?
This seems a good idea. I've also committed the first step to support hotcocoa. -- Satoshi Nakagawa
participants (2)
-
Laurent Sansonetti
-
Satoshi Nakagawa