Revision: 187 http://trac.macosforge.org/projects/xquartz/changeset/187 Author: gstaplin@apple.com Date: 2009-02-19 19:15:10 -0800 (Thu, 19 Feb 2009) Log Message: ----------- Make glXSelectEvent a no-op. Perhaps in the future it should check if the GLXDrawable is a valid GLXPbuffer, and save the mask for use with glXGetSelectedEvent. I'm going to look into adding that feature in a moment. The glXSelectEvent shouldn't actually do anything, because our Pbuffers can't be damaged, and we can't receive an event when they are, however it might be useful to have the glXGetSelectedEvent match the input mask for the glXSelectEvent. There is also the issue of issuing an XError if the drawable isn't a pbuffer or window. Technically it makes no sense to glXSelectEvent a window drawable, because there are no event types for windows according to the spec. So there is no valid mask for a window. I suspect this allowance was left in the spec for the future. Modified Paths: -------------- AppleSGLX/trunk/glx_pbuffer.c Modified: AppleSGLX/trunk/glx_pbuffer.c =================================================================== --- AppleSGLX/trunk/glx_pbuffer.c 2009-02-20 03:06:07 UTC (rev 186) +++ AppleSGLX/trunk/glx_pbuffer.c 2009-02-20 03:15:10 UTC (rev 187) @@ -707,12 +707,15 @@ PUBLIC void glXSelectEvent(Display *dpy, GLXDrawable drawable, unsigned long mask) { + +#if 0 CARD32 attribs[2]; attribs[0] = (CARD32) GLX_EVENT_MASK; attribs[1] = (CARD32) mask; ChangeDrawableAttribute( dpy, drawable, attribs, 1 ); +#endif }