So I cleaned up the source files to all include xorg-config.h ... but when I did that, I got a weird hang. I narrowed it down to NDEBUG being defined for assert.h. Undefining it for that include causes the problem to go away. I don't know why, and I can't seem to replicate it in a small test case like this: #define NDEBUG #include <assert.h> int main() { assert(0); return 1; } Anyways... I committed this to 1.2 and will do the same for 1.4 tomorrow. --Jeremy
On Nov 29, 2007, at 1:47 AM, Jeremy Huddleston wrote:
So I cleaned up the source files to all include xorg-config.h ... but when I did that, I got a weird hang. I narrowed it down to NDEBUG being defined for assert.h. Undefining it for that include causes the problem to go away. I don't know why, and I can't seem to replicate it in a small test case like this:
#define NDEBUG #include <assert.h>
int main() { assert(0); return 1; }
Anyways... I committed this to 1.2 and will do the same for 1.4 tomorrow.
Hrm. xorg-config, or dix-config? I was eventually told that xorg- config was really supposed to just be for, well, stuff that didn't fall into its own DDX (like Darwin) -- so we should be using dix- whatever instead of xorg-whatever. -- Ben Byer CoreOS / BSD Technology Group, XDarwin maintainer
On Nov 30, 2007, at 09:15, Ben Byer wrote:
Hrm. xorg-config, or dix-config? I was eventually told that xorg- config was really supposed to just be for, well, stuff that didn't fall into its own DDX (like Darwin) -- so we should be using dix- whatever instead of xorg-whatever.
yep, I did that change Wednesday night, I think. BTW, "Merge branch 'xorg-server-1.2-apple' of ssh://git.freed ..." ... use git-fetch and git-rebase instead of pull I gave some helpful aliases for this here: http://trac.macosforge.org/projects/xquartz/wiki/DeveloperInfo#RemoteChanges --Jeremy
On Nov 30, 2007, at 3:25 PM, Jeremy Huddleston wrote:
On Nov 30, 2007, at 09:15, Ben Byer wrote:
Hrm. xorg-config, or dix-config? I was eventually told that xorg- config was really supposed to just be for, well, stuff that didn't fall into its own DDX (like Darwin) -- so we should be using dix- whatever instead of xorg-whatever.
yep, I did that change Wednesday night, I think.
BTW, "Merge branch 'xorg-server-1.2-apple' of ssh:// git.freed ..." ... use git-fetch and git-rebase instead of pull
I gave some helpful aliases for this here: http://trac.macosforge.org/projects/xquartz/wiki/DeveloperInfo#RemoteChanges
I know; I have this set up: alias gitpull='git fetch; git-rebase origin/xorg-server-1.2-apple' ... but it doesn't seem to work. So, I gritted my teeth and just did "pull". :/ -- Ben Byer CoreOS / BSD Technology Group, XDarwin maintainer
participants (2)
-
Ben Byer
-
Jeremy Huddleston