Actually, it only works in Safari up to the first error. So, Safari doesn't show what's beyond the error. Merle On Dec 6, 2007, at 9:52 AM, Jamie Kennea wrote:

On Dec 6, 2007, at 7:30 AM, Adam Mercer wrote:

...

I've been looking through recent commits using the gitweb repository viewer and encountered an error when trying to view the following diff

I know this probably isn't helpful, but it works for me on Safari 3.0.4 and on my iPhone but I do see that same error when trying to open the web page in Camino.

Jamie

_______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev

On Dec 6, 2007 12:02 PM, Adam Mercer <ramercer@gmail.com> wrote:

Thanks, I'll report it upstream

I reported this problem on the GIT mailing list and it turns out its due to freedesktop.org using a very old version of gitweb, as this problem has been fixed in upstream gitweb. Cheers Adam On Dec 8, 2007 5:49 AM, Jakub Narebski <jnareb@gmail.com> wrote:

"Lars Hjemli" <hjemli@gmail.com> writes:

...

Actually, it's a problem in both cgit and gitweb, but you need to look a bit harder to find the error in cgit. It seems that gitweb on freedesktop.org doesn't detect a file rename (due to diff.renamelimit maybe?), so it shows the full source of the offending files, while in cgit you'll need to go from the diff to either the old or the new sourcefile to get the same error:

http://cgit.freedesktop.org/xorg/xserver/tree/hw/darwin/quartz/applewmExt.h?... http://cgit.freedesktop.org/xorg/xserver/diff/hw/xquartz/applewm.c?h=xorg-se...

The problem is a number of unencoded ascii char 12.

Strange... I have checked gitweb code, and esc_html used in HTML version of diff output escapes _all_ control characters ([:cntrl:]). So ASCII char 12 should be shown as \014 in "cntrl" style.

Ahhh... I see, Freedesktop.org uses some ANCIENT version of gitweb, from before it was included in git repository.

Try to ask Freedesktop.org admins to upgrade gitweb. Some nice features include: * mod_perl compatibility * ability to display binary files correctly * gitweb do not use /usr/bin/diff, and do not use temporary files (and supports renames, typechanges and combined diff format) * better support for strange characters in contents and in pathnames * very basic support for submodules * snapshot support (optional) * forks support (optional) * 'next' links in 'commit' and 'commitdiff' view * optional features: commit search, pickaxe search, snapshots support,...