Hi, seems the list and the repository both went very quiet the same day as I signed up. Guess you're all to busy developing right? :) Anyway, I've noticed there's a few bugs in the libGL currently in Leopard, as well as the server. The sources for libGL came with Apple's X11 server package, so I was able to squish a few. Looking at the freedesktop mesa library it seems much updated, but lacks the Apple specific files (appledri.c). Is there anywhere I can find a more up to date package containing the Apple changes, can I replace it with the mesa library, or should I just stick to the one available from Apple? -- Pelle Johansson
GL is a bit of a sore spot in the server. What bugs are you talking about specifically, and can you send us your fixes? On Nov 11, 2007, Ben said """ *cough* This is the downside of Open Source -- you get to see the places I had to use duct tape to hold this all together. The X server has a dependency on Mesa (hence --with-mesa-source=....), and libGL.dylib is (nominally) built out of the Mesa source, so it makes the most sense to build it there even though it's a library. So, it's built as part of X11server: http://www.opensource.apple.com/darwinsource/10.5/X11server-46/build But wait! There's more! That version support AIGLX, but not AppleDRI. Late during Leopard's development, we realized we had to support AppleDRI, so I copied in the patched Mesa from Tiger, and we build that, and we install that (and throw away the copy we built from Mesa-6.5.2). The right way to fix this would be to merge the Apple patches against the Mesa that came with Tiger into the mainstream Mesa distribution, but I couldn't figure out how to do this. I spoke briefly with the Mesa peeps about this -- http://www.nabble.com/adding-AppleDRI-support-to-Mesa3D--t4419462.html -- but while they felt it would be easy, I spent a week trying and failed. """ The 1.2/1.3 branch of xorg-server needs Mesa-6.5.2. The 1.4 branch can use the latest release of Mesa (7.0.2). We're currently trying to squish out regressions on the 1.4 branch over 1.2/1.3 since 1.4 should solve some of our fb related crashes and get us more current with mainline. Once that's done, we can try getting Mesa 7.0.2 working nicely. All the Apple-specific changes are in git.freedesktop.org except these three patches which Ben hasn't pushed in yet: http://people.freedesktop.org/~jeremyhu/not.committed/ Ben, should I push in the xcb patch? Also, why did you remove the poll check from libXt? On Jan 26, 2008, at 03:30, Pelle Johansson wrote:
Hi,
seems the list and the repository both went very quiet the same day as I signed up. Guess you're all to busy developing right? :)
Anyway, I've noticed there's a few bugs in the libGL currently in Leopard, as well as the server. The sources for libGL came with Apple's X11 server package, so I was able to squish a few. Looking at the freedesktop mesa library it seems much updated, but lacks the Apple specific files (appledri.c). Is there anywhere I can find a more up to date package containing the Apple changes, can I replace it with the mesa library, or should I just stick to the one available from Apple? -- Pelle Johansson _______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
26 jan 2008 kl. 19.27 skrev Jeremy Huddleston:
GL is a bit of a sore spot in the server. What bugs are you talking about specifically, and can you send us your fixes?
Hi, thanks for letting me know. What I found was some invalid handling of locks, fix attached. I guess I should report it to Apple as well, haven't gotten around to it yet. This issue seems to have been long fixed in the mesa master branch though. With this patch and the one at http://trac.macosforge.org/projects/xquartz/ticket/51 I'm able to run quite a few wine apps without configuring with -- disable-opengl. With a few patches to Wine, I've actually been able to run Heroes of Might and Magic III in an X window. None of those patches are worth showing though, they're very hackish. -- Pelle Johansson
(right email address this time) 26 jan 2008 kl. 19.27 skrev Jeremy Huddleston:
GL is a bit of a sore spot in the server. What bugs are you talking about specifically, and can you send us your fixes?
Hi, thanks for letting me know. What I found was some invalid handling of locks, fix attached. I guess I should report it to Apple as well, haven't gotten around to it yet. This issue seems to have been long fixed in the mesa master branch though. With this patch and the one at http://trac.macosforge.org/projects/xquartz/ticket/51 I'm able to run quite a few wine apps without configuring with -- disable-opengl. With a few patches to Wine, I've actually been able to run Heroes of Might and Magic III in an X window. None of those patches are worth showing though, they're very hackish. -- Pelle Johansson
On Jan 26, 2008, at 11:00, Pelle Johansson wrote:
GL is a bit of a sore spot in the server. What bugs are you talking about specifically, and can you send us your fixes?
Hi,
thanks for letting me know. What I found was some invalid handling of locks, fix attached. I guess I should report it to Apple as well, haven't gotten around to it yet. This issue seems to have been long fixed in the mesa master branch though.
Yeah, as was mentioned, we want to be using mainline Mesa. The version of libGL we have right now is fairly ancient, and I don't think it's worth the time to fix it. Time would be better spent fixing latest mesa to work with us. Unfortunately, I've been swamped and haven't dedicated any time to the GL issue since there are more pressing issues in the server. We're of course very grateful for additional hands to help out =)
With this patch and the one at http://trac.macosforge.org/projects/xquartz/ticket/51
I'll push this in later
I'm able to run quite a few wine apps without configuring with -- disable-opengl.
With a few patches to Wine, I've actually been able to run Heroes of Might and Magic III in an X window. None of those patches are worth showing though, they're very hackish. -- Pelle Johansson <libgllocks.diff> _______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
I realised there was a typo in the patch I just sent. The line + if (gc || !gc->isDirect) { is of course supposed to read + if (!gc || !gc->isDirect) { Attaching the corrected patch. 26 jan 2008 kl. 20.26 skrev Jeremy Huddleston:
Yeah, as was mentioned, we want to be using mainline Mesa. The version of libGL we have right now is fairly ancient, and I don't think it's worth the time to fix it. Time would be better spent fixing latest mesa to work with us. Unfortunately, I've been swamped and haven't dedicated any time to the GL issue since there are more pressing issues in the server. We're of course very grateful for additional hands to help out =)
Diffing the ligGL from Apple with the files provided in the $XFree86$ tags gives a picture of what has been changed. Unfortunately, not all files have those tags, mostly in the mesa/ subdir. Still working on generating diffs for those. -- Pelle Johansson
Can you please send the patch to bugreport.apple.com? Something small like this with a fix can hopefully make its way into an official update with the old libGL until we can get around to integrating OSXisms into the latest Mesa release. On Jan 26, 2008, at 14:35, Pelle Johansson wrote:
I realised there was a typo in the patch I just sent. The line + if (gc || !gc->isDirect) { is of course supposed to read + if (!gc || !gc->isDirect) { Attaching the corrected patch.
26 jan 2008 kl. 20.26 skrev Jeremy Huddleston:
Yeah, as was mentioned, we want to be using mainline Mesa. The version of libGL we have right now is fairly ancient, and I don't think it's worth the time to fix it. Time would be better spent fixing latest mesa to work with us. Unfortunately, I've been swamped and haven't dedicated any time to the GL issue since there are more pressing issues in the server. We're of course very grateful for additional hands to help out =)
Diffing the ligGL from Apple with the files provided in the $XFree86$ tags gives a picture of what has been changed. Unfortunately, not all files have those tags, mostly in the mesa/ subdir. Still working on generating diffs for those. -- Pelle Johansson
<libgllocks.diff> _______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
Done, Bug ID# 5712450. -- Pelle Johansson 28 jan 2008 kl. 21.21 skrev Jeremy Huddleston:
Can you please send the patch to bugreport.apple.com? Something small like this with a fix can hopefully make its way into an official update with the old libGL until we can get around to integrating OSXisms into the latest Mesa release.
On Jan 26, 2008, at 14:35, Pelle Johansson wrote:
I realised there was a typo in the patch I just sent. The line + if (gc || !gc->isDirect) { is of course supposed to read + if (!gc || !gc->isDirect) { Attaching the corrected patch.
26 jan 2008 kl. 20.26 skrev Jeremy Huddleston:
Yeah, as was mentioned, we want to be using mainline Mesa. The version of libGL we have right now is fairly ancient, and I don't think it's worth the time to fix it. Time would be better spent fixing latest mesa to work with us. Unfortunately, I've been swamped and haven't dedicated any time to the GL issue since there are more pressing issues in the server. We're of course very grateful for additional hands to help out =)
Diffing the ligGL from Apple with the files provided in the $XFree86$ tags gives a picture of what has been changed. Unfortunately, not all files have those tags, mostly in the mesa/ subdir. Still working on generating diffs for those. -- Pelle Johansson
<libgllocks.diff> _______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
_______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
Done, Bug ID# 5712450. -- Pelle Johansson 28 jan 2008 kl. 21.21 skrev Jeremy Huddleston:
Can you please send the patch to bugreport.apple.com? Something small like this with a fix can hopefully make its way into an official update with the old libGL until we can get around to integrating OSXisms into the latest Mesa release.
On Jan 26, 2008, at 14:35, Pelle Johansson wrote:
I realised there was a typo in the patch I just sent. The line + if (gc || !gc->isDirect) { is of course supposed to read + if (!gc || !gc->isDirect) { Attaching the corrected patch.
26 jan 2008 kl. 20.26 skrev Jeremy Huddleston:
Yeah, as was mentioned, we want to be using mainline Mesa. The version of libGL we have right now is fairly ancient, and I don't think it's worth the time to fix it. Time would be better spent fixing latest mesa to work with us. Unfortunately, I've been swamped and haven't dedicated any time to the GL issue since there are more pressing issues in the server. We're of course very grateful for additional hands to help out =)
Diffing the ligGL from Apple with the files provided in the $XFree86$ tags gives a picture of what has been changed. Unfortunately, not all files have those tags, mostly in the mesa/ subdir. Still working on generating diffs for those. -- Pelle Johansson
<libgllocks.diff> _______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
_______________________________________________ Xquartz-dev mailing list Xquartz-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/xquartz-dev
participants (3)
-
Jeremy Huddleston
-
Pelle Johansson
-
Pelle Johansson