[CalendarServer-changes] [1787] CalendarServer/trunk/lib-patches/Twisted/twisted.web2.dav.xattrprops .patch

[source_changes at macosforge.org]

Revision: 1787
          http://trac.macosforge.org/projects/calendarserver/changeset/1787
Author:   wsanchez at apple.com
Date:     2007-08-13 11:58:11 -0700 (Mon, 13 Aug 2007)

Log Message:
-----------
Don't send BAD_REQUEST to a client when we find bad data on our own disk.
Send INTERNAL_SERVER_ERROR instead, and also log the error.

Modified Paths:
--------------
    CalendarServer/trunk/lib-patches/Twisted/twisted.web2.dav.xattrprops.patch

Modified: CalendarServer/trunk/lib-patches/Twisted/twisted.web2.dav.xattrprops.patch
===================================================================
--- CalendarServer/trunk/lib-patches/Twisted/twisted.web2.dav.xattrprops.patch	2007-08-13 18:42:28 UTC (rev 1786)
+++ CalendarServer/trunk/lib-patches/Twisted/twisted.web2.dav.xattrprops.patch	2007-08-13 18:58:11 UTC (rev 1787)
@@ -31,7 +31,7 @@
          return r
  
      def _decode(clazz, name):
-@@ -104,12 +99,27 @@
+@@ -104,12 +99,26 @@
                  "No such property: {%s}%s" % qname
              ))
  
@@ -42,10 +42,9 @@
 -        return doc.root_element
 +            return doc.root_element
 +        except ValueError:
-+            raise HTTPError(StatusResponse(
-+                responsecode.BAD_REQUEST,
-+                "Invalid property value stored on server: {%s}%s %s" % (qname[0], qname[1], value,)
-+            ))
++            msg = "Invalid property value stored on server: {%s}%s %s" % (qname[0], qname[1], value)
++            log.err(msg)
++            raise HTTPError(StatusResponse(responsecode.INTERNAL_SERVER_ERROR, msg))
  
      def set(self, property):
 -        self.attrs[self._encode(property.qname())] = property.toxml()

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20070813/7e7a5bfd/attachment.html