[CalendarServer-changes] [2450] CalendarServer/trunk/twistedcaldav/itip.py

[source_changes at macosforge.org]

Revision: 2450
          http://trac.macosforge.org/projects/calendarserver/changeset/2450
Author:   cdaboo at apple.com
Date:     2008-05-23 08:26:18 -0700 (Fri, 23 May 2008)

Log Message:
-----------
Don't require RSVP=TRUE in order to return an iTIP auto-reply.
Also fix some typos.

Modified Paths:
--------------
    CalendarServer/trunk/twistedcaldav/itip.py

Modified: CalendarServer/trunk/twistedcaldav/itip.py
===================================================================
--- CalendarServer/trunk/twistedcaldav/itip.py	2008-05-23 02:18:53 UTC (rev 2449)
+++ CalendarServer/trunk/twistedcaldav/itip.py	2008-05-23 15:26:18 UTC (rev 2450)
@@ -469,13 +469,13 @@
 
 def checkForReply(request, principal, calendar):
     """
-    Check whether a reply to the given iTIP message is needed. A reply will be needed if the
-    RSVP=TRUE. A reply will either be positive (accepted
+    Check whether a reply to the given iTIP message is needed. We will not process a reply
+    if RSVP=FALSE. A reply will either be positive (accepted
     invitation) or negative (denied invitation). In addition we will modify calendar to reflect
     any new state (e.g. remove RSVP, set PARTSTAT to ACCEPTED or DECLINED).
     
     BTW The incoming iTIP message may contain multiple components so we need to iterate over all those.
-    At the moment we will treat a failure on one isntances as a DECLINE of the entire set.
+    At the moment we will treat a failure on one instances as a DECLINE of the entire set.
 
     @param request: the L{twisted.web2.server.Request} for the current request.
     @param principal: the L{CalendarPrincipalFile} principal resource for the principal we are dealing with.
@@ -483,7 +483,7 @@
     @return: C{True} if a reply is needed, C{False} otherwise.
     """
     
-    # We need to fugure out whether the specified component will clash with any others in the f-b-set calendars
+    # We need to figure out whether the specified component will clash with any others in the f-b-set calendars
     accepted = True
         
     # First expand current one to get instances (only go 1 year into the future)
@@ -539,11 +539,11 @@
         return
 
     # Look for specific parameters
-    rsvp = False
+    rsvp = True
     for attendeeProp in attendeeProps:
         if "RSVP" in attendeeProp.params():
-            if attendeeProp.params()["RSVP"][0] == "TRUE":
-                rsvp = True
+            if attendeeProp.params()["RSVP"][0] == "FALSE":
+                rsvp = False
     
             # Now modify the original component
             del attendeeProp.params()["RSVP"]
@@ -864,7 +864,7 @@
 
 def mergeComponents(newcal, oldcal):
     """
-    Merge the overridden instance components in newcal into old cal replacing any
+    Merge the overridden instance components in newcal into oldcal replacing any
     matching components there.
 
     @param newcal: the new overridden instances to use.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20080523/0548337d/attachment.htm