[CalendarServer-changes] [3956] CalendarServer/trunk

[source_changes at macosforge.org]

Revision: 3956
          http://trac.macosforge.org/projects/calendarserver/changeset/3956
Author:   cdaboo at apple.com
Date:     2009-04-07 10:12:07 -0700 (Tue, 07 Apr 2009)
Log Message:
-----------
Make sure that schedule-changes only reports actual changed instances.

Modified Paths:
--------------
    CalendarServer/trunk/run
    CalendarServer/trunk/twistedcaldav/scheduling/itip.py

Modified: CalendarServer/trunk/run
===================================================================
--- CalendarServer/trunk/run	2009-04-07 17:09:44 UTC (rev 3955)
+++ CalendarServer/trunk/run	2009-04-07 17:12:07 UTC (rev 3956)
@@ -711,7 +711,7 @@
 
 caldavtester="${top}/CalDAVTester";
 
-svn_get "CalDAVTester" "${caldavtester}" "${svn_uri_base}/CalDAVTester/trunk" 3888;
+svn_get "CalDAVTester" "${caldavtester}" "${svn_uri_base}/CalDAVTester/trunk" 3955;
 
 #
 # PyFlakes

Modified: CalendarServer/trunk/twistedcaldav/scheduling/itip.py
===================================================================
--- CalendarServer/trunk/twistedcaldav/scheduling/itip.py	2009-04-07 17:09:44 UTC (rev 3955)
+++ CalendarServer/trunk/twistedcaldav/scheduling/itip.py	2009-04-07 17:12:07 UTC (rev 3956)
@@ -419,19 +419,20 @@
                 private_comment_changed = True
             
             else:
-                # Remove all property parameters
-                private_comment.params().clear()
-                
-                # Add default parameters
-                private_comment.params()["X-CALENDARSERVER-ATTENDEE-REF"] = [attendee.value()]
-                private_comment.params()["X-CALENDARSERVER-DTSTAMP"] = [dateTimeToString(datetime.datetime.now(tz=utc))]
-                
-                # Set new value
-                oldvalue = private_comment.value()
-                private_comment.setValue(attendee_comment.value())
+                # Only change if different
+                if private_comment.value() != attendee_comment.value():
+                    # Remove all property parameters
+                    private_comment.params().clear()
+                    
+                    # Add default parameters
+                    private_comment.params()["X-CALENDARSERVER-ATTENDEE-REF"] = [attendee.value()]
+                    private_comment.params()["X-CALENDARSERVER-DTSTAMP"] = [dateTimeToString(datetime.datetime.now(tz=utc))]
+                    
+                    # Set new value
+                    private_comment.setValue(attendee_comment.value())
+    
+                    private_comment_changed = True
 
-                private_comment_changed = (oldvalue != attendee_comment.value())
-
         return attendee.value(), partstat_changed, private_comment_changed
 
     @staticmethod
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20090407/62212fa8/attachment-0001.html>