[CalendarServer-changes] [6509] CalendarServer/branches/users/glyph/sharedpool/twistedcaldav/ directory/util.py

[source_changes at macosforge.org]

Revision: 6509
          http://trac.macosforge.org/projects/calendarserver/changeset/6509
Author:   glyph at apple.com
Date:     2010-11-01 14:17:12 -0700 (Mon, 01 Nov 2010)
Log Message:
-----------
add brief fixme describing problem with abortIfUncommitted

Modified Paths:
--------------
    CalendarServer/branches/users/glyph/sharedpool/twistedcaldav/directory/util.py

Modified: CalendarServer/branches/users/glyph/sharedpool/twistedcaldav/directory/util.py
===================================================================
--- CalendarServer/branches/users/glyph/sharedpool/twistedcaldav/directory/util.py	2010-11-01 21:16:56 UTC (rev 6508)
+++ CalendarServer/branches/users/glyph/sharedpool/twistedcaldav/directory/util.py	2010-11-01 21:17:12 UTC (rev 6509)
@@ -66,6 +66,10 @@
         transaction = newStore.newTransaction(repr(request))
         def abortIfUncommitted(request, response):
             try:
+                # TODO: missing 'yield' here.  For formal correctness as per
+                # the interface, this should be allowed to be a Deferred.  (The
+                # actual implementation still raises synchronously, so there's
+                # no bug currently.)
                 transaction.abort()
             except AlreadyFinishedError:
                 pass
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20101101/61b18fe4/attachment.html>