[CalendarServer-changes] [10678] CalendarServer/trunk/twext/who/xml.py

[source_changes at macosforge.org]

Revision: 10678
          http://trac.calendarserver.org//changeset/10678
Author:   wsanchez at apple.com
Date:     2013-02-11 11:47:40 -0800 (Mon, 11 Feb 2013)
Log Message:
-----------
Fail with NoSuchRecordError if create=False and non-existing records are updated.

Modified Paths:
--------------
    CalendarServer/trunk/twext/who/xml.py

Modified: CalendarServer/trunk/twext/who/xml.py
===================================================================
--- CalendarServer/trunk/twext/who/xml.py	2013-02-11 19:46:36 UTC (rev 10677)
+++ CalendarServer/trunk/twext/who/xml.py	2013-02-11 19:47:40 UTC (rev 10678)
@@ -33,9 +33,9 @@
 from xml.etree.ElementTree import Element as XMLElement
 
 from twisted.python.constants import Names, NamedConstant, Values, ValueConstant
-from twisted.internet.defer import succeed, inlineCallbacks, returnValue
+from twisted.internet.defer import succeed, fail, inlineCallbacks, returnValue
 
-from twext.who.idirectory import DirectoryServiceError
+from twext.who.idirectory import DirectoryServiceError, NoSuchRecordError
 from twext.who.idirectory import RecordType, FieldName as BaseFieldName
 from twext.who.idirectory import MatchType
 from twext.who.idirectory import DirectoryQueryMatchExpression
@@ -443,7 +443,7 @@
 
         if recordsByUID:
             if not create:
-                raise NotImplementedError("Raise something.")
+                return fail(NoSuchRecordError(recordsByUID.keys()))
 
             raise NotImplementedError("Add new records.")
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20130211/3137a133/attachment.html>