[CalendarServer-changes] [14243] twext/trunk/twext/who/opendirectory/_service.py

[source_changes at macosforge.org]

Revision: 14243
          http://trac.calendarserver.org//changeset/14243
Author:   sagen at apple.com
Date:     2015-01-05 11:04:56 -0800 (Mon, 05 Jan 2015)
Log Message:
-----------
Adding comment about deferToThread being disabled

Modified Paths:
--------------
    twext/trunk/twext/who/opendirectory/_service.py

Modified: twext/trunk/twext/who/opendirectory/_service.py
===================================================================
--- twext/trunk/twext/who/opendirectory/_service.py	2014-12-23 17:29:57 UTC (rev 14242)
+++ twext/trunk/twext/who/opendirectory/_service.py	2015-01-05 19:04:56 UTC (rev 14243)
@@ -55,6 +55,11 @@
     ODSearchPath, ODRecordType, ODAttribute, ODMatchType, ODAuthMethod,
 )
 
+# Note: the combination of threads, PyObjC, and OD.Framework is causing trouble
+# where OD requests are not completing and we're filling our thread pool.  Not
+# using deferToThread() works around the problem, but we should try to measure
+# performance impact (although in older versions of the code we were not using
+# deferToThread, so it won't be any worse than before).
 DEFER_TO_THREAD = False
 
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20150105/9be7ccf5/attachment.html>