[CalendarServer-changes] [14256] CalendarServer/trunk/txdav/dps/server.py

[source_changes at macosforge.org]

Revision: 14256
          http://trac.calendarserver.org//changeset/14256
Author:   sagen at apple.com
Date:     2015-01-07 10:03:07 -0800 (Wed, 07 Jan 2015)
Log Message:
-----------
Members not needed when faulting in a record because you later use the members() method to fetch them.  Including members lists when faulting in a record can overflow AMP

Modified Paths:
--------------
    CalendarServer/trunk/txdav/dps/server.py

Modified: CalendarServer/trunk/txdav/dps/server.py
===================================================================
--- CalendarServer/trunk/txdav/dps/server.py	2015-01-07 00:07:46 UTC (rev 14255)
+++ CalendarServer/trunk/txdav/dps/server.py	2015-01-07 18:03:07 UTC (rev 14256)
@@ -217,9 +217,14 @@
         fields = {}
         if record is not None:
             for field, value in record.fields.iteritems():
-                # FIXME: need to sort out dealing with enormous groups
-                if field.name == u"memberDNs":
+
+                # FIXME: need to sort out dealing with enormous groups; we
+                # can ignore these when sending AMP responses because the
+                # client will always fetch members via a members( ) AMP
+                # command.
+                if field.name in (u"memberDNs", u"memberUIDs"):
                     continue
+
                 valueType = record.service.fieldName.valueType(field)
                 if valueType in (unicode, bool):
                     fields[field.name] = value
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20150107/b56d2f53/attachment.html>