[CalendarServer-changes] [15280] CalendarServer/branches/users/cdaboo/update-packages
source_changes at macosforge.org
source_changes at macosforge.org
Wed Nov 4 06:37:30 PST 2015
Revision: 15280
http://trac.calendarserver.org//changeset/15280
Author: cdaboo at apple.com
Date: 2015-11-04 06:37:30 -0800 (Wed, 04 Nov 2015)
Log Message:
-----------
Package updates and fixes.
Modified Paths:
--------------
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/push/util.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/caldav.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/profiling.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/util.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/calverify_diff.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/config.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/dkimtool.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/export.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/icalsplit.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/importer.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/managetimezones.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/migrate_verify.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/obliterate.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_gateway.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_principals.py
CalendarServer/branches/users/cdaboo/update-packages/calendarserver/webcal/resource.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/ical.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/population.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/profiles.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/test_ical.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/sqlusage/requests/httpTests.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/anonymous_log.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/harpoon.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/pg_stats_analysis.py
CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/protocolanalysis.py
CalendarServer/branches/users/cdaboo/update-packages/requirements-cs.txt
CalendarServer/branches/users/cdaboo/update-packages/setup.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/accounting.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/database.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/directory/test/test_proxyprincipaldb.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/localization.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/notifications.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/sql.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/stdconfig.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_calendarquery.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_config.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_database.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_multiget.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_sql.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_timezones.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_upgrade.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_xmlutil.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezones.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezonestdservice.py
CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/upgrade.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/base/datastore/file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/index_file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/mailgateway.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_mailgateway.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/dkim.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_dkim.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_remoteservers.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_attachments.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_index_file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/index_file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/sql.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/test/test_index_file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/common/datastore/file.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/who/directory.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/base.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/parser_sax.py
CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/rfc2518.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/fileop.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/method/propfind.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/test/test_xattrprops.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/util.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/xattrprops.py
CalendarServer/branches/users/cdaboo/update-packages/txweb2/static.py
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/push/util.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/push/util.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/push/util.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -40,7 +40,8 @@
@return: C{str} topic, or empty string if value is not found
"""
- certData = open(certPath).read()
+ with open(certPath) as f:
+ certData = f.read()
return getAPNTopicFromX509(crypto.load_certificate(crypto.FILETYPE_PEM, certData))
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/caldav.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/caldav.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/caldav.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -768,7 +768,7 @@
else:
logID = ""
- if config.ProcessType is not "Utility":
+ if config.ProcessType != "Utility":
execName = ""
setproctitle(
@@ -1248,7 +1248,7 @@
"-p", str(pool.Port),
"-l", pool.BindAddress,
])
- if config.Memcached.MaxMemory is not 0:
+ if config.Memcached.MaxMemory != 0:
memcachedArgv.extend(
["-m", str(config.Memcached.MaxMemory)]
)
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/profiling.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/profiling.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/profiling.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -39,12 +39,11 @@
if self.saveStats:
p.dump_stats(self.profileOutput)
else:
- stream = open(self.profileOutput, 'w')
- s = pstats.Stats(p, stream=stream)
- s.strip_dirs()
- s.sort_stats(-1)
- s.print_stats()
- stream.close()
+ with open(self.profileOutput, 'w') as stream:
+ s = pstats.Stats(p, stream=stream)
+ s.strip_dirs()
+ s.sort_stats(-1)
+ s.print_stats()
AppProfiler.profilers["cprofile-cpu"] = CProfileCPURunner
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/util.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/util.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tap/util.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1524,8 +1524,7 @@
config.SSLPassPhraseDialog and
os.path.isfile(config.SSLPassPhraseDialog)
):
- sslPrivKey = open(config.SSLPrivateKey)
- try:
+ with open(config.SSLPrivateKey) as sslPrivKey:
keyType = None
for line in sslPrivKey.readlines():
if "-----BEGIN RSA PRIVATE KEY-----" in line:
@@ -1534,8 +1533,6 @@
elif "-----BEGIN DSA PRIVATE KEY-----" in line:
keyType = "DSA"
break
- finally:
- sslPrivKey.close()
if keyType is None:
log.error(
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/calverify_diff.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/calverify_diff.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/calverify_diff.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -24,7 +24,8 @@
def analyze(fname):
- lines = open(os.path.expanduser(fname)).read().splitlines()
+ with open(os.path.expanduser(fname)) as f:
+ lines = f.read().splitlines()
total = len(lines)
ctr = 0
results = {
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/config.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/config.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/config.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -538,9 +538,8 @@
@type pidFilename: C{str}
"""
if os.path.exists(pidFilename):
- pidFile = open(pidFilename, "r")
- pid = pidFile.read().strip()
- pidFile.close()
+ with open(pidFilename, "r") as pidFile:
+ pid = pidFile.read().strip()
try:
pid = int(pid)
except ValueError:
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/dkimtool.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/dkimtool.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/dkimtool.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -40,14 +40,16 @@
output = key.exportKey()
lineBreak = False
if options["key"]:
- open(options["key"], "w").write(output)
+ with open(options["key"], "w") as f:
+ f.write(output)
else:
print(output)
lineBreak = True
output = key.publickey().exportKey()
if options["pub-key"]:
- open(options["pub-key"], "w").write(output)
+ with open(options["pub-key"], "w") as f:
+ f.write(output)
else:
if lineBreak:
print
@@ -70,7 +72,8 @@
log.publisher.levels.setLogLevelForNamespace("txdav.caldav.datastore.scheduling.ischedule.dkim", LogLevel.debug)
# Parse the HTTP file
- request = open(options["request"]).read()
+ with open(options["request"]) as f:
+ request = f.read()
method, uri, headers, stream = _parseRequest(request)
# Setup signing headers
@@ -113,7 +116,8 @@
@inlineCallbacks
def _doVerify(options):
# Parse the HTTP file
- verify = open(os.path.expanduser(options["verify"])).read()
+ with open(os.path.expanduser(options["verify"])) as f:
+ verify = f.read()
_method, _uri, headers, body = _parseRequest(verify)
# Check for local public key
@@ -185,7 +189,9 @@
"""
Do the key lookup using the actual lookup method.
"""
- return RSA.importKey(open(self.pubkeyfile).read())
+ with open(self.pubkeyfile) as f:
+ data = f.read()
+ return RSA.importKey(data)
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/export.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/export.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/export.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -346,9 +346,8 @@
comp.addComponent(sub)
filename = os.path.join(dirname, "{}_{}.ics".format(homeUID, calendar.name()))
- fileobj = open(filename, 'wb')
- fileobj.write(comp.getTextWithTimezones(True))
- fileobj.close()
+ with open(filename, 'wb') as fileobj:
+ fileobj.write(comp.getTextWithTimezones(True))
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/icalsplit.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/icalsplit.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/icalsplit.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -29,11 +29,8 @@
converting a monolithic iCalendar object into a set of objects
that comply with CalDAV's requirements on resources.
"""
- inputFile = open(inputFileName)
- try:
+ with open(inputFileName) as inputFile:
calendar = iComponent.fromStream(inputFile)
- finally:
- inputFile.close()
assert calendar.name() == "VCALENDAR"
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/importer.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/importer.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/importer.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -362,9 +362,8 @@
for filename in os.listdir(dirname):
fullpath = os.path.join(dirname, filename)
print("Importing {}".format(fullpath))
- fileobj = open(fullpath, 'r')
- component = Component.allFromStream(fileobj)
- fileobj.close()
+ with open(fullpath, 'r') as fileobj:
+ component = Component.allFromStream(fileobj)
yield importCollectionComponent(self.store, component)
else:
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/managetimezones.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/managetimezones.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/managetimezones.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -85,7 +85,8 @@
# Get the version from the Makefile
try:
- makefile = open(os.path.join(zonedir, "Makefile")).read()
+ with open(os.path.join(zonedir, "Makefile")) as f:
+ makefile = f.read()
lines = makefile.splitlines()
for line in lines:
if line.startswith("VERSION="):
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/migrate_verify.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/migrate_verify.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/migrate_verify.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -161,36 +161,36 @@
self.output.write("-- Reading data file: %s\n" % (self.options["data"]))
- datafile = open(os.path.expanduser(self.options["data"]))
- total = 0
- invalidGUIDs = set()
- for line in datafile:
- line = line.strip()
- total += 1
- segments = line.split("/")
- while segments and segments[0] != "__uids__":
- segments.pop(0)
- if segments and len(segments) >= 6:
- guid = segments[3]
- calendar = segments[4]
- resource = segments[5]
+ with open(os.path.expanduser(self.options["data"])) as datafile:
+ total = 0
+ invalidGUIDs = set()
+ for line in datafile:
+ line = line.strip()
+ total += 1
+ segments = line.split("/")
+ while segments and segments[0] != "__uids__":
+ segments.pop(0)
+ if segments and len(segments) >= 6:
+ guid = segments[3]
+ calendar = segments[4]
+ resource = segments[5]
- if calendar == "inbox":
- self.ignoreInbox += 1
- invalidGUIDs.add(guid)
- elif calendar == "dropbox":
- self.ignoreDropbox += 1
- invalidGUIDs.add(guid)
- elif len(segments) > 6:
+ if calendar == "inbox":
+ self.ignoreInbox += 1
+ invalidGUIDs.add(guid)
+ elif calendar == "dropbox":
+ self.ignoreDropbox += 1
+ invalidGUIDs.add(guid)
+ elif len(segments) > 6:
+ self.badPaths.append(line)
+ invalidGUIDs.add(guid)
+ else:
+ self.pathsByGUID.setdefault(guid, {}).setdefault(calendar, set()).add(resource)
+ self.validPaths += 1
+ else:
+ if segments and len(segments) >= 4:
+ invalidGUIDs.add(segments[3])
self.badPaths.append(line)
- invalidGUIDs.add(guid)
- else:
- self.pathsByGUID.setdefault(guid, {}).setdefault(calendar, set()).add(resource)
- self.validPaths += 1
- else:
- if segments and len(segments) >= 4:
- invalidGUIDs.add(segments[3])
- self.badPaths.append(line)
# Remove any invalid GUIDs that actuall were valid
invalidGUIDs = [pguid for pguid in invalidGUIDs if pguid not in self.pathsByGUID]
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/obliterate.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/obliterate.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/obliterate.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -271,7 +271,8 @@
self.output.write("%s is not a valid file\n" % (self.options["data"],))
raise ConfigError
- uuids = open(self.options["data"]).read().split()
+ with open(self.options["data"]) as f:
+ uuids = f.read().split()
else:
self.output.write("One of --data or --uuid must be specified\n")
raise ConfigError
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_gateway.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_gateway.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_gateway.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -69,9 +69,8 @@
testRoot = os.path.join(os.path.dirname(__file__), "gateway")
templateName = os.path.join(testRoot, "caldavd.plist")
- templateFile = open(templateName)
- template = templateFile.read()
- templateFile.close()
+ with open(templateName) as templateFile:
+ template = templateFile.read()
databaseRoot = os.path.abspath("_spawned_scripts_db" + str(os.getpid()))
newConfig = template % {
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_principals.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_principals.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/tools/test/test_principals.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -37,9 +37,8 @@
testRoot = os.path.join(os.path.dirname(__file__), "principals")
templateName = os.path.join(testRoot, "caldavd.plist")
- templateFile = open(templateName)
- template = templateFile.read()
- templateFile.close()
+ with open(templateName) as templateFile:
+ template = templateFile.read()
databaseRoot = os.path.abspath("_spawned_scripts_db" + str(os.getpid()))
newConfig = template % {
Modified: CalendarServer/branches/users/cdaboo/update-packages/calendarserver/webcal/resource.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/calendarserver/webcal/resource.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/calendarserver/webcal/resource.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -131,11 +131,8 @@
# If we don't have a cached template, load it up.
#
if not hasattr(self, cacheAttr):
- templateFile = open(templateFileName)
- try:
+ with open(templateFileName) as templateFile:
htmlContent = templateFile.read()
- finally:
- templateFile.close()
if debug:
# Don't cache
@@ -201,6 +198,19 @@
try:
+ from osx.utils import CFTimeZoneRef
+
+ def lookupSystemTimezone():
+ try:
+ return CFTimeZoneRef.defaultTimeZoneName()
+ except:
+ return ""
+
+except ImportError:
+ def lookupSystemTimezone():
+ return ""
+
+try:
from Foundation import NSTimeZone
def lookupSystemTimezone():
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/ical.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/ical.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/ical.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -167,9 +167,8 @@
"""
path = self.serializePath()
if path and os.path.exists(path):
- f = open(path)
- comp = Component.fromString(f.read())
- f.close()
+ with open(path) as f:
+ comp = Component.fromString(f.read())
return comp
else:
return None
@@ -185,9 +184,8 @@
if component is None:
os.remove(path)
else:
- f = open(path, "w")
- f.write(str(component))
- f.close()
+ with open(path, "w") as f:
+ f.write(str(component))
self.uid = component.resourceUID() if component is not None else None
@@ -1332,7 +1330,8 @@
}
# Write JSON data
- json.dump(data, open(os.path.join(path, "index.json"), "w"), indent=2)
+ with open(os.path.join(path, "index.json"), "w") as f:
+ json.dump(data, f, indent=2)
def deserialize(self):
@@ -1349,7 +1348,8 @@
# Parse JSON data for calendars
try:
- data = json.load(open(os.path.join(path, "index.json")))
+ with open(os.path.join(path, "index.json")) as f:
+ data = json.load(f)
except IOError:
return
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/population.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/population.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/population.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -407,7 +407,8 @@
# Load parameters from config
if "thresholdsPath" in params:
- jsondata = json.load(open(params["thresholdsPath"]))
+ with open(params["thresholdsPath"]) as f:
+ jsondata = json.load(f)
elif "thresholds" in params:
jsondata = params["thresholds"]
else:
@@ -423,7 +424,8 @@
self._fields.extend(self._fields_extend)
if "benchmarksPath" in params:
- self.benchmarks = json.load(open(params["benchmarksPath"]))
+ with open(params["benchmarksPath"]) as f:
+ self.benchmarks = json.load(f)
else:
self.benchmarks = {}
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/profiles.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/profiles.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/profiles.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -915,7 +915,8 @@
# Load parameters from config
if "thresholdsPath" in params:
- jsondata = json.load(open(params["thresholdsPath"]))
+ with open(params["thresholdsPath"]) as f:
+ jsondata = json.load(f)
elif "thresholds" in params:
jsondata = params["thresholds"]
else:
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/test_ical.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/test_ical.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/loadtest/test_ical.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1540,7 +1540,9 @@
self.assertTrue(os.path.exists(indexPath))
def _normDict(d):
return dict([(k, sorted(v, key=lambda x: x["changeToken" if k == "calendars" else "url"]) if v else None,) for k, v in d.items()])
- self.assertEqual(_normDict(json.loads(open(indexPath).read())), _normDict(json.loads("""{
+ with open(indexPath) as f:
+ jdata = f.read()
+ self.assertEqual(_normDict(json.loads(jdata)), _normDict(json.loads("""{
"calendars": [
{
"changeToken": "123",
@@ -1597,11 +1599,15 @@
event1Path = os.path.join(clientPath, "calendar", "1.ics")
self.assertTrue(os.path.exists(event1Path))
- self.assertEqual(open(event1Path).read(), cal1)
+ with open(event1Path) as f:
+ data = f.read()
+ self.assertEqual(data, cal1)
event2Path = os.path.join(clientPath, "inbox", "i1.ics")
self.assertTrue(os.path.exists(event2Path))
- self.assertEqual(open(event2Path).read(), cal2)
+ with open(event2Path) as f:
+ data = f.read()
+ self.assertEqual(data, cal2)
def test_deserialization(self):
@@ -1642,7 +1648,8 @@
clientPath = os.path.join(self.client.serializePath, "user91-OS_X_10.6")
os.mkdir(clientPath)
indexPath = os.path.join(clientPath, "index.json")
- open(indexPath, "w").write("""{
+ with open(indexPath, "w") as f:
+ f.write("""{
"calendars": [
{
"changeToken": "321",
@@ -1699,10 +1706,12 @@
os.mkdir(os.path.join(clientPath, "calendar"))
event1Path = os.path.join(clientPath, "calendar", "2.ics")
- open(event1Path, "w").write(cal1)
+ with open(event1Path, "w") as f:
+ f.write(cal1)
os.mkdir(os.path.join(clientPath, "inbox"))
event1Path = os.path.join(clientPath, "inbox", "i2.ics")
- open(event1Path, "w").write(cal2)
+ with open(event1Path, "w") as f:
+ f.write(cal2)
self.client.deserialize()
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/sqlusage/requests/httpTests.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/sqlusage/requests/httpTests.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/performance/sqlusage/requests/httpTests.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -67,7 +67,8 @@
"""
Clear the server's SQL log file.
"""
- open(self.logFilePath, "w").write("")
+ with open(self.logFilePath, "w") as f:
+ f.write("")
def doRequest(self):
@@ -91,7 +92,8 @@
return float(line[pos + 2:])
# Need to skip over stats that are unlabeled
- data = open(self.logFilePath).read()
+ with open(self.logFilePath) as f:
+ data = f.read()
lines = data.splitlines()
offset = 0
while True:
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/anonymous_log.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/anonymous_log.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/anonymous_log.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -55,7 +55,10 @@
print("Exception: %s for %s" % (e, line,))
raise
+ finally:
+ f.close()
+
def anonymizeLine(self, line):
startPos = line.find("- ")
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/harpoon.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/harpoon.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/harpoon.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -41,12 +41,14 @@
pidDir = os.path.join(PROCDIR, pidString)
statsFile = os.path.join(pidDir, "stat")
- statLine = open(statsFile).read()
+ with open(statsFile) as f:
+ statLine = f.read()
stats = statLine.split()
vsize = int(stats[22])
cmdFile = os.path.join(pidDir, "cmdline")
if os.path.exists(cmdFile):
- cmdLine = open(cmdFile).read().split('\x00')
+ with open(cmdFile) as f:
+ cmdLine = f.read().split('\x00')
if cmdLine[0].startswith(PYTHON):
for arg in cmdLine[1:]:
if arg.startswith(CMDARG):
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/pg_stats_analysis.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/pg_stats_analysis.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/pg_stats_analysis.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -160,6 +160,8 @@
if line.startswith("---"):
break
+ f.close()
+
entries = []
for line in f:
bits = line.split("|")
Modified: CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/protocolanalysis.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/protocolanalysis.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/contrib/tools/protocolanalysis.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -439,6 +439,9 @@
print("Failed to process line:\n%s" % (line,))
raise
+ finally:
+ f.close()
+
# Average various items
self.averagedHourlyByMethodTime.clear()
for method, hours in self.hourlyByMethodTime.iteritems():
Modified: CalendarServer/branches/users/cdaboo/update-packages/requirements-cs.txt
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/requirements-cs.txt 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/requirements-cs.txt 2015-11-04 14:37:30 UTC (rev 15280)
@@ -7,7 +7,7 @@
zope.interface==4.1.3
setuptools==18.5
- --editable svn+http://svn.calendarserver.org/repository/calendarserver/twext/trunk@15274#egg=twextpy
+ --editable svn+http://svn.calendarserver.org/repository/calendarserver/twext/trunk@15279#egg=twextpy
cffi==1.3.0
pycparser==2.14
#twisted
Modified: CalendarServer/branches/users/cdaboo/update-packages/setup.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/setup.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/setup.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -500,9 +500,8 @@
else:
script.append(line)
- newScript = open(scriptPath, "w")
- newScript.write("\n".join(script))
- newScript.close()
+ with open(scriptPath, "w") as newScript:
+ newScript.write("\n".join(script))
#
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/accounting.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/accounting.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/accounting.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -134,11 +134,8 @@
#
# Now write out the data to the log file
#
- logFile = open(os.path.join(logRoot, logFilename), "a")
- try:
+ with open(os.path.join(logRoot, logFilename), "a") as logFile:
logFile.write(data)
- finally:
- logFile.close()
return logFilename
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/database.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/database.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/database.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -23,6 +23,7 @@
]
import thread
+import threading
try:
from txdav.base.datastore.subpostgres import postgres
@@ -41,28 +42,43 @@
-class ConnectionClosingThreadPool(ThreadPool):
+class ConnectionCloseThread(threading.Thread):
"""
- A ThreadPool that closes connections for each worker thread
+ An L{Thread} that closes its DB connection when it has finished running.
"""
- def _worker(self):
- log.debug("Starting ADBAPI thread: %s" % (thread.get_ident(),))
- ThreadPool._worker(self)
- self._closeConnection()
+ def __init__(self, group=None, target=None, name=None,
+ args=(), kwargs=None, verbose=None):
+ if target is not None:
+ self._realTarget = target
+ target = self.targetWithConnectionClose
+ super(ConnectionCloseThread, self).__init__(group=group, target=target, name=name, args=args, kwargs=kwargs, verbose=verbose)
- def _closeConnection(self):
- tid = thread.get_ident()
- log.debug("Closing ADBAPI thread: %s" % (tid,))
+ def targetWithConnectionClose(self, *args, **kwargs):
+ self._realTarget(*args, **kwargs)
+ if hasattr(self, "_db_close"):
+ self._db_close()
- conn = self.pool.connections.get(tid)
- self.pool._close(conn)
- del self.pool.connections[tid]
+class ConnectionClosingThreadPool(ThreadPool):
+ """
+ A L{ThreadPool} that closes connections for each worker thread when stopped.
+ """
+ threadFactory = ConnectionCloseThread
+
+ def stop(self):
+ for tid, conn in self.pool.connections.items():
+ for thread in self.threads:
+ if thread.ident == tid:
+ thread._db_close = lambda : self.pool.disconnect(conn)
+ ThreadPool.stop(self)
+
+
+
class AbstractADBAPIDatabase(object):
"""
A generic SQL database.
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/directory/test/test_proxyprincipaldb.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/directory/test/test_proxyprincipaldb.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/directory/test/test_proxyprincipaldb.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -89,7 +89,9 @@
self.assertEqual(membersA, set(("B", "C", "D",)))
self.assertEqual(membershipsB, set(("A",)))
+ db.close()
+
@inlineCallbacks
def test_normalDBNonAscii(self):
@@ -105,7 +107,9 @@
self.assertEqual(membersA, set(("B", "C", "D",)))
self.assertEqual(membershipsB, set((principalID,)))
+ db.close()
+
@inlineCallbacks
def test_DBIndexed(self):
@@ -114,7 +118,9 @@
db = ProxySqliteDB(db_path)
self.assertEqual(set([row[1] for row in (yield db.query("PRAGMA index_list(GROUPS)"))]), set(("GROUPNAMES", "MEMBERS")))
+ db.close()
+
@inlineCallbacks
def test_OldDB(self):
@@ -123,7 +129,9 @@
db = self.old_ProxyDB(db_path)
self.assertEqual(set([row[1] for row in (yield db.query("PRAGMA index_list(GROUPS)"))]), set())
+ db.close()
+
@inlineCallbacks
def test_DBUpgrade(self):
@@ -150,7 +158,6 @@
self.assertEqual(membershipsB, set(("A",)))
self.assertEqual(set([row[1] for row in (yield db.query("PRAGMA index_list(GROUPS)"))]), set(("GROUPNAMES", "MEMBERS")))
db.close()
- db = None
@inlineCallbacks
@@ -253,7 +260,9 @@
yield db.clean()
+ db.close()
+
@inlineCallbacks
def test_cachingDBRemove(self):
@@ -297,7 +306,9 @@
yield db.clean()
+ db.close()
+
@inlineCallbacks
def test_cachingDBRemoveSpecial(self):
@@ -333,7 +344,9 @@
yield db.clean()
+ db.close()
+
@inlineCallbacks
def test_cachingDBInsertUncached(self):
@@ -365,8 +378,10 @@
yield db.clean()
+ db.close()
+
class ProxyPrincipalDBPostgreSQL (twistedcaldav.test.util.TestCase):
"""
Directory service provisioned principals.
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/localization.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/localization.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/localization.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -27,9 +27,8 @@
from pycalendar.duration import Duration
try:
- from Foundation import (
- NSPropertyListImmutable, NSPropertyListSerialization, NSData, NSLocale
- )
+ from osx.corefoundation import CFError
+ from osx.utils import CFLocaleRef, CFDataRef, CFPropertyListRef
foundationImported = True
except ImportError:
foundationImported = False
@@ -444,16 +443,18 @@
return
# Parse the binary plist .strings file:
- parser = NSPropertyListSerialization.propertyListFromData_mutabilityOption_format_errorDescription_
- data = NSData.dataWithContentsOfMappedFile_(src)
- strings, format, error = parser(data, NSPropertyListImmutable, None, None)
- if error:
+ with open(src) as f:
+ data = f.read()
+ data = CFDataRef.fromString(data)
+ try:
+ parsed = CFPropertyListRef.createFromData(data)
+ strings = parsed.toDict()
+ except CFError as error:
raise ParseError(error)
# The format of GNUtext MO files is described here:
# http://www.gnu.org/software/autoconf/manual/gettext/MO-Files.html
- strings = dict(strings)
originals = strings.keys()
originals.sort()
@@ -538,7 +539,7 @@
return config.Localization.Language
try:
- language = NSLocale.preferredLanguages()[0]
+ language = CFLocaleRef.preferredLanguages()[0]
language = _remapLanguageCode(language)
except:
language = "en"
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/notifications.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/notifications.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/notifications.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -156,7 +156,10 @@
db_filename = os.path.join(self.resource.fp.path, NotificationsDatabase.db_basename)
super(NotificationsDatabase, self).__init__(db_filename, True, autocommit=True)
+ self.resource._txn.postCommit(self._db_close)
+ self.resource._txn.postAbort(self._db_close)
+
def allRecords(self):
records = self._db_execute("select * from NOTIFICATIONS")
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/sql.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/sql.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/sql.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -192,17 +192,17 @@
# want other processes to get stomped on or stomp on us.
old_isolation = self._db_connection.isolation_level
self._db_connection.isolation_level = None
- q.execute("begin exclusive transaction")
+ try:
+ q.execute("begin exclusive transaction")
- # We re-check whether the schema table is present again AFTER we've got an exclusive
- # lock as some other server process may have snuck in and already created it
- # before we got the lock, or whilst we were waiting for it.
- if not self._test_schema_table(q):
- self._db_init_schema_table(q)
- self._db_init_data_tables(q)
- self._db_recreate(False)
+ # We re-check whether the schema table is present again AFTER we've got an exclusive
+ # lock as some other server process may have snuck in and already created it
+ # before we got the lock, or whilst we were waiting for it.
+ if not self._test_schema_table(q):
+ self._db_init_schema_table(q)
+ self._db_init_data_tables(q)
+ self._db_recreate(False)
- try:
q.execute("commit")
except DatabaseError:
pass
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/stdconfig.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/stdconfig.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/stdconfig.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1210,7 +1210,8 @@
parser = NoUnicodePlistParser()
configDict = None
try:
- configDict = parser.parse(open(filename))
+ with open(filename) as f:
+ configDict = parser.parse(f)
except (IOError, OSError):
log.error("Configuration file does not exist or is inaccessible: %s" % (filename,))
raise ConfigurationError("Configuration file does not exist or is inaccessible: %s" % (filename,))
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_calendarquery.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_calendarquery.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_calendarquery.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -85,7 +85,8 @@
calendar = yield self.calendarUnderTest(name="calendar", home=record.uid)
for f in os.listdir(self.holidays_dir):
if f.endswith(".ics"):
- component = Component.fromString(open(os.path.join(self.holidays_dir, f)).read())
+ with open(os.path.join(self.holidays_dir, f)) as fin:
+ component = Component.fromString(fin.read())
yield calendar._createCalendarObjectWithNameInternal(f, component, internal_state=ComponentUpdateState.RAW)
yield self.commit()
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_config.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_config.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_config.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -136,7 +136,8 @@
TestCase.setUp(self)
config.setProvider(PListConfigProvider(DEFAULT_CONFIG))
self.testConfig = self.mktemp()
- open(self.testConfig, "w").write(testConfig)
+ with open(self.testConfig, "w") as f:
+ f.write(testConfig)
def tearDown(self):
@@ -565,10 +566,12 @@
config.setProvider(PListConfigProvider(DEFAULT_CONFIG))
self.testInclude = self.mktemp()
- open(self.testInclude, "w").write(testConfigInclude)
+ with open(self.testInclude, "w") as f:
+ f.write(testConfigInclude)
self.testMaster = self.mktemp()
- open(self.testMaster, "w").write(testConfigMaster % (self.testInclude,))
+ with open(self.testMaster, "w") as f:
+ f.write(testConfigMaster % (self.testInclude,))
config.load(self.testMaster)
self.assertEquals(config.HTTPPort, 9008)
@@ -630,10 +633,12 @@
self.testIncludeRoot = self.mktemp()
self.testInclude = self.testIncludeRoot + "." + socket.getfqdn()
- open(self.testInclude, "w").write(testConfigInclude)
+ with open(self.testInclude, "w") as f:
+ f.write(testConfigInclude)
self.testMaster = self.mktemp()
- open(self.testMaster, "w").write(testConfigMaster % (self.testIncludeRoot,))
+ with open(self.testMaster, "w") as f:
+ f.write(testConfigMaster % (self.testIncludeRoot,))
config.load(self.testMaster)
self.assertEquals(config.HTTPPort, 9008)
@@ -695,10 +700,12 @@
self.testIncludeRoot = self.mktemp()
self.testInclude = self.testIncludeRoot + "." + socket.gethostbyname(socket.getfqdn())
- open(self.testInclude, "w").write(testConfigInclude)
+ with open(self.testInclude, "w") as f:
+ f.write(testConfigInclude)
self.testMaster = self.mktemp()
- open(self.testMaster, "w").write(testConfigMaster % (self.testIncludeRoot,))
+ with open(self.testMaster, "w") as f:
+ f.write(testConfigMaster % (self.testIncludeRoot,))
config.load(self.testMaster)
self.assertEquals(config.HTTPPort, 9008)
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_database.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_database.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_database.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -124,6 +124,7 @@
self.assertFalse(db.initialized)
yield db.open()
self.assertTrue(db.initialized)
+ db.close()
@inlineCallbacks
@@ -154,6 +155,7 @@
self.assertEqual(items, (("FOO", "BAR"),))
items = (yield db.queryList("SELECT * from TESTTYPE"))
self.assertEqual(items, ("FOO",))
+ db.close()
@inlineCallbacks
@@ -189,6 +191,7 @@
yield self.inlineCallbackRaises(Database.TestDBRecreateUpgrade.RecreateDBException, db.open)
items = (yield db.query("SELECT * from TESTTYPE"))
self.assertEqual(items, ())
+ db.close()
@inlineCallbacks
@@ -215,6 +218,7 @@
yield db.open()
items = (yield db.query("SELECT * from TESTTYPE"))
self.assertEqual(items, (("FOO", "BAR"),))
+ db.close()
@inlineCallbacks
@@ -235,3 +239,4 @@
yield db.open()
items = (yield db.query("SELECT * from TESTTYPE"))
self.assertEqual(items, (("FOO", "BAR"),))
+ db.close()
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_multiget.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_multiget.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_multiget.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -161,8 +161,8 @@
# Now forcibly corrupt one piece of calendar data
calendar_path = os.path.join(self.docroot, "calendar_multiget_events/", "bad.ics")
- f = open(calendar_path, "w")
- f.write("""BEGIN:VCALENDAR
+ with open(calendar_path, "w") as f:
+ f.write("""BEGIN:VCALENDAR
CALSCALE:GREGORIAN
PRODID:-//Apple Computer\, Inc//iCal 2.0//EN
VERSION:2.0
@@ -173,7 +173,6 @@
DTSTAMP:20020101T121212Z
END:VCALENDAR
""".replace("\n", "\r\n"))
- f.close
okuids = ["good", ]
baduids = ["bad", ]
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_sql.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_sql.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_sql.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -107,6 +107,7 @@
self.assertFalse(hasattr(db, "_db_connection"))
self.assertTrue(db._db() is not None)
self.assertTrue(db._db_connection is not None)
+ db._db_close()
def test_connect_autocommit(self):
@@ -117,6 +118,7 @@
self.assertFalse(hasattr(db, "_db_connection"))
self.assertTrue(db._db() is not None)
self.assertTrue(db._db_connection is not None)
+ db._db_close()
def test_readwrite(self):
@@ -129,6 +131,7 @@
q = db._db().execute("SELECT * from TESTTYPE")
items = [i for i in q.fetchall()]
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
def test_readwrite_autocommit(self):
@@ -140,6 +143,7 @@
q = db._db().execute("SELECT * from TESTTYPE")
items = [i for i in q.fetchall()]
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
def test_readwrite_cursor(self):
@@ -150,6 +154,7 @@
db._db_execute("INSERT into TESTTYPE (KEY, VALUE) values (:1, :2)", "FOO", "BAR")
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
def test_readwrite_cursor_autocommit(self):
@@ -160,6 +165,7 @@
db._db_execute("INSERT into TESTTYPE (KEY, VALUE) values (:1, :2)", "FOO", "BAR")
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
def test_readwrite_rollback(self):
@@ -171,6 +177,7 @@
db._db_rollback()
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [])
+ db._db_close()
def test_close(self):
@@ -194,6 +201,7 @@
try:
db = SQL.TestDBPauseInInit(dbname)
db._db()
+ db._db_close()
self.result = True
except:
self.result = False
@@ -224,6 +232,7 @@
self.assertRaises(SQL.TestDBRecreateUpgrade.RecreateDBException, db._db)
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [])
+ db._db_close()
def test_version_upgrade_persistent(self):
@@ -249,6 +258,7 @@
self.assertTrue(db._db() is not None)
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
def test_version_upgrade_persistent_add_index(self):
@@ -268,3 +278,4 @@
self.assertTrue(db._db() is not None)
items = db._db_execute("SELECT * from TESTTYPE")
self.assertEqual(items, [("FOO", "BAR")])
+ db._db_close()
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_timezones.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_timezones.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_timezones.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -325,3 +325,5 @@
self.assertTrue(os.path.exists(os.path.join(config.DataRoot, "zoneinfo")))
self.assertTrue(os.path.exists(os.path.join(config.DataRoot, "zoneinfo", "America", "New_York.ics")))
+
+ test_copyPackage_Concurrency.skip = "This tests needs to use separate processes rather than threads to work properly as the FilesystemLock object is process-based "
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_upgrade.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_upgrade.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_upgrade.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1502,6 +1502,7 @@
)
yield txn.commit()
+ sqliteProxyService.close()
def test_resourcesXML(self):
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_xmlutil.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_xmlutil.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/test/test_xmlutil.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -85,7 +85,8 @@
def _checkXML(self, node, data):
xmlfile = self.mktemp()
writeXML(xmlfile, node)
- newdata = open(xmlfile).read()
+ with open(xmlfile) as f:
+ newdata = f.read()
self.assertEqual(newdata, data)
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezones.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezones.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezones.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -102,7 +102,8 @@
@staticmethod
def getTZVersion(dbpath):
try:
- return open(os.path.join(dbpath, "version.txt")).read().strip()
+ with open(os.path.join(dbpath, "version.txt")) as f:
+ return f.read().strip()
except IOError:
return ""
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezonestdservice.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezonestdservice.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/timezonestdservice.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -696,7 +696,9 @@
# Build TimezoneInfo object
tzid = os.path.join(path, item[:-4])
try:
- md5 = hashlib.md5(open(fullPath).read()).hexdigest()
+ with open(fullPath) as f:
+ tzdata = f.read()
+ md5 = hashlib.md5(tzdata).hexdigest()
except IOError:
log.error("Unable to read timezone file: %s" % (fullPath,))
continue
@@ -711,7 +713,8 @@
# Try links (aliases) file
try:
- aliases = open(os.path.join(self.basepath, "links.txt")).read()
+ with open(os.path.join(self.basepath, "links.txt")) as f:
+ aliases = f.read()
except IOError, e:
log.error("Unable to read links.txt file: %s" % (str(e),))
aliases = ""
@@ -922,9 +925,8 @@
tzpath = os.path.join(self.basepath, tzinfo.tzid) + ".ics"
if not os.path.exists(os.path.dirname(tzpath)):
os.makedirs(os.path.dirname(tzpath))
- f = open(tzpath, "w")
- f.write(ical)
- f.close()
+ with open(tzpath, "w") as f:
+ f.write(ical)
except IOError, e:
log.error("Unable to write calendar file for %s: %s" % (tzinfo.tzid, str(e),))
else:
Modified: CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/upgrade.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/upgrade.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/twistedcaldav/upgrade.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -342,7 +342,8 @@
def createMailTokensDatabase(config, uid, gid):
# Cause the tokens db to be created on disk so we can set the
# permissions on it now
- MailGatewayTokensDatabase(config.DataRoot).lookupByToken("")
+ db = MailGatewayTokensDatabase(config.DataRoot)
+ db.lookupByToken("")
dbPath = os.path.join(config.DataRoot, MailGatewayTokensDatabase.dbFilename)
if os.path.exists(dbPath):
@@ -352,6 +353,8 @@
if os.path.exists(journalPath):
os.chown(journalPath, uid, gid)
+ db._db_close()
+
cuaCache = {}
docRoot = config.DocumentRoot
@@ -1074,6 +1077,7 @@
yield txn.commit()
# Remove the old file
+ service.close()
os.remove(service.dbpath)
journalPath = service.dbpath + "-journal"
if os.path.exists(journalPath):
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/base/datastore/file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/base/datastore/file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/base/datastore/file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -249,7 +249,8 @@
# present. However, our unit tests use static files for their data store and those currently
# do not include the md5 xattr.
try:
- data = self._path.open().read()
+ with self._path.open() as f:
+ data = f.read()
except IOError:
return None
md5 = hashlib.md5(data).hexdigest()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/index_file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/index_file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/index_file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -95,7 +95,10 @@
db_filename = self.resource.fp.child(db_basename).path
super(AbstractCalendarIndex, self).__init__(db_filename, False)
+ self.resource._txn.postCommit(self._db_close)
+ self.resource._txn.postAbort(self._db_close)
+
def create(self):
"""
Create the index and initialize it.
@@ -1103,8 +1106,11 @@
if name.startswith("."):
continue
+ child = fp.child(name)
+ if not child.isfile():
+ continue
try:
- stream = fp.child(name).open()
+ stream = child.open()
except (IOError, OSError), e:
log.error("Unable to open resource %s: %s" % (name, e))
continue
@@ -1215,8 +1221,11 @@
if name.startswith("."):
continue
+ child = fp.child(name)
+ if not child.isfile():
+ continue
try:
- stream = fp.child(name).open()
+ stream = child.open()
except (IOError, OSError), e:
log.error("Unable to open resource %s: %s" % (name, e))
continue
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/mailgateway.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/mailgateway.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/mailgateway.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -235,6 +235,7 @@
yield txn.imipCreateToken(organizer, attendee, icaluid, token=token)
yield txn.commit()
+ oldDB._db_close()
os.remove(oldDB.dbpath)
journalPath = oldDB.dbpath + "-journal"
if os.path.exists(journalPath):
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_mailgateway.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_mailgateway.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_mailgateway.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -49,3 +49,4 @@
self.assertEquals(records[0].organizer, "urn:uuid:user01")
self.assertEquals(records[0].attendee, "mailto:attendee at example.com")
self.assertEquals(records[0].icaluid, "icaluid1")
+ oldDB._db_close()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -833,6 +833,7 @@
self.assertEquals(self.sender._scrubHeader("ABC: 123\nXYZ: 456"), "ABC: 123 XYZ: 456")
+
def partByType(message, contentType):
"""
Retrieve a MIME part from an L{email.message.Message} based on a content
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/dkim.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/dkim.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/dkim.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -494,7 +494,9 @@
def generateSignature(self, headers):
# Sign the hash
if self.key_file not in self.keys:
- self.keys[self.key_file] = RSA.importKey(open(self.key_file).read())
+ with open(self.key_file) as f:
+ key = f.read()
+ self.keys[self.key_file] = RSA.importKey(key)
return DKIMUtils.sign(headers, self.keys[self.key_file], self.hash_func)
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_dkim.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_dkim.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_dkim.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -57,8 +57,8 @@
super(TestDKIMBase, self).setUp()
self.private_keyfile = self.mktemp()
- f = open(self.private_keyfile, "w")
- f.write("""-----BEGIN RSA PRIVATE KEY-----
+ with open(self.private_keyfile, "w") as f:
+ f.write("""-----BEGIN RSA PRIVATE KEY-----
MIIEogIBAAKCAQEAw7bJxD1k5VSA5AqdfmJ7vj99oKQ4qYtSeJ5HiK6W40dzC++k
LweUWLzeUErgXwcJlyOC6rqVVPBfSJq4l7yPdVqpWUo6s2jnUsSWOfhpre22yc4B
K0QY2Euc3R+gT59eM0mtJPtWaQw5BmQ2GrV6f0OUiKi17jEPasKcxf1qZrWU0+Ik
@@ -86,7 +86,6 @@
CAXnxZHhrExMGIIa7KV33W5v7Hstl7SnPWKFgCvlBH2QoMTjoUE=
-----END RSA PRIVATE KEY-----
""")
- f.close()
pkey_data = """MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAw7bJxD1k5VSA5AqdfmJ7
vj99oKQ4qYtSeJ5HiK6W40dzC++kLweUWLzeUErgXwcJlyOC6rqVVPBfSJq4l7yP
@@ -97,11 +96,10 @@
jQIDAQAB
"""
self.public_keyfile = self.mktemp()
- f = open(self.public_keyfile, "w")
- f.write("""-----BEGIN PUBLIC KEY-----
+ with open(self.public_keyfile, "w") as f:
+ f.write("""-----BEGIN PUBLIC KEY-----
%s-----END PUBLIC KEY-----
""" % (pkey_data,))
- f.close()
self.public_key_data = pkey_data.replace("\n", "")
@@ -155,7 +153,9 @@
result = request.generateSignature(sign_this)
- key = RSA.importKey(open(self.private_keyfile).read())
+ with open(self.private_keyfile) as f:
+ key = f.read()
+ key = RSA.importKey(key)
signature = DKIMUtils.sign(sign_this, key, DKIMUtils.hash_func(algorithm))
self.assertEqual(result, signature)
@@ -214,7 +214,9 @@
ischedule-version:1.0
ischedule-message-id:%s
dkim-signature:v=1; d=example.com; s=dkim; t=%s; x=%s; a=%s; q=private-exchange:http/well-known:dns/txt; c=ischedule-relaxed/simple; h=Originator:Recipient:Content-Type:iSchedule-Version:iSchedule-Message-ID; bh=%s; b=""".replace("\n", "\r\n") % (headers.getRawHeaders("Content-Type")[0], request.message_id, request.time, request.expire, algorithm, bodyhash)
- key = RSA.importKey(open(self.private_keyfile).read())
+ with open(self.private_keyfile) as f:
+ key = f.read()
+ key = RSA.importKey(key)
signature = DKIMUtils.sign(sign_this, key, DKIMUtils.hash_func(algorithm))
self.assertEqual(result, signature)
@@ -224,7 +226,9 @@
self.assertEqual(request.headers.getRawHeaders("DKIM-Signature")[0], updated_header)
# Try to verify result using public key
- pubkey = RSA.importKey(open(self.public_keyfile).read())
+ with open(self.public_keyfile) as f:
+ pubkey = f.read()
+ pubkey = RSA.importKey(pubkey)
self.assertEqual(DKIMUtils.verify(sign_this, result, pubkey, DKIMUtils.hash_func(algorithm)), None)
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_remoteservers.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_remoteservers.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/scheduling/ischedule/test/test_remoteservers.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -27,7 +27,8 @@
def test_readXML(self):
fp = FilePath(self.mktemp())
- fp.open("w").write("""<?xml version="1.0" encoding="utf-8"?>
+ with fp.open("w") as f:
+ f.write("""<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE servers SYSTEM "servertoserver.dtd">
<servers>
<server>
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_attachments.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_attachments.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_attachments.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1789,12 +1789,14 @@
txn = self._sqlCalendarStore.newTransaction()
dattachment2 = (yield DropBoxAttachment.load(txn, "1.2", "attach_1_2.txt"))
self.assertEqual(dattachment2, None)
+ yield txn.commit()
# Managed attachment present
txn = self._sqlCalendarStore.newTransaction()
mattachment2 = (yield ManagedAttachment.load(txn, None, None, attachmentID=dattachment._attachmentID))
self.assertNotEqual(mattachment2, None)
self.assertTrue(mattachment2.isManaged())
+ yield txn.commit()
@inlineCallbacks
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -23,6 +23,7 @@
# FileStorageTests, or implementation-agnostic methods on CommonTests.
from pycalendar.datetime import DateTime
+from twext.enterprise.ienterprise import AlreadyFinishedError
from twext.python.filepath import CachingFilePath as FilePath
from twisted.internet.defer import inlineCallbacks
from twisted.trial import unittest
@@ -121,6 +122,15 @@
setUpCalendarStore(self)
+ @inlineCallbacks
+ def tearDown(self):
+ super(CalendarStoreTest, self).tearDown()
+ try:
+ yield self.txn.commit()
+ except AlreadyFinishedError:
+ pass
+
+
def test_calendarHomeWithUID_dot(self):
"""
Filenames starting with "." are reserved by this
@@ -141,6 +151,15 @@
return setUpHome1(self)
+ @inlineCallbacks
+ def tearDown(self):
+ super(CalendarHomeTest, self).tearDown()
+ try:
+ yield self.txn.commit()
+ except AlreadyFinishedError:
+ pass
+
+
def test_init(self):
"""
L{CalendarHome} has C{_path} and L{_calendarStore} attributes,
@@ -199,6 +218,15 @@
return setUpCalendar1(self)
+ @inlineCallbacks
+ def tearDown(self):
+ super(CalendarTest, self).tearDown()
+ try:
+ yield self.txn.commit()
+ except AlreadyFinishedError:
+ pass
+
+
def test_init(self):
"""
L{Calendar.__init__} sets private attributes to reflect its constructor
@@ -236,6 +264,7 @@
index = calendar._index
self.assertEquals(set((yield index.calendarObjects())),
set((yield calendar.calendarObjects())))
+ index._oldIndex._db_close()
@inlineCallbacks
@@ -381,11 +410,13 @@
(yield self.calendar1.calendarObjectWithName("1.ics")).component(),
VComponent.fromString(event1modified_text)
)
+ index = self.calendar1._index
yield self.doThenUndo()
self.assertEquals(
(yield self.calendar1.calendarObjectWithName("1.ics")).component(),
originalComponent
)
+ index._oldIndex._db_close()
@testUnimplemented
@@ -423,6 +454,15 @@
self.object1 = yield self.calendar1.calendarObjectWithName("1.ics")
+ @inlineCallbacks
+ def tearDown(self):
+ super(CalendarObjectTest, self).tearDown()
+ try:
+ yield self.txn.commit()
+ except AlreadyFinishedError:
+ pass
+
+
def test_init(self):
"""
L{CalendarObject} has instance attributes, C{_path} and C{_calendar},
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_index_file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_index_file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/caldav/datastore/test/test_index_file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -45,7 +45,8 @@
def iCalendar(self):
- text = self.fp.open().read()
+ with self.fp.open() as f:
+ text = f.read()
try:
component = Component.fromString(text)
# Fix any bogus data we can
@@ -66,8 +67,18 @@
by L{Index}.
"""
+ class MinimalTxn(object):
+
+ def postCommit(self, _ignore):
+ pass
+
+ def postAbort(self, _ignore):
+ pass
+
+
def __init__(self, filePath):
self.fp = filePath
+ self._txn = MinimalResourceReplacement.MinimalTxn()
def isCalendarCollection(self):
@@ -98,6 +109,10 @@
self.db = Index(MinimalResourceReplacement(self.indexDirPath))
+ def tearDown(self):
+ self.db._db_close()
+
+
def test_reserve_uid_ok(self):
uid = "test-test-test"
d = self.db.isReservedUID(uid)
@@ -294,9 +309,8 @@
for description, name, calendar_txt, reCreate, ok in data:
calendar = Component.fromString(calendar_txt)
if ok:
- f = open(os.path.join(self.indexDirPath.path, name), "w")
- f.write(calendar_txt)
- del f
+ with open(os.path.join(self.indexDirPath.path, name), "w") as f:
+ f.write(calendar_txt)
self.db.addResource(name, calendar, reCreate=reCreate)
self.assertTrue(self.db.resourceExists(name), msg=description)
@@ -460,9 +474,8 @@
for description, name, calendar_txt, trstart, trend in data:
calendar = Component.fromString(calendar_txt)
- f = open(os.path.join(self.indexDirPath.path, name), "w")
- f.write(calendar_txt)
- del f
+ with open(os.path.join(self.indexDirPath.path, name), "w") as f:
+ f.write(calendar_txt)
self.db.addResource(name, calendar)
self.assertTrue(self.db.resourceExists(name), msg=description)
@@ -646,9 +659,8 @@
for description, name, calendar_txt, trstart, trend, organizer, instances in data:
calendar = Component.fromString(calendar_txt)
- f = open(os.path.join(self.indexDirPath.path, name), "w")
- f.write(calendar_txt)
- del f
+ with open(os.path.join(self.indexDirPath.path, name), "w") as f:
+ f.write(calendar_txt)
self.db.addResource(name, calendar)
self.assertTrue(self.db.resourceExists(name), msg=description)
@@ -1053,9 +1065,8 @@
for description, name, calendar_txt, trstart, trend, organizer, peruserinstances in data:
calendar = Component.fromString(calendar_txt)
- f = open(os.path.join(self.indexDirPath.path, name), "w")
- f.write(calendar_txt)
- del f
+ with open(os.path.join(self.indexDirPath.path, name), "w") as f:
+ f.write(calendar_txt)
self.db.addResource(name, calendar)
self.assertTrue(self.db.resourceExists(name), msg=description)
@@ -1163,6 +1174,7 @@
def tearDown(self):
+ super(MemcacheTests, self).tearDown()
for _ignore_k, v in self.memcache._timeouts.iteritems():
if v.active():
v.cancel()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/index_file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/index_file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/index_file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -265,7 +265,10 @@
else:
self.reserver = SQLUIDReserver(self)
+ self.resource._txn.postCommit(self._db_close)
+ self.resource._txn.postAbort(self._db_close)
+
def create(self):
"""
Create the index and initialize it.
@@ -635,8 +638,11 @@
if name.startswith("."):
continue
+ child = fp.child(name)
+ if not child.isfile():
+ continue
try:
- stream = fp.child(name).open()
+ stream = child.open()
except (IOError, OSError), e:
log.error("Unable to open resource %s: %s" % (name, e))
continue
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/sql.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/sql.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/sql.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -768,7 +768,8 @@
missingNameIDs
).on(self._txn, resourceIDs=missingNameIDs)
)
- idToNameMap = dict(dict(idToNameMap), **dict(memberIDNameRows))
+ idToNameMap = dict(idToNameMap)
+ idToNameMap.update(dict(memberIDNameRows))
# now do revisions
if revision:
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/test/test_index_file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/test/test_index_file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/carddav/datastore/test/test_index_file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -33,8 +33,18 @@
by L{Index}.
"""
+ class MinimalTxn(object):
+
+ def postCommit(self, _ignore):
+ pass
+
+ def postAbort(self, _ignore):
+ pass
+
+
def __init__(self, filePath):
self.fp = filePath
+ self._txn = MinimalResourceReplacement.MinimalTxn()
def isAddressBookCollection(self):
@@ -65,6 +75,10 @@
self.db = AddressBookIndex(MinimalResourceReplacement(self.indexDirPath))
+ def tearDown(self):
+ self.db._db_close()
+
+
def test_reserve_uid_ok(self):
uid = "test-test-test"
d = self.db.isReservedUID(uid)
@@ -139,9 +153,8 @@
for description, name, vcard_txt in data:
calendar = Component.fromString(vcard_txt)
- f = open(os.path.join(self.site.resource.fp.path, name), "w")
- f.write(vcard_txt)
- del f
+ with open(os.path.join(self.site.resource.fp.path, name), "w") as f:
+ f.write(vcard_txt)
self.db.addResource(name, calendar)
self.assertTrue(self.db.resourceExists(name), msg=description)
@@ -210,6 +223,7 @@
def tearDown(self):
+ super(MemcacheTests, self).tearDown()
for _ignore_k, v in self.memcache._timeouts.iteritems():
if v.active():
v.cancel()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/common/datastore/file.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/common/datastore/file.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/common/datastore/file.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -1458,6 +1458,7 @@
"""
def __init__(self, resource):
self.resource = resource
+ self._txn = self.resource._txn
self.fp = self.resource._path
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/who/directory.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/who/directory.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/who/directory.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -743,7 +743,7 @@
params["EMAIL"] = list(self.emailAddresses)[0].encode("utf-8")
if "CUTYPE" not in params:
cuType = self.getCUType()
- if cuType is not "INDIVIDUAL":
+ if cuType != "INDIVIDUAL":
params["CUTYPE"] = cuType
return Property("ATTENDEE", self.canonicalCalendarUserAddress().encode("utf-8"), params=params)
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/base.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/base.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/base.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -92,7 +92,7 @@
if not name:
invalid()
- if name[0] is "{":
+ if name[0] == "{":
index = name.find("}")
if (index is -1 or not len(name) > index):
invalid()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/parser_sax.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/parser_sax.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/parser_sax.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -84,7 +84,7 @@
attributes_dict = {}
- if attributes.getLength() is not 0:
+ if attributes.getLength() != 0:
for attr_name in attributes.getQNames():
attributes_dict[attr_name.encode("utf-8")] = attributes.getValueByQName(attr_name)
Modified: CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/rfc2518.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/rfc2518.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txdav/xml/rfc2518.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -313,8 +313,8 @@
)
)
- if status_count is 0:
- if propstat_count is 0:
+ if status_count == 0:
+ if propstat_count == 0:
raise ValueError(
"{0} element must have one of {1} or {2}".format(
cls.sname(), Status.sname(), PropertyStatus.sname()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/fileop.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/fileop.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/fileop.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -468,6 +468,7 @@
))
# Remove stat info from filepath since we modified the backing file
+ resource_file.close()
filepath.changed()
yield success_code
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/method/propfind.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/method/propfind.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/method/propfind.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -145,7 +145,7 @@
for resource, uri in resources:
- if search_properties is "names":
+ if search_properties == "names":
try:
resource_properties = waitForDeferred(resource.listProperties(request))
yield resource_properties
@@ -163,7 +163,7 @@
responsecode.NOT_FOUND : [],
}
- if search_properties is "all":
+ if search_properties == "all":
properties_to_enumerate = waitForDeferred(resource.listAllprop(request))
yield properties_to_enumerate
properties_to_enumerate = properties_to_enumerate.getResult()
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/test/test_xattrprops.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/test/test_xattrprops.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/test/test_xattrprops.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -238,7 +238,7 @@
error = self.assertRaises(HTTPError, self.propertyStore.get, property)
self.assertEquals(error.response.code, INTERNAL_SERVER_ERROR)
self.assertEquals(
- len(self.flushLoggedErrors(UnpicklingError)), 1)
+ len(self.flushLoggedErrors(UnpicklingError, IndexError)), 1)
def test_set(self):
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/util.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/util.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/util.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -168,7 +168,7 @@
(scheme, host, path, _ignore_query, _ignore_fragment) = urlsplit(normalizeURL(url))
index = path.rfind("/")
- if index is 0:
+ if index == 0:
if path == "/":
return None
else:
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/xattrprops.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/xattrprops.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/dav/xattrprops.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -188,6 +188,12 @@
err(None, msg)
raise HTTPError(
StatusResponse(responsecode.INTERNAL_SERVER_ERROR, msg))
+ except Exception:
+ format = "Invalid property value stored on server: %s %s"
+ msg = format % (encodeXMLName(*qname), data)
+ err(None, msg)
+ raise HTTPError(
+ StatusResponse(responsecode.INTERNAL_SERVER_ERROR, msg))
else:
legacy = True
Modified: CalendarServer/branches/users/cdaboo/update-packages/txweb2/static.py
===================================================================
--- CalendarServer/branches/users/cdaboo/update-packages/txweb2/static.py 2015-11-04 14:34:33 UTC (rev 15279)
+++ CalendarServer/branches/users/cdaboo/update-packages/txweb2/static.py 2015-11-04 14:37:30 UTC (rev 15280)
@@ -551,6 +551,7 @@
fileobject = os.fdopen(os.open(outname, flags, self.permissions), 'wb', 0)
stream.readIntoFile(filestream, fileobject)
+ fileobject.close()
return outname
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/calendarserver-changes/attachments/20151104/3f53608c/attachment-0001.html>
More information about the calendarserver-changes
mailing list